floraachy/pytest2
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
13,337 Commits 32 Branches 205 Tags
637300d13d69848226f0f6bbc24102dafdfd6357
Commit Graph

13337 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Ran Benita
637300d13d testing: fix some tests to be more realistic 
Perform the operations in the order and context in which they can
legally occur.
 2021-01-24 14:08:39 +02:00
Ran Benita
c83d030028 testing/test_runner: make SetupState tests use a proper SetupState 
Previously the tests (probably unintentionally) mixed a fresh SetupState
and the generated item Session's SetupState, which led to some serious
head scratching when prodding it a bit.
 2021-01-24 14:08:39 +02:00
Ran Benita
0d4121d24b runner: collapse exception handling in SetupState.teardown_exact() 
This is equivalent but simpler.
 2021-01-24 14:08:39 +02:00
Ran Benita
bb3d43c9a6 runner: ensure item.teardown() is called even if a finalizer raised 
If one finalizer fails, all of the subsequent finalizers still run, so
the `teardown()` method should behave the same.
 2021-01-24 14:08:39 +02:00
Ran Benita
14d71b2c22 runner: make sure SetupState._finalizers is always set for a node in the stack 
This makes the stack <-> _finalizers correspondence clearer.
 2021-01-24 14:08:39 +02:00
Ran Benita
d1fcd425a3 runner: inline SetupState._pop_and_teardown() 
This will enable a simplification in the next commit.
 2021-01-24 14:08:39 +02:00
Ran Benita
2b14edb108 runner: express SetupState.teardown_all() in terms of teardown_exact() and remove it 
Makes it easier to understand with fewer methods.
 2021-01-24 14:08:39 +02:00
Ran Benita
ceb4d6f6d5 runner: inline a couple of SetupState methods 
Code is clearer this way.
 2021-01-24 14:08:39 +02:00
Ran Benita
5f4e55fb6d runner: remove dead code in teardown_all() 
When the stack is empty, the finalizers which are supposed to be
attached to nodes in the stack really ought to be empty as well. So the
code here is dead. If this doesn't happen, the assert will trigger.
 2021-01-24 14:08:39 +02:00
Ran Benita
42ae8180dd runner: inline SetupState._teardown_towards() 
Doesn't add much.
 2021-01-24 14:08:39 +02:00
Ran Benita
410622f719 runner: reorder SetupState method to make more sense 
The setup stuff happens before the teardown stuff, so put it first so
that reading the code from top to bottom makes more sense.
 2021-01-24 14:08:39 +02:00
Ran Benita
f7b0b1dd1f runner: use node's Store to keep private SetupState state instead of an attribute 
This way it gets proper typing and decoupling.
 2021-01-24 14:08:39 +02:00
Ran Benita
da70f61f67 runner: complete type annotations of SetupState 2021-01-24 14:08:39 +02:00
Hong Xu
d4f8e4b40c Explain how to create binary files in the doc of pytest.makefile. (#8255) 2021-01-21 09:58:52 -03:00
Bruno Oliveira
bda9ce4e0f Merge pull request #8250 from daq-tools/fix-twisted-capture 2021-01-20 09:45:58 -03:00
Jeff Widman
eef2d1a8e2 Fix pep8 import order in docs (#8253) 2021-01-19 11:45:45 -03:00
Andreas Motl
9ba1821e91 Fix faulthandler for Twisted Logger when used with "--capture=no" 
The Twisted Logger will return an invalid file descriptor since it is
not backed by an FD. So, let's also forward this to the same code path
as with `pytest-xdist`.
 2021-01-18 17:51:08 +01:00
Ran Benita
7f782c72ba Merge pull request #8242 from bluetech/deprecate-unittest-skip-collection 
Deprecate raising unittest.SkipTest to skip tests during collection
 2021-01-18 17:46:00 +02:00
Ran Benita
c9e9a599fe Merge pull request #8241 from bluetech/skip-improvements 
Minor code improvements in nose, unittest, skipping
 2021-01-15 15:35:57 +02:00
Ran Benita
25e657bfc1 Deprecate raising unittest.SkipTest to skip tests during collection 
It is not very clear why this code exists -- we are not running any
unittest or nose code during collection, and really these frameworks
don't have the concept of collection at all, and just raising these
exceptions at e.g. the module level would cause an error. So unless I'm
missing something, I don't think anyone is using this.

Deprecate it so we can eventually clear up this code and keep unittest
more tightly restricted to its plugin.
 2021-01-15 00:05:33 +02:00
Ran Benita
7f989203ed Improve way in which skip location is fixed up when skipped by mark 
When `pytest.skip()` is called inside a test function, the skip location
should be reported as the line that made the call, however when
`pytest.skip()` is called by the `pytest.mark.skip` and similar
mechanisms, the location should be reported at the item's location,
because the exact location is some irrelevant internal code.

Currently the item-location case is implemented by the caller setting a
boolean key on the item's store and the `skipping` plugin checking it
and fixing up the location if needed. This is really roundabout IMO and
breaks encapsulation.

Instead, allow the caller to specify directly on the skip exception
whether to use the item's location or not. For now, this is entirely
private.
 2021-01-14 18:07:25 +02:00
Ran Benita
3dde519f53 nose: type annotate with some resulting refactoring 2021-01-14 17:42:38 +02:00
Ran Benita
096bae6c68 unittest: add clarifying comment on unittest.SkipTest -> pytest.skip code 
I was tempted to remove it, until I figured out why it was there.
 2021-01-14 17:06:14 +02:00
Ran Benita
addbd3161e nose,fixtures: use the public item API for adding finalizers 2021-01-14 16:53:07 +02:00
Anton
42d5545f42 unittest: cleanup unexpected success handling (#8231) 
* unittest: cleanup unexpected success handling

* update comment
 2021-01-13 17:02:26 -08:00
Bruno Oliveira
7a5a6cb51c Merge pull request #8235 from pytest-dev/dependabot/pip/testing/plugins_integration/django-3.1.5 
build(deps): bump django from 3.1.4 to 3.1.5 in /testing/plugins_integration
 2021-01-11 08:24:47 -03:00
Bruno Oliveira
203a9b3ab2 Merge pull request #8234 from pytest-dev/dependabot/pip/testing/plugins_integration/pytest-mock-3.5.1 
build(deps): bump pytest-mock from 3.4.0 to 3.5.1 in /testing/plugins_integration
 2021-01-11 08:24:33 -03:00
dependabot[bot]
cfa0c3b0d9 build(deps): bump django in /testing/plugins_integration 
Bumps [django](https://github.com/django/django) from 3.1.4 to 3.1.5.
- [Release notes](https://github.com/django/django/releases)
- [Commits](https://github.com/django/django/compare/3.1.4...3.1.5)

Signed-off-by: dependabot[bot] <support@github.com>
 2021-01-11 03:16:03 +00:00
dependabot[bot]
af78efc7fa build(deps): bump pytest-mock in /testing/plugins_integration 
Bumps [pytest-mock](https://github.com/pytest-dev/pytest-mock) from 3.4.0 to 3.5.1.
- [Release notes](https://github.com/pytest-dev/pytest-mock/releases)
- [Changelog](https://github.com/pytest-dev/pytest-mock/blob/master/CHANGELOG.rst)
- [Commits](https://github.com/pytest-dev/pytest-mock/compare/v3.4.0...v3.5.1)

Signed-off-by: dependabot[bot] <support@github.com>
 2021-01-11 03:15:59 +00:00
Ran Benita
f6529fd3a1 Merge pull request #8232 from imrehg/doc 
Add missing import into example script in documentation
 2021-01-08 14:08:47 +02:00
Gergely Imreh
80c33c8178 Add missing import into example script in documentation 2021-01-08 11:43:51 +00:00
Bruno Oliveira
31ae4e1764 Merge pull request #8225 from The-Compiler/training-update 
doc: Add note about training early bird discount
 2021-01-05 16:31:04 -03:00
Florian Bruhin
65b8391ead doc: Add note about training early bird discount 2021-01-05 19:39:50 +01:00
Bruno Oliveira
329fff69a3 Merge pull request #8220 from xuhdev/module-doc 
DOC: Mark pytest module
 2021-01-05 13:25:02 -03:00
Ran Benita
5336ba28cc Merge pull request #8218 from bluetech/reports2 
Misc small code improvements
 2021-01-04 22:47:32 +02:00
bengartner
8e00df4c4b Add dot prefix if file makefile extension is invalid for pathlib (#8222) 2021-01-04 15:58:11 +02:00
Ran Benita
8d16bec329 Merge pull request #8216 from xuhdev/testdir-pytester 
DOC: Update multiple references to testdir to pytester
 2021-01-02 11:58:59 +02:00
Hong Xu
14b5f5e528 DOC: Mark pytest module 
Pytest document currently does not index the top-level package name
`pytest`, which causes some trouble when building documentation that
cross-refers to the pytest package via ``:mod:`pytest` ``.
 2021-01-02 00:34:52 -08:00
Ran Benita
2ff88098a7 python: inline a simple method 
I don't think it adds much value!
 2021-01-01 23:23:08 +02:00
Ran Benita
8ee6d0a866 Always use getfixturemarker() to access _pytestfixturefunction 
Keep knowledge of how the marker is stored encapsulated in one place.
 2021-01-01 23:22:10 +02:00
Ran Benita
ade253c790 fixtures: type annotate FixtureRequest.keywords 2021-01-01 23:18:17 +02:00
Ran Benita
6c575ad8c8 fixtures: simplify FixtureRequest._get_fixturestack() 2021-01-01 23:15:57 +02:00
Hong Xu
b02f1c8ae7 DOC: Update multiple references to testdir to pytester 
In https://docs.pytest.org/en/stable/reference.html#testdir, it is
suggested:

> New code should avoid using testdir in favor of pytester.

Multiple spots in the documents still use testdir and they can be quite
confusing (especially the plugin writing guide).
 2021-01-01 12:21:39 -08:00
Ran Benita
bbd22e1769 Merge pull request #8214 from sousajf1/sousajo_patch_8204_1 
pytest-dev#8204 migrate tests on testing/code/test_source to tmp_path
 2021-01-01 20:44:40 +02:00
sousajo
ac428f67eb pytest-dev#8204 migrate tests on testing/code/test_source to tmp_path 2021-01-01 16:55:03 +00:00
sousajf1
20c59e3aa4 pytest-dev#8204 migrate some tests to tmp_path fixture (#8209) 
migrating some tests from tmpdir to tmp_path fixture
 2021-01-01 17:25:11 +02:00
Ran Benita
73c4105230 reports: improve a type annotation 2021-01-01 15:22:05 +02:00
Ran Benita
7d306e9e86 reports: BaseReport.{passed,failed,skipped} more friendly to mypy 
Not smart enough to understand the previous code.
 2021-01-01 15:22:05 +02:00
mefmund
5f11a35b99 Add missing fixture (#8207) 
Co-authored-by: Florian Bruhin <me@the-compiler.org>
Co-authored-by: Bruno Oliveira <nicoddemus@gmail.com>
 2020-12-31 15:25:44 -03:00
Anton
48c9a96a03 Fix failing staticmethod tests if they are inherited (#8205) 
* Fix failing staticmethod tests if they are inherited

* add comments, set default=None
 2020-12-30 19:00:37 -08:00