floraachy
/
pytest2
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Use isinstance instead of type comparison with equal to appease the linter

This commit is contained in:
Pierre Sassoulas 2023-08-01 16:29:54 +02:00 committed by GitHub
parent f82c63ac4d
commit e2c806b8e5
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/_pytest/assertion/util.py
View File

@ -222,7 +222,7 @@ def _compare_eq_any(left: Any, right: Any, verbose: int = 0) -> List[str]:
other_side = right if isinstance(left, ApproxBase) else left other_side = right if isinstance(left, ApproxBase) else left
explanation = approx_side._repr_compare(other_side) explanation = approx_side._repr_compare(other_side)
elif type(left) == type(right) and ( elif isinstance(left, type(right)) and (
isdatacls(left) or isattrs(left) or isnamedtuple(left) isdatacls(left) or isattrs(left) or isnamedtuple(left)
): ):
# Note: unlike dataclasses/attrs, namedtuples compare only the # Note: unlike dataclasses/attrs, namedtuples compare only the

2
testing/_py/test_local.py
View File

@ -1573,4 +1573,4 @@ class TestBinaryAndTextMethods:
x.write_text(part, "ascii") x.write_text(part, "ascii")
s = x.read_text("ascii") s = x.read_text("ascii")
assert s == part assert s == part
assert type(s) == type(part) assert isinstance(s, type(part))