From e2c806b8e5b139bf24ac7606c0259c04bbeb018f Mon Sep 17 00:00:00 2001 From: Pierre Sassoulas Date: Tue, 1 Aug 2023 16:29:54 +0200 Subject: [PATCH] Use isinstance instead of type comparison with equal to appease the linter --- src/_pytest/assertion/util.py | 2 +- testing/_py/test_local.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/_pytest/assertion/util.py b/src/_pytest/assertion/util.py index fc5dfdbd5..0c2d5dfb6 100644 --- a/src/_pytest/assertion/util.py +++ b/src/_pytest/assertion/util.py @@ -222,7 +222,7 @@ def _compare_eq_any(left: Any, right: Any, verbose: int = 0) -> List[str]: other_side = right if isinstance(left, ApproxBase) else left explanation = approx_side._repr_compare(other_side) - elif type(left) == type(right) and ( + elif isinstance(left, type(right)) and ( isdatacls(left) or isattrs(left) or isnamedtuple(left) ): # Note: unlike dataclasses/attrs, namedtuples compare only the diff --git a/testing/_py/test_local.py b/testing/_py/test_local.py index 895066a9f..565c89bf2 100644 --- a/testing/_py/test_local.py +++ b/testing/_py/test_local.py @@ -1573,4 +1573,4 @@ class TestBinaryAndTextMethods: x.write_text(part, "ascii") s = x.read_text("ascii") assert s == part - assert type(s) == type(part) + assert isinstance(s, type(part))