close_issue_1
/
tools
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

internal/lsp: reply with nil, rather than empty, signature help 

Change-Id: I9326ad59fb3ee33aba2ba9d05758dae5c3451bde
Reviewed-on: https://go-review.googlesource.com/c/tools/+/181358
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ian Cottrell <iancottrell@google.com>
This commit is contained in:
Rebecca Stambler 2019-06-07 22:07:33 -04:00
parent 755ce86c76
commit eacb66d2a7
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
internal/lsp/signature_help.go
View File

@ -30,14 +30,12 @@ func (s *Server) signatureHelp(ctx context.Context, params *protocol.TextDocumen
info, err := source.SignatureHelp(ctx, f, rng.Start) info, err := source.SignatureHelp(ctx, f, rng.Start)
if err != nil { if err != nil {
s.session.Logger().Infof(ctx, "no signature help for %s:%v:%v : %s", uri, int(params.Position.Line), int(params.Position.Character), err) s.session.Logger().Infof(ctx, "no signature help for %s:%v:%v : %s", uri, int(params.Position.Line), int(params.Position.Character), err)
return nil, nil
} }
return toProtocolSignatureHelp(info), nil return toProtocolSignatureHelp(info), nil
} }
func toProtocolSignatureHelp(info *source.SignatureInformation) *protocol.SignatureHelp { func toProtocolSignatureHelp(info *source.SignatureInformation) *protocol.SignatureHelp {
if info == nil {
return &protocol.SignatureHelp{}
}
return &protocol.SignatureHelp{ return &protocol.SignatureHelp{
ActiveParameter: float64(info.ActiveParameter), ActiveParameter: float64(info.ActiveParameter),
ActiveSignature: 0, // there is only ever one possible signature ActiveSignature: 0, // there is only ever one possible signature