From eacb66d2a7c3d6b93b39f7224e6bef6a44cbe70e Mon Sep 17 00:00:00 2001 From: Rebecca Stambler Date: Fri, 7 Jun 2019 22:07:33 -0400 Subject: [PATCH] internal/lsp: reply with nil, rather than empty, signature help Change-Id: I9326ad59fb3ee33aba2ba9d05758dae5c3451bde Reviewed-on: https://go-review.googlesource.com/c/tools/+/181358 Run-TryBot: Rebecca Stambler TryBot-Result: Gobot Gobot Reviewed-by: Ian Cottrell --- internal/lsp/signature_help.go | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/internal/lsp/signature_help.go b/internal/lsp/signature_help.go index 7a31d819..85d7eea3 100644 --- a/internal/lsp/signature_help.go +++ b/internal/lsp/signature_help.go @@ -30,14 +30,12 @@ func (s *Server) signatureHelp(ctx context.Context, params *protocol.TextDocumen info, err := source.SignatureHelp(ctx, f, rng.Start) if err != nil { s.session.Logger().Infof(ctx, "no signature help for %s:%v:%v : %s", uri, int(params.Position.Line), int(params.Position.Character), err) + return nil, nil } return toProtocolSignatureHelp(info), nil } func toProtocolSignatureHelp(info *source.SignatureInformation) *protocol.SignatureHelp { - if info == nil { - return &protocol.SignatureHelp{} - } return &protocol.SignatureHelp{ ActiveParameter: float64(info.ActiveParameter), ActiveSignature: 0, // there is only ever one possible signature