close_issue_1
/
tools
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

dashboard: extend builder logging 

Current response logging logs either nil or pointer value
(e.g. "dash -> {0xc20802e058}"). Not very useful.
Log actual response data.

LGTM=bradfitz
R=adg, bradfitz
CC=golang-codereviews
https://golang.org/cl/163860043
This commit is contained in:
Dmitriy Vyukov 2014-10-24 21:04:13 +04:00
parent bdfcf50b6f
commit e419b2a606
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
dashboard/builder/http.go
View File

@ -112,6 +112,9 @@ func (b *Builder) todo(kinds []string, pkg, goHash string) (kind, rev string, be
if resp == nil { if resp == nil {
return return
} }
if *verbose {
fmt.Printf("dash resp: %+v\n", *resp)
}
for _, k := range kinds { for _, k := range kinds {
if k == resp.Kind { if k == resp.Kind {
return resp.Kind, resp.Data.Hash, resp.Data.PerfResults, nil return resp.Kind, resp.Data.Hash, resp.Data.PerfResults, nil
@ -205,6 +208,9 @@ func dashboardPackages(kind string) []string {
log.Println("dashboardPackages:", err) log.Println("dashboardPackages:", err)
return nil return nil
} }
if *verbose {
fmt.Printf("dash resp: %+v\n", resp)
}
var pkgs []string var pkgs []string
for _, r := range resp { for _, r := range resp {
pkgs = append(pkgs, r.Path) pkgs = append(pkgs, r.Path)