From e419b2a606c21636faf25d2543295532ae5eca70 Mon Sep 17 00:00:00 2001 From: Dmitriy Vyukov Date: Fri, 24 Oct 2014 21:04:13 +0400 Subject: [PATCH] dashboard: extend builder logging Current response logging logs either nil or pointer value (e.g. "dash -> {0xc20802e058}"). Not very useful. Log actual response data. LGTM=bradfitz R=adg, bradfitz CC=golang-codereviews https://golang.org/cl/163860043 --- dashboard/builder/http.go | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/dashboard/builder/http.go b/dashboard/builder/http.go index d9f95976..3fbad3a8 100644 --- a/dashboard/builder/http.go +++ b/dashboard/builder/http.go @@ -112,6 +112,9 @@ func (b *Builder) todo(kinds []string, pkg, goHash string) (kind, rev string, be if resp == nil { return } + if *verbose { + fmt.Printf("dash resp: %+v\n", *resp) + } for _, k := range kinds { if k == resp.Kind { return resp.Kind, resp.Data.Hash, resp.Data.PerfResults, nil @@ -205,6 +208,9 @@ func dashboardPackages(kind string) []string { log.Println("dashboardPackages:", err) return nil } + if *verbose { + fmt.Printf("dash resp: %+v\n", resp) + } var pkgs []string for _, r := range resp { pkgs = append(pkgs, r.Path)