close_issue_1
/
tools
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

godoc/analysis: remove obsolete comment. 

The bug it refers to is now fixed, and the alternative
implementation it suggests is not an improvement.

LGTM=gri
R=gri
CC=golang-codereviews
https://golang.org/cl/151620044
This commit is contained in:
Alan Donovan 2014-10-23 13:42:24 -04:00
parent ea1477608d
commit e2e1830b02
1 changed files with 0 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
godoc/analysis/typeinfo.go
View File

@ -230,9 +230,5 @@ func deref(typ types.Type) types.Type {
// isPackageLevel reports whether obj is a package-level object. // isPackageLevel reports whether obj is a package-level object.
func isPackageLevel(obj types.Object) bool { func isPackageLevel(obj types.Object) bool {
// TODO(adonovan): fix go/types bug:
// obj.Parent().Parent() == obj.Pkg().Scope()
// doesn't work because obj.Parent() gets mutated during
// dot-imports.
return obj.Pkg().Scope().Lookup(obj.Name()) == obj return obj.Pkg().Scope().Lookup(obj.Name()) == obj
} }