From e2e1830b02bc5325f8f35f114cdcf50ee3769637 Mon Sep 17 00:00:00 2001 From: Alan Donovan Date: Thu, 23 Oct 2014 13:42:24 -0400 Subject: [PATCH] godoc/analysis: remove obsolete comment. The bug it refers to is now fixed, and the alternative implementation it suggests is not an improvement. LGTM=gri R=gri CC=golang-codereviews https://golang.org/cl/151620044 --- godoc/analysis/typeinfo.go | 4 ---- 1 file changed, 4 deletions(-) diff --git a/godoc/analysis/typeinfo.go b/godoc/analysis/typeinfo.go index 3dbb2f5d..d679a9f2 100644 --- a/godoc/analysis/typeinfo.go +++ b/godoc/analysis/typeinfo.go @@ -230,9 +230,5 @@ func deref(typ types.Type) types.Type { // isPackageLevel reports whether obj is a package-level object. func isPackageLevel(obj types.Object) bool { - // TODO(adonovan): fix go/types bug: - // obj.Parent().Parent() == obj.Pkg().Scope() - // doesn't work because obj.Parent() gets mutated during - // dot-imports. return obj.Pkg().Scope().Lookup(obj.Name()) == obj }