close_issue_1
/
tools
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

oracle: add TODO 

Change-Id: I315af962e43a3ae9c8e5cad13766d2200484fdf9
Reviewed-on: https://go-review.googlesource.com/8386
Reviewed-by: David Crawshaw <crawshaw@golang.org>
This commit is contained in:
Alan Donovan 2015-04-02 10:01:50 -04:00
parent d4e7010150
commit a18bb1d557
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
oracle/callers.go
View File

@ -59,6 +59,10 @@ func callers(q *Query) error {
return fmt.Errorf("no SSA function built for this location (dead code?)") return fmt.Errorf("no SSA function built for this location (dead code?)")
} }
// TODO(adonovan): opt: if function is never address-taken, skip
// the pointer analysis. Just look for direct calls. This can
// be done in a single pass over the SSA.
// Run the pointer analysis, recording each // Run the pointer analysis, recording each
// call found to originate from target. // call found to originate from target.
ptaConfig.BuildCallGraph = true ptaConfig.BuildCallGraph = true