From a18bb1d557dac8d19062dd0240b44ab09cfa14fd Mon Sep 17 00:00:00 2001 From: Alan Donovan Date: Thu, 2 Apr 2015 10:01:50 -0400 Subject: [PATCH] oracle: add TODO Change-Id: I315af962e43a3ae9c8e5cad13766d2200484fdf9 Reviewed-on: https://go-review.googlesource.com/8386 Reviewed-by: David Crawshaw --- oracle/callers.go | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/oracle/callers.go b/oracle/callers.go index 9633a0c7..dcf34c39 100644 --- a/oracle/callers.go +++ b/oracle/callers.go @@ -59,6 +59,10 @@ func callers(q *Query) error { return fmt.Errorf("no SSA function built for this location (dead code?)") } + // TODO(adonovan): opt: if function is never address-taken, skip + // the pointer analysis. Just look for direct calls. This can + // be done in a single pass over the SSA. + // Run the pointer analysis, recording each // call found to originate from target. ptaConfig.BuildCallGraph = true