close_issue_1
/
tools
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[release-branch.go1.11] go/ssa/interp: skip failing test 

This test introduces noise when using 'go test all' or 'go test ./...'
to test go/packages and the tools that depend on it.

Since it has been broken for around a month, skip it indefinitely.

Updates golang/go#27292

Change-Id: Ia22f371bbf8f94bbb604327b3028d1259b65a91f
Reviewed-on: https://go-review.googlesource.com/137315
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Reviewed-on: https://go-review.googlesource.com/c/153861
Run-TryBot: Andrew Bonventre <andybons@golang.org>
This commit is contained in:
Bryan C. Mills 2018-09-25 10:54:35 -04:00 committed by Andrew Bonventre
parent dab65e92bb
commit 64f9b8ad70
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
go/ssa/interp/interp_test.go
View File

@ -103,8 +103,8 @@ var gorootTestTests = []string{
"floatcmp.go", "floatcmp.go",
"crlf.go", // doesn't actually assert anything (runoutput) "crlf.go", // doesn't actually assert anything (runoutput)
// Slow tests follow. // Slow tests follow.
"bom.go", // ~1.7s "bom.go", // ~1.7s
"gc1.go", // ~1.7s "gc1.go", // ~1.7s
"cmplxdivide.go cmplxdivide1.go", // ~2.4s "cmplxdivide.go cmplxdivide1.go", // ~2.4s
// Working, but not worth enabling: // Working, but not worth enabling:
@ -156,6 +156,7 @@ var testdataTests = []string{
type successPredicate func(exitcode int, output string) error type successPredicate func(exitcode int, output string) error
func run(t *testing.T, dir, input string, success successPredicate) bool { func run(t *testing.T, dir, input string, success successPredicate) bool {
t.Skip("golang.org/issue/27292")
if runtime.GOOS == "darwin" { if runtime.GOOS == "darwin" {
t.Skip("skipping on darwin until golang.org/issue/23166 is fixed") t.Skip("skipping on darwin until golang.org/issue/23166 is fixed")
} }