From 64f9b8ad709c2be5d556530bdcb75554fd1ba18a Mon Sep 17 00:00:00 2001 From: "Bryan C. Mills" Date: Tue, 25 Sep 2018 10:54:35 -0400 Subject: [PATCH] [release-branch.go1.11] go/ssa/interp: skip failing test This test introduces noise when using 'go test all' or 'go test ./...' to test go/packages and the tools that depend on it. Since it has been broken for around a month, skip it indefinitely. Updates golang/go#27292 Change-Id: Ia22f371bbf8f94bbb604327b3028d1259b65a91f Reviewed-on: https://go-review.googlesource.com/137315 Run-TryBot: Bryan C. Mills TryBot-Result: Gobot Gobot Reviewed-by: Brad Fitzpatrick Reviewed-on: https://go-review.googlesource.com/c/153861 Run-TryBot: Andrew Bonventre --- go/ssa/interp/interp_test.go | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/go/ssa/interp/interp_test.go b/go/ssa/interp/interp_test.go index 997922f6..6885ec7a 100644 --- a/go/ssa/interp/interp_test.go +++ b/go/ssa/interp/interp_test.go @@ -103,8 +103,8 @@ var gorootTestTests = []string{ "floatcmp.go", "crlf.go", // doesn't actually assert anything (runoutput) // Slow tests follow. - "bom.go", // ~1.7s - "gc1.go", // ~1.7s + "bom.go", // ~1.7s + "gc1.go", // ~1.7s "cmplxdivide.go cmplxdivide1.go", // ~2.4s // Working, but not worth enabling: @@ -156,6 +156,7 @@ var testdataTests = []string{ type successPredicate func(exitcode int, output string) error func run(t *testing.T, dir, input string, success successPredicate) bool { + t.Skip("golang.org/issue/27292") if runtime.GOOS == "darwin" { t.Skip("skipping on darwin until golang.org/issue/23166 is fixed") }