close_issue_1
/
tools
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

x/tools/dashboard/app: prevent builders from nuking other results 

This fixes the issue where a builder would occasionally wipe out
the results from another builder.

LGTM=bradfitz
R=bradfitz
CC=golang-codereviews
https://golang.org/cl/172150043
This commit is contained in:
Andrew Gerrand 2014-11-10 13:18:31 +11:00
parent 3ee677ac1c
commit 42bbc3ebf0
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
dashboard/app/build/build.go
View File

@ -154,7 +154,7 @@ func (com *Commit) AddResult(c appengine.Context, r *Result) error {
var resultExists bool var resultExists bool
for i, s := range com.ResultData { for i, s := range com.ResultData {
// if there already exists result data for this builder at com, overwrite it. // if there already exists result data for this builder at com, overwrite it.
if strings.Contains(s, r.Builder) { if strings.HasPrefix(s, r.Builder+"|") {
resultExists = true resultExists = true
com.ResultData[i] = r.Data() com.ResultData[i] = r.Data()
} }