From 42bbc3ebf003319b5a6a0149b7631981546528e2 Mon Sep 17 00:00:00 2001 From: Andrew Gerrand Date: Mon, 10 Nov 2014 13:18:31 +1100 Subject: [PATCH] x/tools/dashboard/app: prevent builders from nuking other results This fixes the issue where a builder would occasionally wipe out the results from another builder. LGTM=bradfitz R=bradfitz CC=golang-codereviews https://golang.org/cl/172150043 --- dashboard/app/build/build.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dashboard/app/build/build.go b/dashboard/app/build/build.go index bee00ada..1a5bb495 100644 --- a/dashboard/app/build/build.go +++ b/dashboard/app/build/build.go @@ -154,7 +154,7 @@ func (com *Commit) AddResult(c appengine.Context, r *Result) error { var resultExists bool for i, s := range com.ResultData { // if there already exists result data for this builder at com, overwrite it. - if strings.Contains(s, r.Builder) { + if strings.HasPrefix(s, r.Builder+"|") { resultExists = true com.ResultData[i] = r.Data() }