close_issue_1
/
tools
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

internal/lsp: handle error from runAnalyses 

Change-Id: I73062bd3b4db8f238f009b8c8f3786c39c5d0d54
Reviewed-on: https://go-review.googlesource.com/c/tools/+/173957
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
Reviewed-by: Ian Cottrell <iancottrell@google.com>
This commit is contained in:
Rebecca Stambler 2019-04-25 15:50:50 -04:00
parent 2d660fb8a0
commit 079ac3a490
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
internal/lsp/source/diagnostics.go
View File

@ -105,7 +105,7 @@ func Diagnostics(ctx context.Context, v View, uri span.URI) (map[span.URI][]Diag
v.Logger().Debugf(ctx, "running `go vet` analyses for %s", uri) v.Logger().Debugf(ctx, "running `go vet` analyses for %s", uri)
// Type checking and parsing succeeded. Run analyses. // Type checking and parsing succeeded. Run analyses.
runAnalyses(ctx, v, pkg, func(a *analysis.Analyzer, diag analysis.Diagnostic) error { if err := runAnalyses(ctx, v, pkg, func(a *analysis.Analyzer, diag analysis.Diagnostic) error {
r := span.NewRange(v.FileSet(), diag.Pos, 0) r := span.NewRange(v.FileSet(), diag.Pos, 0)
s, err := r.Span() s, err := r.Span()
if err != nil { if err != nil {
@ -123,7 +123,9 @@ func Diagnostics(ctx context.Context, v View, uri span.URI) (map[span.URI][]Diag
Severity: SeverityWarning, Severity: SeverityWarning,
}) })
return nil return nil
}) }); err != nil {
return nil, err
}
v.Logger().Debugf(ctx, "completed reporting `go vet` analyses for %s", uri) v.Logger().Debugf(ctx, "completed reporting `go vet` analyses for %s", uri)