From 079ac3a490a18433496e4e5bf58fd5e27c6b3d05 Mon Sep 17 00:00:00 2001 From: Rebecca Stambler Date: Thu, 25 Apr 2019 15:50:50 -0400 Subject: [PATCH] internal/lsp: handle error from runAnalyses Change-Id: I73062bd3b4db8f238f009b8c8f3786c39c5d0d54 Reviewed-on: https://go-review.googlesource.com/c/tools/+/173957 Run-TryBot: Rebecca Stambler Reviewed-by: Ian Cottrell --- internal/lsp/source/diagnostics.go | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/internal/lsp/source/diagnostics.go b/internal/lsp/source/diagnostics.go index 67e28c10..42a4f9b9 100644 --- a/internal/lsp/source/diagnostics.go +++ b/internal/lsp/source/diagnostics.go @@ -105,7 +105,7 @@ func Diagnostics(ctx context.Context, v View, uri span.URI) (map[span.URI][]Diag v.Logger().Debugf(ctx, "running `go vet` analyses for %s", uri) // Type checking and parsing succeeded. Run analyses. - runAnalyses(ctx, v, pkg, func(a *analysis.Analyzer, diag analysis.Diagnostic) error { + if err := runAnalyses(ctx, v, pkg, func(a *analysis.Analyzer, diag analysis.Diagnostic) error { r := span.NewRange(v.FileSet(), diag.Pos, 0) s, err := r.Span() if err != nil { @@ -123,7 +123,9 @@ func Diagnostics(ctx context.Context, v View, uri span.URI) (map[span.URI][]Diag Severity: SeverityWarning, }) return nil - }) + }); err != nil { + return nil, err + } v.Logger().Debugf(ctx, "completed reporting `go vet` analyses for %s", uri)