yystopf
/
openharmony_kernel_liteos_a
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

!614 修复子进程setgroups时会额外加上父进程gid，导致getgroups的list比设置的list多一个gid的问题 

Merge pull request !614 from 刘占伟/OpenHarmony_1.0.1_release
This commit is contained in:
openharmony_ci 2021-09-09 06:39:12 +00:00 committed by Gitee
parent a8513ae614 58aea01f5a
commit a0bb06189d
1 changed files with 8 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
syscall/process_syscall.c Executable file → Normal file
View File

@ -683,12 +683,12 @@ int SysGetGroupID(void)
}
#ifdef LOSCFG_SECURITY_CAPABILITY
static int SetGroups(int listSize, const int *safeList, int size)
static int SetGroups(int size, const int *safeList)
{
User *oldUser = NULL;
unsigned int intSave;
User *newUser = LOS_MemAlloc(m_aucSysMem1, sizeof(User) + listSize * sizeof(int));
User *newUser = LOS_MemAlloc(m_aucSysMem1, sizeof(User) + size * sizeof(int));
if (newUser == NULL) {
return -ENOMEM;
}
@ -696,14 +696,11 @@ static int SetGroups(int listSize, const int *safeList, int size)
SCHEDULER_LOCK(intSave);
oldUser = OsCurrUserGet();
(VOID)memcpy_s(newUser, sizeof(User), oldUser, sizeof(User));
if (safeList != NULL) {
if (size != 0) {
(VOID)memcpy_s(newUser->groups, size * sizeof(int), safeList, size * sizeof(int));
}
if (listSize == size) {
newUser->groups[listSize] = oldUser->gid;
}
newUser->groupNumber = listSize + 1;
newUser->groupNumber = size;
OsCurrProcessGet()->user = newUser;
SCHEDULER_UNLOCK(intSave);
@ -724,7 +721,7 @@ static int GetGroups(int size, int list[])
SCHEDULER_UNLOCK(intSave);
listSize = groupCount * sizeof(int);
if (size == 0) {
if ((size == 0) || (groupCount == 0)) {
return groupCount;
} else if (list == NULL) {
return -EFAULT;
@ -782,7 +779,6 @@ int SysSetGroups(int size, const int list[])
#ifdef LOSCFG_SECURITY_CAPABILITY
int ret;
int gid;
int listSize = size;
unsigned int count;
int *safeList = NULL;
#endif
@ -813,16 +809,14 @@ int SysSetGroups(int size, const int list[])
}
gid = OsCurrUserGet()->gid;
for (count = 0; count < size; count++) {
if (safeList[count] == gid) {
listSize = size - 1;
} else if (safeList[count] < 0) {
if (safeList[count] < 0) {
ret = -EINVAL;
goto EXIT;
}
}
}
ret = SetGroups(listSize, safeList, size);
ret = SetGroups(size, safeList);
EXIT:
if (safeList != NULL) {
(void)LOS_MemFree(m_aucSysMem1, safeList);