xxq250
/
homework-jianmu
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

fix(stream): do not wait for the checkpoint finish before stop tasks.

This commit is contained in:
Haojun Liao 2023-09-24 22:03:07 +08:00
parent 7167c3c5de
commit fc96ec6bae
1 changed files with 5 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
source/libs/stream/src/streamTask.c
View File

@ -558,21 +558,12 @@ int32_t streamTaskStop(SStreamTask* pTask) {
int64_t st = taosGetTimestampMs();
const char* id = pTask->id.idStr;
// we should wait for the task complete the checkpoint operation before stop it, otherwise, the operation maybe blocked
// by the unfinished checkpoint operation, even if the leader has become the follower.
while(1) {
taosThreadMutexLock(&pTask->lock);
if (pTask->status.taskStatus == TASK_STATUS__CK) {
stDebug("s-task:%s in checkpoint, wait for it completed for 500ms before stop task", pTask->id.idStr);
taosThreadMutexUnlock(&pTask->lock);
taosMsleep(500);
} else {
pTask->status.taskStatus = TASK_STATUS__STOP;
taosThreadMutexUnlock(&pTask->lock);
break;
}
taosThreadMutexLock(&pTask->lock);
if (pTask->status.taskStatus == TASK_STATUS__CK) {
stDebug("s-task:%s in checkpoint will be discarded since task is stopped", pTask->id.idStr);
}
pTask->status.taskStatus = TASK_STATUS__STOP;
taosThreadMutexUnlock(&pTask->lock);
qKillTask(pTask->exec.pExecutor, TSDB_CODE_SUCCESS);