From fc7ca05ae04400f53485397a129f49456320c5e4 Mon Sep 17 00:00:00 2001 From: Shungang Li Date: Thu, 10 Oct 2024 15:17:01 +0800 Subject: [PATCH] fix: mndProcessArbHbTimer memleak issue --- source/dnode/mnode/impl/src/mndArbGroup.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/source/dnode/mnode/impl/src/mndArbGroup.c b/source/dnode/mnode/impl/src/mndArbGroup.c index 61dd13eb45..97bf661bc3 100644 --- a/source/dnode/mnode/impl/src/mndArbGroup.c +++ b/source/dnode/mnode/impl/src/mndArbGroup.c @@ -445,7 +445,7 @@ static int32_t mndProcessArbHbTimer(SRpcMsg *pReq) { SDnodeObj *pDnode = mndAcquireDnode(pMnode, dnodeId); if (pDnode == NULL) { - mError("dnodeId:%d, timer failed to send arb-hb request, failed find dnode", dnodeId); + mError("dnodeId:%d, timer failed to acquire dnode", dnodeId); taosArrayDestroy(hbMembers); continue; } @@ -453,7 +453,10 @@ static int32_t mndProcessArbHbTimer(SRpcMsg *pReq) { int64_t mndTerm = mndGetTerm(pMnode); if (mndIsDnodeOnline(pDnode, nowMs)) { - TAOS_CHECK_RETURN(mndSendArbHeartBeatReq(pDnode, arbToken, mndTerm, hbMembers)); + int32_t sendCode = mndSendArbHeartBeatReq(pDnode, arbToken, mndTerm, hbMembers); + if (TSDB_CODE_SUCCESS != sendCode) { + mError("dnodeId:%d, timer failed to send arb-hb request", dnodeId); + } } mndReleaseDnode(pMnode, pDnode);