From fbb1fa53030c536c7a61228f8d4b4ec2bd65f7ac Mon Sep 17 00:00:00 2001
From: Shengliang Guan <slguan@taosdata.com>
Date: Tue, 1 Nov 2022 09:02:48 +0800
Subject: [PATCH] enh: refact syncEnv code

---
 source/libs/sync/inc/syncEnv.h  | 2 +-
 source/libs/sync/src/syncEnv.c  | 5 +----
 source/libs/sync/src/syncMain.c | 2 +-
 3 files changed, 3 insertions(+), 6 deletions(-)

diff --git a/source/libs/sync/inc/syncEnv.h b/source/libs/sync/inc/syncEnv.h
index 068ccaf029..55ce1470ce 100644
--- a/source/libs/sync/inc/syncEnv.h
+++ b/source/libs/sync/inc/syncEnv.h
@@ -54,7 +54,7 @@ typedef struct SSyncEnv {
 SSyncEnv* syncEnv();
 
 int64_t    syncNodeAdd(SSyncNode* pNode);
-void       syncNodeRemove(SSyncNode* pNode);
+void       syncNodeRemove(int64_t rid);
 SSyncNode* syncNodeAcquire(int64_t rid);
 void       syncNodeRelease(SSyncNode* pNode);
 
diff --git a/source/libs/sync/src/syncEnv.c b/source/libs/sync/src/syncEnv.c
index 5b8acfa5ef..c55cd4fdac 100644
--- a/source/libs/sync/src/syncEnv.c
+++ b/source/libs/sync/src/syncEnv.c
@@ -74,10 +74,7 @@ int64_t syncNodeAdd(SSyncNode *pNode) {
   return pNode->rid;
 }
 
-void syncNodeRemove(SSyncNode *pNode) {
-  taosRemoveRef(gNodeRefId, pNode->rid);
-  sDebug("vgId:%d, sync rid:%" PRId64 " is removed from rsetId:%d", pNode->vgId, pNode->rid, gNodeRefId);
-}
+void syncNodeRemove(int64_t rid) { taosRemoveRef(gNodeRefId, rid); }
 
 SSyncNode *syncNodeAcquire(int64_t rid) {
   SSyncNode *pNode = taosAcquireRef(gNodeRefId, rid);
diff --git a/source/libs/sync/src/syncMain.c b/source/libs/sync/src/syncMain.c
index 42018ed750..89499a7c7d 100644
--- a/source/libs/sync/src/syncMain.c
+++ b/source/libs/sync/src/syncMain.c
@@ -76,7 +76,7 @@ void syncStop(int64_t rid) {
   SSyncNode* pNode = syncNodeAcquire(rid);
   if (pNode != NULL) {
     syncNodeRelease(pNode);
-    syncNodeRemove(pNode);
+    syncNodeRemove(rid);
   }
 }