From fa9f27344950405d905ffa501e81471cd448820b Mon Sep 17 00:00:00 2001
From: lyh250-666 <lyh666@bupt.edu.cn>
Date: Fri, 25 Oct 2024 14:39:03 +0800
Subject: [PATCH] opti:add case for double and float

---
 source/libs/scalar/src/filter.c |  9 +++++++--
 tests/script/tsim/scalar/in.sim | 34 +++++++++++++++++++++++++++++++++
 2 files changed, 41 insertions(+), 2 deletions(-)

diff --git a/source/libs/scalar/src/filter.c b/source/libs/scalar/src/filter.c
index c9740b8c25..2c449fced6 100644
--- a/source/libs/scalar/src/filter.c
+++ b/source/libs/scalar/src/filter.c
@@ -5034,8 +5034,13 @@ int32_t fltSclBuildRangePoints(SFltSclOperator *oper, SArray *points) {
           SValueNode *valueNode = (SValueNode *)cell->pNode;
           SFltSclDatum valDatum;
           FLT_ERR_RET(fltSclBuildDatumFromValueNode(&valDatum, valueNode));
-          minDatum.i = TMIN(minDatum.i, valDatum.i);
-          maxDatum.i = TMAX(maxDatum.i, valDatum.i);
+          if(valueNode->node.resType.type == TSDB_DATA_TYPE_FLOAT || valueNode->node.resType.type == TSDB_DATA_TYPE_DOUBLE) {
+            minDatum.i = TMIN(minDatum.i, valDatum.d);
+            maxDatum.i = TMAX(maxDatum.i, valDatum.d);
+          } else {
+            minDatum.i = TMIN(minDatum.i, valDatum.i);
+            maxDatum.i = TMAX(maxDatum.i, valDatum.i);
+          }
           cell = cell->pNext;
         }
         SFltSclPoint startPt = {.start = true, .excl = false, .val = minDatum};
diff --git a/tests/script/tsim/scalar/in.sim b/tests/script/tsim/scalar/in.sim
index d241bbc1bf..f7fa2bcd2d 100644
--- a/tests/script/tsim/scalar/in.sim
+++ b/tests/script/tsim/scalar/in.sim
@@ -95,4 +95,38 @@ endi
 if $data20 != @      Time Range: [1657441840000, 1657441980000]@ then
   return -1
 endi
+
+sql explain verbose true select * from tb1 where fts in ('2022-07-10 16:31:00', '2022-07-10 16:33:00', 1657441840000, true);
+if $rows != 4 then
+  return -1
+endi
+if $data20 != @      Time Range: [0, 1657441980000]@ then
+  return -1
+endi
+
+sql explain verbose true select * from tb1 where fts in ('2022-07-10 16:31:00', '2022-07-10 16:33:00', 1657441840000, false);
+if $rows != 4 then
+  return -1
+endi
+if $data20 != @      Time Range: [1, 1657441980000]@ then
+  return -1
+endi
+
+sql explain verbose true select * from tb1 where fts in ('2022-07-10 16:31:00', '2022-07-10 16:33:00', 1657441840000, 1.02);
+if $rows != 4 then
+  return -1
+endi
+if $data20 != @      Time Range: [1, 1657441980000]@ then
+  return -1
+endi
+
+sql explain verbose true select * from tb1 where fts in ('2022-07-10 16:31:00', '2022-07-10 16:33:00', 1657441840000, -1.02);
+if $rows != 4 then
+  return -1
+endi
+if $data20 != @      Time Range: [-1, 1657441980000]@ then
+  return -1
+endi
+
+sql_error explain verbose true select * from tb1 where fts in ('2022-07-10 16:31:00', '2022-07-10 16:33:00', 1657441840000, 'abc');
 system sh/exec.sh -n dnode1 -s stop -x SIGINT