From f9dc305e3583771739a5370fd8c1ec3715c6f9fd Mon Sep 17 00:00:00 2001 From: kailixu Date: Sat, 8 Feb 2025 16:08:40 +0800 Subject: [PATCH] enh: print err msg only in embedded log mode --- source/util/src/tlog.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/source/util/src/tlog.c b/source/util/src/tlog.c index eb4b4de863..94b6b67018 100644 --- a/source/util/src/tlog.c +++ b/source/util/src/tlog.c @@ -398,8 +398,9 @@ static void taosKeepOldLog(char *oldName) { TAOS_UNUSED(taosUnLockFile(oldFile)); _exit2: TAOS_UNUSED(taosCloseFile(&oldFile)); - if (code != 0) { - uWarn("failed at line %d to keep old log file:%s, reason:%s\n", lino, oldName, tstrerror(code)); + if (code != 0 && tsLogEmbedded == 1) { // only print error message in embedded log mode + // don't use uWarn or uError, because it may open new log file and cause dead lock + fprintf(stderr, "failed at line %d to keep old log file:%s, reason:%s\n", lino, oldName, tstrerror(code)); } } }