xxq250
/
homework-jianmu
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

validate table name

This commit is contained in:
Hongze Cheng 2022-04-26 02:25:07 +00:00
parent 598d8deb43
commit f94dee1df9
1 changed files with 17 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
source/dnode/vnode/src/meta/metaTable.c
View File

@ -34,10 +34,16 @@ int metaCreateSTable(SMeta *pMeta, int64_t version, SVCreateStbReq *pReq) {
int32_t szBuf = 0; int32_t szBuf = 0;
void *p = NULL; void *p = NULL;
SCoder coder = {0}; SCoder coder = {0};
SMetaReader mr = {0};
{ // validate req
// TODO: validate request (uid and name unique) metaReaderInit(&mr, pMeta->pVnode, 0);
if (metaGetTableEntryByName(&mr, pReq->name) == 0) {
terrno = TSDB_CODE_TDB_TABLE_ALREADY_EXIST;
metaReaderClear(&mr);
return -1;
} }
metaReaderClear(&mr);
// set structs // set structs
me.version = version; me.version = version;
@ -66,6 +72,7 @@ int metaDropSTable(SMeta *pMeta, int64_t verison, SVDropStbReq *pReq) {
int metaCreateTable(SMeta *pMeta, int64_t version, SVCreateTbReq *pReq) { int metaCreateTable(SMeta *pMeta, int64_t version, SVCreateTbReq *pReq) {
SMetaEntry me = {0}; SMetaEntry me = {0};
SMetaReader mr = {0};
// validate message // validate message
if (pReq->type != TSDB_CHILD_TABLE && pReq->type != TSDB_NORMAL_TABLE) { if (pReq->type != TSDB_CHILD_TABLE && pReq->type != TSDB_NORMAL_TABLE) {
@ -77,10 +84,14 @@ int metaCreateTable(SMeta *pMeta, int64_t version, SVCreateTbReq *pReq) {
pReq->uid = tGenIdPI64(); pReq->uid = tGenIdPI64();
pReq->ctime = taosGetTimestampSec(); pReq->ctime = taosGetTimestampSec();
{ // validate req
// TODO: validate request (uid and name unique) metaReaderInit(&mr, pMeta->pVnode, 0);
// for child table, also check if super table exists if (metaGetTableEntryByName(&mr, pReq->name) == 0) {
terrno = TSDB_CODE_TDB_TABLE_ALREADY_EXIST;
metaReaderClear(&mr);
return -1;
} }
metaReaderClear(&mr);
// build SMetaEntry // build SMetaEntry
me.version = version; me.version = version;