xxq250
/
homework-jianmu
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Merge pull request #28135 from taosdata/fix/TD-32320 

fix mem leak
This commit is contained in:
Hongze Cheng 2024-09-27 09:07:13 +08:00 committed by GitHub
parent 3e04f78b40 4cd35d76db
commit f617d216f0
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
source/libs/stream/src/tstreamFileState.c
View File

@ -100,7 +100,7 @@ void* intervalCreateStateKey(SRowBuffPos* pPos, int64_t num) {
qError("%s failed at line %d since %s", __func__, __LINE__, tstrerror(terrno)); qError("%s failed at line %d since %s", __func__, __LINE__, tstrerror(terrno));
return NULL; return NULL;
} }
SWinKey* pWinKey = pPos->pKey; SWinKey* pWinKey = pPos->pKey;
pStateKey->key = *pWinKey; pStateKey->key = *pWinKey;
pStateKey->opNum = num; pStateKey->opNum = num;
return pStateKey; return pStateKey;
@ -120,7 +120,7 @@ void* sessionCreateStateKey(SRowBuffPos* pPos, int64_t num) {
qError("%s failed at line %d since %s", __func__, __LINE__, tstrerror(terrno)); qError("%s failed at line %d since %s", __func__, __LINE__, tstrerror(terrno));
return NULL; return NULL;
} }
SSessionKey* pWinKey = pPos->pKey; SSessionKey* pWinKey = pPos->pKey;
pStateKey->key = *pWinKey; pStateKey->key = *pWinKey;
pStateKey->opNum = num; pStateKey->opNum = num;
return pStateKey; return pStateKey;
@ -734,7 +734,7 @@ void flushSnapshot(SStreamFileState* pFileState, SStreamSnapshot* pSnapshot, boo
// todo handle failure // todo handle failure
memset(buf, 0, len); memset(buf, 0, len);
} }
taosMemoryFree(buf); taosMemoryFreeClear(buf);
int32_t numOfElems = streamStateGetBatchSize(batch); int32_t numOfElems = streamStateGetBatchSize(batch);
if (numOfElems > 0) { if (numOfElems > 0) {
@ -769,6 +769,7 @@ _end:
if (code != TSDB_CODE_SUCCESS) { if (code != TSDB_CODE_SUCCESS) {
qError("%s failed at line %d since %s", __func__, lino, tstrerror(code)); qError("%s failed at line %d since %s", __func__, lino, tstrerror(code));
} }
taosMemoryFree(buf);
streamStateDestroyBatch(batch); streamStateDestroyBatch(batch);
} }
@ -850,7 +851,7 @@ int32_t recoverSesssion(SStreamFileState* pFileState, int64_t ckId) {
if (winRes != TSDB_CODE_SUCCESS) { if (winRes != TSDB_CODE_SUCCESS) {
break; break;
} }
if (vlen != pFileState->rowSize) { if (vlen != pFileState->rowSize) {
code = TSDB_CODE_QRY_EXECUTOR_INTERNAL_ERROR; code = TSDB_CODE_QRY_EXECUTOR_INTERNAL_ERROR;
QUERY_CHECK_CODE(code, lino, _end); QUERY_CHECK_CODE(code, lino, _end);