xxq250
/
homework-jianmu
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

fix(tsdb/close): fix uaf with file closing

This commit is contained in:
Minglei Jin 2023-08-25 16:22:45 +08:00
parent ebf00c4153
commit f0fdbaa3f3
1 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
source/dnode/vnode/src/tsdb/tsdbReaderWriter.c
View File

@ -35,12 +35,12 @@ static int32_t tsdbOpenFileImpl(STsdbFD *pFD) {
if (pFD->pFD == NULL) { if (pFD->pFD == NULL) {
code = TAOS_SYSTEM_ERROR(ENOENT); code = TAOS_SYSTEM_ERROR(ENOENT);
taosMemoryFree(pFD); // taosMemoryFree(pFD);
goto _exit; goto _exit;
} }
} else { } else {
code = TAOS_SYSTEM_ERROR(errsv); code = TAOS_SYSTEM_ERROR(errsv);
taosMemoryFree(pFD); // taosMemoryFree(pFD);
goto _exit; goto _exit;
} }
} }
@ -48,8 +48,8 @@ static int32_t tsdbOpenFileImpl(STsdbFD *pFD) {
pFD->pBuf = taosMemoryCalloc(1, szPage); pFD->pBuf = taosMemoryCalloc(1, szPage);
if (pFD->pBuf == NULL) { if (pFD->pBuf == NULL) {
code = TSDB_CODE_OUT_OF_MEMORY; code = TSDB_CODE_OUT_OF_MEMORY;
taosCloseFile(&pFD->pFD); // taosCloseFile(&pFD->pFD);
taosMemoryFree(pFD); // taosMemoryFree(pFD);
goto _exit; goto _exit;
} }
@ -57,9 +57,9 @@ static int32_t tsdbOpenFileImpl(STsdbFD *pFD) {
if (flag != TD_FILE_READ) { if (flag != TD_FILE_READ) {
if (taosStatFile(path, &pFD->szFile, NULL, NULL) < 0) { if (taosStatFile(path, &pFD->szFile, NULL, NULL) < 0) {
code = TAOS_SYSTEM_ERROR(errno); code = TAOS_SYSTEM_ERROR(errno);
taosMemoryFree(pFD->pBuf); // taosMemoryFree(pFD->pBuf);
taosCloseFile(&pFD->pFD); // taosCloseFile(&pFD->pFD);
taosMemoryFree(pFD); // taosMemoryFree(pFD);
goto _exit; goto _exit;
} }