xxq250
/
homework-jianmu
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

fix mem leak

This commit is contained in:
yihaoDeng 2023-10-30 17:29:32 +08:00
parent 7e1e68d8f5
commit ee6b620597
2 changed files with 17 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
source/libs/stream/src/streamBackendRocksdb.c
View File

@ -1819,6 +1819,9 @@ _EXIT:
void taskDbDestroy(void* pBackend) {
STaskDbWrapper* wrapper = pBackend;
qDebug("succ to destroy stream backend:%p", wrapper);
int8_t nCf = sizeof(ginitDict) / sizeof(ginitDict[0]);
if (wrapper == NULL) return;
@ -1826,7 +1829,6 @@ void taskDbDestroy(void* pBackend) {
rocksdb_flushoptions_t* flushOpt = rocksdb_flushoptions_create();
rocksdb_flushoptions_set_wait(flushOpt, 1);
int8_t nCf = sizeof(ginitDict) / sizeof(ginitDict[0]);
char* err = NULL;
for (int i = 0; i < nCf; i++) {
if (wrapper->pCf[i] != NULL) rocksdb_flush_cf(wrapper->db, flushOpt, wrapper->pCf[i], &err);
@ -1849,7 +1851,19 @@ void taskDbDestroy(void* pBackend) {
rocksdb_env_destroy(wrapper->env);
rocksdb_cache_destroy(wrapper->cache);
taosMemoryFree(wrapper->pCf);
for (int i = 0; i < nCf; i++) {
rocksdb_options_t *opt = wrapper->pCfOpts[i];
rocksdb_comparator_t *compare = wrapper->pCompares[i];
rocksdb_block_based_table_options_t *tblOpt = wrapper->pCfParams[i].tableOpt;
rocksdb_options_destroy(opt);
rocksdb_comparator_destroy(compare);
rocksdb_block_based_options_destroy(tblOpt);
}
taosMemoryFree(wrapper->pCompares);
taosMemoryFree(wrapper->pCfOpts);
taosMemoryFree(wrapper->pCfParams);

2
source/libs/stream/src/streamTask.c
View File

@ -368,6 +368,8 @@ void tFreeStreamTask(SStreamTask* pTask) {
if (pTask->pState) {
stDebug("s-task:0x%x start to free task state", taskId);
streamStateClose(pTask->pState, status == TASK_STATUS__DROPPING);
taskDbRemoveRef(pTask->pBackend);
}
if (pTask->id.idStr != NULL) {