From e9586c693e3562500026915aaf175bb4ce822909 Mon Sep 17 00:00:00 2001
From: Shengliang Guan <slguan@taosdata.com>
Date: Fri, 13 May 2022 12:35:08 +0800
Subject: [PATCH] fix: check server status

---
 source/dnode/mgmt/mgmt_dnode/CMakeLists.txt |  2 +-
 source/dnode/mgmt/node_mgmt/inc/dmMgmt.h    |  1 +
 source/dnode/mgmt/node_mgmt/src/dmMgmt.c    | 48 +++++++++++++--------
 3 files changed, 33 insertions(+), 18 deletions(-)

diff --git a/source/dnode/mgmt/mgmt_dnode/CMakeLists.txt b/source/dnode/mgmt/mgmt_dnode/CMakeLists.txt
index e273095166..a4268fc9f0 100644
--- a/source/dnode/mgmt/mgmt_dnode/CMakeLists.txt
+++ b/source/dnode/mgmt/mgmt_dnode/CMakeLists.txt
@@ -2,7 +2,7 @@ aux_source_directory(src MGMT_DNODE)
 add_library(mgmt_dnode STATIC ${MGMT_DNODE})
 target_include_directories(
     mgmt_dnode
-    PRIVATE "${CMAKE_CURRENT_SOURCE_DIR}/inc"
+    PUBLIC "${CMAKE_CURRENT_SOURCE_DIR}/inc"
 )
 target_link_libraries(
     mgmt_dnode node_util
diff --git a/source/dnode/mgmt/node_mgmt/inc/dmMgmt.h b/source/dnode/mgmt/node_mgmt/inc/dmMgmt.h
index e35b308d35..ff3463a776 100644
--- a/source/dnode/mgmt/node_mgmt/inc/dmMgmt.h
+++ b/source/dnode/mgmt/node_mgmt/inc/dmMgmt.h
@@ -20,6 +20,7 @@
 #include "uv.h"
 
 #include "dmUtil.h"
+#include "dmInt.h"
 
 #ifdef __cplusplus
 extern "C" {
diff --git a/source/dnode/mgmt/node_mgmt/src/dmMgmt.c b/source/dnode/mgmt/node_mgmt/src/dmMgmt.c
index 9189fc7e4d..6d71e9a36e 100644
--- a/source/dnode/mgmt/node_mgmt/src/dmMgmt.c
+++ b/source/dnode/mgmt/node_mgmt/src/dmMgmt.c
@@ -236,29 +236,43 @@ void dmReportStartupByWrapper(SMgmtWrapper *pWrapper, const char *pName, const c
 }
 
 static void dmGetServerStatus(SDnode *pDnode, SServerStatusRsp *pStatus) {
+  SDnodeMgmt *pMgmt = pDnode->wrappers[DNODE].pMgmt;
+  pStatus->statusCode = TSDB_SRV_STATUS_SERVICE_OK;
   pStatus->details[0] = 0;
 
   if (pDnode->status == DND_STAT_INIT) {
     pStatus->statusCode = TSDB_SRV_STATUS_NETWORK_OK;
     snprintf(pStatus->details, sizeof(pStatus->details), "%s: %s", pDnode->startup.name, pDnode->startup.desc);
-  } else if (pDnode->status == DND_STAT_STOPPED) {
-    pStatus->statusCode = TSDB_SRV_STATUS_EXTING;
-  } else {
-#if 0
-    SDnodeData *pData = &pDnode->data;
-    if (pData->isMnode && pData->mndState != TAOS_SYNC_STATE_LEADER && pData->mndState == TAOS_SYNC_STATE_CANDIDATE) {
-      pStatus->statusCode = TSDB_SRV_STATUS_SERVICE_DEGRADED;
-      snprintf(pStatus->details, sizeof(pStatus->details), "mnode sync state is %s", syncStr(pData->mndState));
-    } else if (pData->unsyncedVgId != 0 && pData->vndState != TAOS_SYNC_STATE_LEADER &&
-               pData->vndState != TAOS_SYNC_STATE_CANDIDATE) {
-      pStatus->statusCode = TSDB_SRV_STATUS_SERVICE_DEGRADED;
-      snprintf(pStatus->details, sizeof(pStatus->details), "vnode:%d sync state is %s", pData->unsyncedVgId,
-               syncStr(pData->vndState));
-    } else {
-      pStatus->statusCode = TSDB_SRV_STATUS_SERVICE_OK;
-    }
-#endif
+    return;
   }
+
+  if (pDnode->status == DND_STAT_STOPPED) {
+    pStatus->statusCode = TSDB_SRV_STATUS_EXTING;
+    return;
+  }
+
+  SMonMloadInfo minfo = {0};
+  dmGetMnodeLoads(pMgmt, &minfo);
+  if (minfo.isMnode && minfo.load.syncState != TAOS_SYNC_STATE_LEADER &&
+      minfo.load.syncState != TAOS_SYNC_STATE_CANDIDATE) {
+    pStatus->statusCode = TSDB_SRV_STATUS_SERVICE_DEGRADED;
+    snprintf(pStatus->details, sizeof(pStatus->details), "mnode sync state is %s", syncStr(minfo.load.syncState));
+    return;
+  }
+
+  SMonVloadInfo vinfo = {0};
+  dmGetVnodeLoads(pMgmt, &vinfo);
+  for (int32_t i = 0; i < taosArrayGetSize(vinfo.pVloads); ++i) {
+    SVnodeLoad *pLoad = taosArrayGet(vinfo.pVloads, i);
+    if (pLoad->syncState != TAOS_SYNC_STATE_LEADER && pLoad->syncState != TAOS_SYNC_STATE_FOLLOWER) {
+      pStatus->statusCode = TSDB_SRV_STATUS_SERVICE_DEGRADED;
+      snprintf(pStatus->details, sizeof(pStatus->details), "vnode:%d sync state is %s", pLoad->vgId,
+               syncStr(pLoad->syncState));
+      break;
+    }
+  }
+
+  taosArrayDestroy(vinfo.pVloads);
 }
 
 void dmProcessNetTestReq(SDnode *pDnode, SRpcMsg *pReq) {