From e5f9d78b6d0df0c0fa9970a29ce9f1d2617ae52a Mon Sep 17 00:00:00 2001
From: slzhou <shenglian_zhou@163.com>
Date: Wed, 24 May 2023 16:39:38 +0800
Subject: [PATCH] fix: rocksdb so

---
 cmake/cmake.options                         |  5 --
 contrib/CMakeLists.txt                      | 56 ---------------------
 contrib/test/CMakeLists.txt                 |  3 --
 source/dnode/mgmt/mgmt_dnode/CMakeLists.txt |  2 +-
 source/dnode/vnode/CMakeLists.txt           |  2 -
 source/libs/stream/CMakeLists.txt           |  2 -
 6 files changed, 1 insertion(+), 69 deletions(-)

diff --git a/cmake/cmake.options b/cmake/cmake.options
index a7e62350df..064b1f7c6f 100644
--- a/cmake/cmake.options
+++ b/cmake/cmake.options
@@ -106,11 +106,6 @@ option(
     OFF
 )
 
-option(
-    BUILD_WITH_ROCKSDB 
-    "If build with rocksdb" 
-    ON
-)
 
 option(
     BUILD_WITH_SQLITE
diff --git a/contrib/CMakeLists.txt b/contrib/CMakeLists.txt
index 536d4eae8e..ad3d8bc326 100644
--- a/contrib/CMakeLists.txt
+++ b/contrib/CMakeLists.txt
@@ -77,11 +77,6 @@ if(${BUILD_WITH_LEVELDB})
     cat("${TD_SUPPORT_DIR}/leveldb_CMakeLists.txt.in" ${CONTRIB_TMP_FILE})
 endif(${BUILD_WITH_LEVELDB})
 
-# rocksdb
-if(${BUILD_WITH_ROCKSDB})
-    cat("${TD_SUPPORT_DIR}/rocksdb_CMakeLists.txt.in" ${CONTRIB_TMP_FILE})
-    add_definitions(-DUSE_ROCKSDB)
-endif(${BUILD_WITH_ROCKSDB})
 
 # canonical-raft
 if(${BUILD_WITH_CRAFT})
@@ -220,57 +215,6 @@ if(${BUILD_WITH_LEVELDB})
     )
 endif(${BUILD_WITH_LEVELDB})
 
-# rocksdb
-# To support rocksdb build on ubuntu: sudo apt-get install libgflags-dev
-if(${BUILD_WITH_ROCKSDB})
-    if(${TD_LINUX})
-        SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-error=maybe-uninitialized -Wno-error=unused-but-set-variable -Wno-error=unused-variable -Wno-error=unused-function -Wno-errno=unused-private-field -Wno-error=unused-result")
-    endif(${TD_LINUX})
-
-    if(${TD_DARWIN})
-        SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-error=maybe-uninitialized")
-    endif(${TD_DARWIN})
-
-    if (${TD_WINDOWS})
-        SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /wd4244 /wd4819")  
-    endif(${TD_WINDOWS})
-
-
-    if(${TD_DARWIN})
-        option(HAVE_THREAD_LOCAL "" OFF)
-        option(WITH_IOSTATS_CONTEXT "" OFF)
-        option(WITH_PERF_CONTEXT "" OFF)
-    endif(${TD_DARWIN})
-
-    if(${TD_WINDOWS})
-        option(WITH_JNI "" ON)
-    endif(${TD_WINDOWS})
-
-    if(${TD_WINDOWS})
-        option(WITH_MD_LIBRARY "build with MD" OFF)
-        set(SYSTEM_LIBS ${SYSTEM_LIBS} shlwapi.lib rpcrt4.lib)
-    endif(${TD_WINDOWS})
-    
-    
-    option(WITH_FALLOCATE "" OFF)
-    option(WITH_JEMALLOC "" OFF)
-    option(WITH_GFLAGS "" OFF)
-    option(PORTABLE "" ON)
-    option(WITH_LIBURING "" OFF)
-    option(FAIL_ON_WARNINGS OFF)
-
-    option(WITH_TESTS "" OFF)
-    option(WITH_BENCHMARK_TOOLS "" OFF)
-    option(WITH_TOOLS "" OFF)
-    option(WITH_LIBURING "" OFF)
-
-    option(ROCKSDB_BUILD_SHARED "Build shared versions of the RocksDB libraries" OFF)
-    add_subdirectory(rocksdb EXCLUDE_FROM_ALL)
-    target_include_directories(
-        rocksdb
-        PUBLIC $<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/rocksdb/include>
-    )
-endif(${BUILD_WITH_ROCKSDB})
 
 # lucene
 # To support build on ubuntu: sudo apt-get install libboost-all-dev
diff --git a/contrib/test/CMakeLists.txt b/contrib/test/CMakeLists.txt
index f35cf0d13d..8d095518e2 100644
--- a/contrib/test/CMakeLists.txt
+++ b/contrib/test/CMakeLists.txt
@@ -1,7 +1,4 @@
 # rocksdb
-if(${BUILD_WITH_ROCKSDB})
-    add_subdirectory(rocksdb)
-endif(${BUILD_WITH_ROCKSDB})
 
 if(${BUILD_WITH_LUCENE})
     add_subdirectory(lucene)
diff --git a/source/dnode/mgmt/mgmt_dnode/CMakeLists.txt b/source/dnode/mgmt/mgmt_dnode/CMakeLists.txt
index fdd0830a58..7d0b6d617d 100644
--- a/source/dnode/mgmt/mgmt_dnode/CMakeLists.txt
+++ b/source/dnode/mgmt/mgmt_dnode/CMakeLists.txt
@@ -9,5 +9,5 @@ target_include_directories(
     PUBLIC "${GRANT_CFG_INCLUDE_DIR}"
 )
 target_link_libraries(
-    mgmt_dnode node_util
+    mgmt_dnode node_util rocksdb
 )
\ No newline at end of file
diff --git a/source/dnode/vnode/CMakeLists.txt b/source/dnode/vnode/CMakeLists.txt
index e8660cd6ad..79a7d55198 100644
--- a/source/dnode/vnode/CMakeLists.txt
+++ b/source/dnode/vnode/CMakeLists.txt
@@ -117,9 +117,7 @@ if(${BUILD_WITH_INVERTEDINDEX})
     add_definitions(-DUSE_INVERTED_INDEX)
 endif(${BUILD_WITH_INVERTEDINDEX})
 
-if(${BUILD_WITH_ROCKSDB})
     add_definitions(-DUSE_ROCKSDB)
-endif(${BUILD_WITH_ROCKSDB})
 
 
 
diff --git a/source/libs/stream/CMakeLists.txt b/source/libs/stream/CMakeLists.txt
index 2edbc44aae..5952250b3e 100644
--- a/source/libs/stream/CMakeLists.txt
+++ b/source/libs/stream/CMakeLists.txt
@@ -6,7 +6,6 @@ target_include_directories(
     PRIVATE "${CMAKE_CURRENT_SOURCE_DIR}/inc"
 )
 
-if(${BUILD_WITH_ROCKSDB})
   target_link_libraries(
     stream
     PUBLIC rocksdb tdb
@@ -19,7 +18,6 @@ if(${BUILD_WITH_ROCKSDB})
   )
 
   add_definitions(-DUSE_ROCKSDB)
-endif(${BUILD_WITH_ROCKSDB})
 
 
 #target_link_libraries(