From e4916d13a5c245820e3918bf623107b0b15395c1 Mon Sep 17 00:00:00 2001
From: Yihao Deng <luomoxyz@126.com>
Date: Wed, 19 Jun 2024 12:11:03 +0000
Subject: [PATCH] update case

---
 source/util/src/tcompression.c           |  7 +++++++
 tests/script/tsim/compress/compress2.sim | 25 ++++++++++++++++++++++++
 2 files changed, 32 insertions(+)

diff --git a/source/util/src/tcompression.c b/source/util/src/tcompression.c
index 1e7e09794f..0cc822da4c 100644
--- a/source/util/src/tcompression.c
+++ b/source/util/src/tcompression.c
@@ -2916,7 +2916,9 @@ int32_t tcompressDebug(uint32_t cmprAlg, uint8_t *l1Alg, uint8_t *l2Alg, uint8_t
   *level = lvl;
   return 0;
 }
+
 int8_t tUpdateCompress(uint32_t oldCmpr, uint32_t newCmpr, uint8_t l2Disabled, uint8_t lvlDiabled, uint8_t lvlDefault,
+
                        uint32_t *dst) {
   int8_t  update = 0;
   uint8_t ol1 = COMPRESS_L1_TYPE_U32(oldCmpr);
@@ -2926,6 +2928,10 @@ int8_t tUpdateCompress(uint32_t oldCmpr, uint32_t newCmpr, uint8_t l2Disabled, u
   uint8_t nl1 = COMPRESS_L1_TYPE_U32(newCmpr);
   uint8_t nl2 = COMPRESS_L2_TYPE_U32(newCmpr);
   uint8_t nlvl = COMPRESS_L2_TYPE_LEVEL_U32(newCmpr);
+
+  // nl1 == 0, not update encode
+  // nl2 == 0, not update compress
+  // nl3 == 0, not update level
   if (nl1 != 0 && ol1 != nl1) {
     SET_COMPRESS(nl1, ol2, olvl, *dst);
     update = 1;
@@ -2950,5 +2956,6 @@ int8_t tUpdateCompress(uint32_t oldCmpr, uint32_t newCmpr, uint8_t l2Disabled, u
     SET_COMPRESS(ol1, ol2, nlvl, *dst);
     update = 1;
   }
+
   return update;
 }
diff --git a/tests/script/tsim/compress/compress2.sim b/tests/script/tsim/compress/compress2.sim
index a439d75a59..0af6f87de4 100644
--- a/tests/script/tsim/compress/compress2.sim
+++ b/tests/script/tsim/compress/compress2.sim
@@ -163,6 +163,31 @@ sql alter table $stb modify column f compress 'zlib'
 sql desc $stb
 sql alter table $stb modify column f compress 'zstd'
 
+
+sql alter table $stb modify column f compress 'zstd' level 'h' 
+sql_error alter table $stb modify column f compress 'zstd' level 'h' 
+
+sql alter table $stb modify column f compress 'lz4' level 'h' 
+sql_error alter table $stb modify column f compress 'lz4' level 'h' 
+
+
+sql alter table $stb modify column f level 'low' 
+sql_error alter table $stb modify column f compress 'lz4' 
+
+sql_error alter table $stb modify column f compress 'lz4' level 'low'  
+
+sql alter table $stb modify column f compress 'zstd' level 'h'  
+
+sql_error alter table $stb modify column f compress 'zstd'  
+sql_error alter table $stb modify column f level 'h'  
+
+
+
+sql alter table $stb modify column f compress 'lz4' 
+
+
+
+
 sql_error alter table $stb modify column d compress 'lz4' # same with init
 sql alter table $stb modify column d compress 'disabled'
 sql desc $stb