Merge pull request #28089 from taosdata/fix/TD-31891-remove-void-monitor3-2

Fix/td 31891 remove void monitor3 2

source/libs/monitor/src/monFramework.c

@@ -100,7 +100,9 @@ extern char* tsMonFwUri;
 #define VNODE_ROLE "taosd_vnodes_info:role"
 
 void monInitMonitorFW(){
-  (void)taos_collector_registry_default_init();
+  if (taos_collector_registry_default_init() != 0) {
+    uError("failed to init default collector registry");
+  }
 
   tsMonitor.metrics = taosHashInit(16, taosGetDefaultHashFunction(TSDB_DATA_TYPE_BINARY), true, HASH_ENTRY_LOCK);
   taos_gauge_t *gauge = NULL;
@@ -115,7 +117,9 @@ void monInitMonitorFW(){
   for(int32_t i = 0; i < 25; i++){
     gauge= taos_gauge_new(dnodes_gauges[i], "",  dnodes_label_count, dnodes_sample_labels);
     if(taos_collector_registry_register_metric(gauge) == 1){
-      (void)taos_counter_destroy(gauge);
+      if (taos_counter_destroy(gauge) != 0) {
+        uError("failed to delete metric %s", dnodes_gauges[i]);
+      }
     }
     if (taosHashPut(tsMonitor.metrics, dnodes_gauges[i], strlen(dnodes_gauges[i]), &gauge, sizeof(taos_gauge_t *)) !=
         0) {
@@ -129,7 +133,9 @@ void monInitMonitorFW(){
   for(int32_t i = 0; i < 3; i++){
     gauge= taos_gauge_new(dnodes_data_gauges[i], "",  dnodes_data_label_count, dnodes_data_sample_labels);
     if(taos_collector_registry_register_metric(gauge) == 1){
-      (void)taos_counter_destroy(gauge);
+      if (taos_counter_destroy(gauge) != 0) {
+        uError("failed to delete metric %s", dnodes_data_gauges[i]);
+      }
     }
     if (taosHashPut(tsMonitor.metrics, dnodes_data_gauges[i], strlen(dnodes_data_gauges[i]), &gauge,
                     sizeof(taos_gauge_t *)) != 0) {
@@ -143,7 +149,9 @@ void monInitMonitorFW(){
   for(int32_t i = 0; i < 3; i++){
     gauge= taos_gauge_new(dnodes_log_gauges[i], "",  dnodes_log_label_count, dnodes_log_sample_labels);
     if(taos_collector_registry_register_metric(gauge) == 1){
-      (void)taos_counter_destroy(gauge);
+      if (taos_counter_destroy(gauge) != 0) {
+        uError("failed to delete metric %s", dnodes_log_gauges[i]);
+      }
     }
     if (taosHashPut(tsMonitor.metrics, dnodes_log_gauges[i], strlen(dnodes_log_gauges[i]), &gauge,
                     sizeof(taos_gauge_t *)) != 0) {
@@ -154,7 +162,9 @@ void monInitMonitorFW(){
 
 void monCleanupMonitorFW(){
   taosHashCleanup(tsMonitor.metrics);
-  (void)taos_collector_registry_destroy(TAOS_COLLECTOR_REGISTRY_DEFAULT);
+  if (taos_collector_registry_destroy(TAOS_COLLECTOR_REGISTRY_DEFAULT) != 0) {
+    uError("failed to destroy default collector registry");
+  }
   TAOS_COLLECTOR_REGISTRY_DEFAULT = NULL;
 }
 
@@ -174,7 +184,9 @@ void monGenClusterInfoTable(SMonInfo *pMonitor){
       uError("failed to delete metric %s", metric_names[i]);
     }
 
-    (void)taosHashRemove(tsMonitor.metrics, metric_names[i], strlen(metric_names[i]));
+    if (taosHashRemove(tsMonitor.metrics, metric_names[i], strlen(metric_names[i])) != 0) {
+      uError("failed to remove metric %s", metric_names[i]);
+    }
   } 
 
   if(pBasicInfo->cluster_id == 0) {
@@ -191,7 +203,9 @@ void monGenClusterInfoTable(SMonInfo *pMonitor){
   for(int32_t i = 0; i < 18; i++){
     gauge= taos_gauge_new(metric_names[i], "",  label_count, sample_labels1);
     if(taos_collector_registry_register_metric(gauge) == 1){
-      (void)taos_counter_destroy(gauge);
+      if (taos_counter_destroy(gauge) != 0) {
+        uError("failed to delete metric %s", metric_names[i]);
+      }
     }
     if (taosHashPut(tsMonitor.metrics, metric_names[i], strlen(metric_names[i]), &gauge, sizeof(taos_gauge_t *)) != 0) {
       uError("failed to add cluster gauge at%d:%s", i, metric_names[i]);
@@ -317,11 +331,15 @@ void monGenVgroupInfoTable(SMonInfo *pMonitor){
   const char *vgroup_sample_labels[] = {"cluster_id", "vgroup_id", "database_name"};
   taos_gauge_t *tableNumGauge = taos_gauge_new(TABLES_NUM, "",  vgroup_label_count, vgroup_sample_labels);
   if(taos_collector_registry_register_metric(tableNumGauge) == 1){
-    (void)taos_counter_destroy(tableNumGauge);
+    if (taos_counter_destroy(tableNumGauge) != 0) {
+      uError("failed to delete metric " TABLES_NUM);
+    }
   }
   taos_gauge_t *statusGauge = taos_gauge_new(STATUS, "",  vgroup_label_count, vgroup_sample_labels);
   if(taos_collector_registry_register_metric(statusGauge) == 1){
-    (void)taos_counter_destroy(statusGauge);
+    if (taos_counter_destroy(statusGauge) != 0) {
+      uError("failed to delete metric " STATUS);
+    }
   }
 
   char cluster_id[TSDB_CLUSTER_ID_LEN] = {0};
@@ -530,7 +548,9 @@ void monGenDnodeStatusInfoTable(SMonInfo *pMonitor){
 
   gauge= taos_gauge_new(DNODE_STATUS, "",  dnodes_label_count, dnodes_sample_labels);
   if(taos_collector_registry_register_metric(gauge) == 1){
-    (void)taos_counter_destroy(gauge);
+    if (taos_counter_destroy(gauge) != 0) {
+      uError("failed to delete metric " DNODE_STATUS);
+    }
   }
 
   char cluster_id[TSDB_CLUSTER_ID_LEN];
@@ -633,7 +653,9 @@ void monGenMnodeRoleTable(SMonInfo *pMonitor){
       uError("failed to delete metric %s", mnodes_role_gauges[i]);
     }
 
-    (void)taosHashRemove(tsMonitor.metrics, mnodes_role_gauges[i], strlen(mnodes_role_gauges[i]));
+    if (taosHashRemove(tsMonitor.metrics, mnodes_role_gauges[i], strlen(mnodes_role_gauges[i])) != 0) {
+      uError("failed to remove metric %s", mnodes_role_gauges[i]);
+    }
   }
 
   SMonClusterInfo *pInfo = &pMonitor->mmInfo.cluster;
@@ -647,7 +669,9 @@ void monGenMnodeRoleTable(SMonInfo *pMonitor){
   for(int32_t i = 0; i < 1; i++){
     gauge= taos_gauge_new(mnodes_role_gauges[i], "",  mnodes_role_label_count, mnodes_role_sample_labels);
     if(taos_collector_registry_register_metric(gauge) == 1){
-      (void)taos_counter_destroy(gauge);
+      if (taos_counter_destroy(gauge) != 0) {
+        uError("failed to destroy gauge");
+      }
     }
     if (taosHashPut(tsMonitor.metrics, mnodes_role_gauges[i], strlen(mnodes_role_gauges[i]), &gauge,
                     sizeof(taos_gauge_t *)) != 0) {
@@ -702,7 +726,9 @@ void monGenVnodeRoleTable(SMonInfo *pMonitor){
       uError("failed to delete metric %s", vnodes_role_gauges[i]);
     }
 
-    (void)taosHashRemove(tsMonitor.metrics, vnodes_role_gauges[i], strlen(vnodes_role_gauges[i]));
+    if (taosHashRemove(tsMonitor.metrics, vnodes_role_gauges[i], strlen(vnodes_role_gauges[i])) != 0) {
+      uError("failed to remove metric %s", vnodes_role_gauges[i]);
+    }
   }
 
   SMonVgroupInfo *pInfo = &pMonitor->mmInfo.vgroup;
@@ -716,7 +742,9 @@ void monGenVnodeRoleTable(SMonInfo *pMonitor){
   for(int32_t i = 0; i < 1; i++){
     gauge= taos_gauge_new(vnodes_role_gauges[i], "",  vnodes_role_label_count, vnodes_role_sample_labels);
     if(taos_collector_registry_register_metric(gauge) == 1){
-      (void)taos_counter_destroy(gauge);
+      if (taos_counter_destroy(gauge) != 0) {
+        uError("failed to destroy gauge");
+      }
     }
     if (taosHashPut(tsMonitor.metrics, vnodes_role_gauges[i], strlen(vnodes_role_gauges[i]), &gauge,
                     sizeof(taos_gauge_t *)) != 0) {
@@ -774,7 +802,9 @@ void monSendPromReport() {
                                   tmp) != 0) {
       uError("failed to send monitor msg");
     } else {
-      (void)taos_collector_registry_clear_batch(TAOS_COLLECTOR_REGISTRY_DEFAULT);
+      if (taos_collector_registry_clear_batch(TAOS_COLLECTOR_REGISTRY_DEFAULT) != 0) {
+        uError("failed to clear batch");
+      }
     }
     taosMemoryFreeClear(pCont);
   }

source/libs/monitor/src/monMain.c

@@ -145,7 +145,9 @@ void monInitVnode() {
     counter = taos_counter_new(VNODE_METRIC_SQL_COUNT, "counter for insert sql", label_count, sample_labels);
     uDebug("new metric:%p", counter);
     if (taos_collector_registry_register_metric(counter) == 1) {
-      (void)taos_counter_destroy(counter);
+      if (taos_counter_destroy(counter) != 0) {
+        uError("failed to destroy metric:%p", counter);
+      }
       uError("failed to register metric:%p", counter);
     } else {
       tsInsertCounter = counter;
@@ -226,14 +228,17 @@ static void monGenBasicJson(SMonInfo *pMonitor) {
 
   SJson *pJson = pMonitor->pJson;
   char   buf[40] = {0};
-  (void)taosFormatUtcTime(buf, sizeof(buf), pMonitor->curTime, TSDB_TIME_PRECISION_MILLI);
+  if (taosFormatUtcTime(buf, sizeof(buf), pMonitor->curTime, TSDB_TIME_PRECISION_MILLI) != 0) {
+    uError("failed to format time");
+    return;
+  }
 
-  (void)tjsonAddStringToObject(pJson, "ts", buf);
+  if (tjsonAddStringToObject(pJson, "ts", buf) != 0) uError("failed to add ts");
-  (void)tjsonAddDoubleToObject(pJson, "dnode_id", pInfo->dnode_id);
+  if (tjsonAddDoubleToObject(pJson, "dnode_id", pInfo->dnode_id) != 0) uError("failed to add dnode_id");
-  (void)tjsonAddStringToObject(pJson, "dnode_ep", pInfo->dnode_ep);
+  if (tjsonAddStringToObject(pJson, "dnode_ep", pInfo->dnode_ep) != 0) uError("failed to add dnode_ep");
   snprintf(buf, sizeof(buf), "%" PRId64, pInfo->cluster_id);
-  (void)tjsonAddStringToObject(pJson, "cluster_id", buf);
+  if (tjsonAddStringToObject(pJson, "cluster_id", buf) != 0) uError("failed to add cluster_id");
-  (void)tjsonAddDoubleToObject(pJson, "protocol", pInfo->protocol);
+  if (tjsonAddDoubleToObject(pJson, "protocol", pInfo->protocol) != 0) uError("failed to add protocol");
 }
 
 static void monGenBasicJsonBasic(SMonInfo *pMonitor) {
@@ -244,12 +249,12 @@ static void monGenBasicJsonBasic(SMonInfo *pMonitor) {
   char   buf[40] = {0};
 
   sprintf(buf, "%" PRId64, taosGetTimestamp(TSDB_TIME_PRECISION_MILLI));
-  (void)tjsonAddStringToObject(pJson, "ts", buf);
+  if (tjsonAddStringToObject(pJson, "ts", buf) != 0) uError("failed to add ts");
-  (void)tjsonAddDoubleToObject(pJson, "dnode_id", pInfo->dnode_id);
+  if (tjsonAddDoubleToObject(pJson, "dnode_id", pInfo->dnode_id) != 0) uError("failed to add dnode_id");
-  (void)tjsonAddStringToObject(pJson, "dnode_ep", pInfo->dnode_ep);
+  if (tjsonAddStringToObject(pJson, "dnode_ep", pInfo->dnode_ep) != 0) uError("failed to add dnode_ep");
   snprintf(buf, sizeof(buf), "%" PRId64, pInfo->cluster_id);
-  (void)tjsonAddStringToObject(pJson, "cluster_id", buf);
+  if (tjsonAddStringToObject(pJson, "cluster_id", buf) != 0) uError("failed to add cluster_id");
-  (void)tjsonAddDoubleToObject(pJson, "protocol", pInfo->protocol);
+  if (tjsonAddDoubleToObject(pJson, "protocol", pInfo->protocol) != 0) uError("failed to add protocol");
 }
 
 static void monGenClusterJson(SMonInfo *pMonitor) {
@@ -263,21 +268,24 @@ static void monGenClusterJson(SMonInfo *pMonitor) {
     return;
   }
 
-  (void)tjsonAddStringToObject(pJson, "first_ep", pInfo->first_ep);
+  if (tjsonAddStringToObject(pJson, "first_ep", pInfo->first_ep) != 0) uError("failed to add first_ep");
-  (void)tjsonAddDoubleToObject(pJson, "first_ep_dnode_id", pInfo->first_ep_dnode_id);
+  if (tjsonAddDoubleToObject(pJson, "first_ep_dnode_id", pInfo->first_ep_dnode_id) != 0)
-  (void)tjsonAddStringToObject(pJson, "version", pInfo->version);
+    uError("failed to add first_ep_dnode_id");
-  (void)tjsonAddDoubleToObject(pJson, "master_uptime", pInfo->master_uptime);
+  if (tjsonAddStringToObject(pJson, "version", pInfo->version) != 0) uError("failed to add version");
-  (void)tjsonAddDoubleToObject(pJson, "monitor_interval", pInfo->monitor_interval);
+  if (tjsonAddDoubleToObject(pJson, "master_uptime", pInfo->master_uptime) != 0) uError("failed to add master_uptime");
-  (void)tjsonAddDoubleToObject(pJson, "dbs_total", pInfo->dbs_total);
+  if (tjsonAddDoubleToObject(pJson, "monitor_interval", pInfo->monitor_interval) != 0)
-  (void)tjsonAddDoubleToObject(pJson, "tbs_total", pInfo->tbs_total);
+    uError("failed to add monitor_interval");
-  (void)tjsonAddDoubleToObject(pJson, "stbs_total", pInfo->stbs_total);
+  if (tjsonAddDoubleToObject(pJson, "dbs_total", pInfo->dbs_total) != 0) uError("failed to add dbs_total");
-  (void)tjsonAddDoubleToObject(pJson, "vgroups_total", pInfo->vgroups_total);
+  if (tjsonAddDoubleToObject(pJson, "tbs_total", pInfo->tbs_total) != 0) uError("failed to add tbs_total");
-  (void)tjsonAddDoubleToObject(pJson, "vgroups_alive", pInfo->vgroups_alive);
+  if (tjsonAddDoubleToObject(pJson, "stbs_total", pInfo->stbs_total) != 0) uError("failed to add stbs_total");
-  (void)tjsonAddDoubleToObject(pJson, "vnodes_total", pInfo->vnodes_total);
+  if (tjsonAddDoubleToObject(pJson, "vgroups_total", pInfo->vgroups_total) != 0) uError("failed to add vgroups_total");
-  (void)tjsonAddDoubleToObject(pJson, "vnodes_alive", pInfo->vnodes_alive);
+  if (tjsonAddDoubleToObject(pJson, "vgroups_alive", pInfo->vgroups_alive) != 0) uError("failed to add vgroups_alive");
-  (void)tjsonAddDoubleToObject(pJson, "connections_total", pInfo->connections_total);
+  if (tjsonAddDoubleToObject(pJson, "vnodes_total", pInfo->vnodes_total) != 0) uError("failed to add vnodes_total");
-  (void)tjsonAddDoubleToObject(pJson, "topics_total", pInfo->topics_toal);
+  if (tjsonAddDoubleToObject(pJson, "vnodes_alive", pInfo->vnodes_alive) != 0) uError("failed to add vnodes_alive");
-  (void)tjsonAddDoubleToObject(pJson, "streams_total", pInfo->streams_total);
+  if (tjsonAddDoubleToObject(pJson, "connections_total", pInfo->connections_total) != 0)
+    uError("failed to add connections_total");
+  if (tjsonAddDoubleToObject(pJson, "topics_total", pInfo->topics_toal) != 0) uError("failed to add topics_total");
+  if (tjsonAddDoubleToObject(pJson, "streams_total", pInfo->streams_total) != 0) uError("failed to add streams_total");
 
   SJson *pDnodesJson = tjsonAddArrayToObject(pJson, "dnodes");
   if (pDnodesJson == NULL) return;
@@ -287,9 +295,9 @@ static void monGenClusterJson(SMonInfo *pMonitor) {
     if (pDnodeJson == NULL) continue;
 
     SMonDnodeDesc *pDnodeDesc = taosArrayGet(pInfo->dnodes, i);
-    (void)tjsonAddDoubleToObject(pDnodeJson, "dnode_id", pDnodeDesc->dnode_id);
+    if (tjsonAddDoubleToObject(pDnodeJson, "dnode_id", pDnodeDesc->dnode_id) != 0) uError("failed to add dnode_id");
-    (void)tjsonAddStringToObject(pDnodeJson, "dnode_ep", pDnodeDesc->dnode_ep);
+    if (tjsonAddStringToObject(pDnodeJson, "dnode_ep", pDnodeDesc->dnode_ep) != 0) uError("failed to add dnode_ep");
-    (void)tjsonAddStringToObject(pDnodeJson, "status", pDnodeDesc->status);
+    if (tjsonAddStringToObject(pDnodeJson, "status", pDnodeDesc->status) != 0) uError("failed to add status");
 
     if (tjsonAddItemToArray(pDnodesJson, pDnodeJson) != 0) tjsonDelete(pDnodeJson);
   }
@@ -302,9 +310,9 @@ static void monGenClusterJson(SMonInfo *pMonitor) {
     if (pMnodeJson == NULL) continue;
 
     SMonMnodeDesc *pMnodeDesc = taosArrayGet(pInfo->mnodes, i);
-    (void)tjsonAddDoubleToObject(pMnodeJson, "mnode_id", pMnodeDesc->mnode_id);
+    if (tjsonAddDoubleToObject(pMnodeJson, "mnode_id", pMnodeDesc->mnode_id) != 0) uError("failed to add mnode_id");
-    (void)tjsonAddStringToObject(pMnodeJson, "mnode_ep", pMnodeDesc->mnode_ep);
+    if (tjsonAddStringToObject(pMnodeJson, "mnode_ep", pMnodeDesc->mnode_ep) != 0) uError("failed to add mnode_ep");
-    (void)tjsonAddStringToObject(pMnodeJson, "role", pMnodeDesc->role);
+    if (tjsonAddStringToObject(pMnodeJson, "role", pMnodeDesc->role) != 0) uError("failed to add role");
 
     if (tjsonAddItemToArray(pMnodesJson, pMnodeJson) != 0) tjsonDelete(pMnodeJson);
   }
@@ -314,11 +322,11 @@ static void monGenClusterJsonBasic(SMonInfo *pMonitor) {
   SMonClusterInfo *pInfo = &pMonitor->mmInfo.cluster;
   if (pMonitor->mmInfo.cluster.first_ep_dnode_id == 0) return;
 
-  // (void)tjsonAddStringToObject(pMonitor->pJson, "first_ep", pInfo->first_ep);
+  if (tjsonAddStringToObject(pMonitor->pJson, "first_ep", tsFirst) != 0) uError("failed to add first_ep");
-  (void)tjsonAddStringToObject(pMonitor->pJson, "first_ep", tsFirst);
+  if (tjsonAddDoubleToObject(pMonitor->pJson, "first_ep_dnode_id", pInfo->first_ep_dnode_id) != 0)
-  (void)tjsonAddDoubleToObject(pMonitor->pJson, "first_ep_dnode_id", pInfo->first_ep_dnode_id);
+    uError("failed to add first_ep_dnode_id");
-  (void)tjsonAddStringToObject(pMonitor->pJson, "cluster_version", pInfo->version);
+  if (tjsonAddStringToObject(pMonitor->pJson, "cluster_version", pInfo->version) != 0)
-  // (void)tjsonAddDoubleToObject(pMonitor->pJson, "monitor_interval", pInfo->monitor_interval);
+    uError("failed to add cluster_version");
 }
 
 static void monGenVgroupJson(SMonInfo *pMonitor) {
@@ -337,10 +345,13 @@ static void monGenVgroupJson(SMonInfo *pMonitor) {
     }
 
     SMonVgroupDesc *pVgroupDesc = taosArrayGet(pInfo->vgroups, i);
-    (void)tjsonAddDoubleToObject(pVgroupJson, "vgroup_id", pVgroupDesc->vgroup_id);
+    if (tjsonAddDoubleToObject(pVgroupJson, "vgroup_id", pVgroupDesc->vgroup_id) != 0)
-    (void)tjsonAddStringToObject(pVgroupJson, "database_name", pVgroupDesc->database_name);
+      uError("failed to add vgroup_id");
-    (void)tjsonAddDoubleToObject(pVgroupJson, "tables_num", pVgroupDesc->tables_num);
+    if (tjsonAddStringToObject(pVgroupJson, "database_name", pVgroupDesc->database_name) != 0)
-    (void)tjsonAddStringToObject(pVgroupJson, "status", pVgroupDesc->status);
+      uError("failed to add database_name");
+    if (tjsonAddDoubleToObject(pVgroupJson, "tables_num", pVgroupDesc->tables_num) != 0)
+      uError("failed to add tables_num");
+    if (tjsonAddStringToObject(pVgroupJson, "status", pVgroupDesc->status) != 0) uError("failed to add status");
 
     SJson *pVnodesJson = tjsonAddArrayToObject(pVgroupJson, "vnodes");
     if (pVnodesJson == NULL) continue;
@@ -352,8 +363,9 @@ static void monGenVgroupJson(SMonInfo *pMonitor) {
       SJson *pVnodeJson = tjsonCreateObject();
       if (pVnodeJson == NULL) continue;
 
-      (void)tjsonAddDoubleToObject(pVnodeJson, "dnode_id", pVnodeDesc->dnode_id);
+      if (tjsonAddDoubleToObject(pVnodeJson, "dnode_id", pVnodeDesc->dnode_id) != 0) uError("failed to add dnode_id");
-      (void)tjsonAddStringToObject(pVnodeJson, "vnode_role", pVnodeDesc->vnode_role);
+      if (tjsonAddStringToObject(pVnodeJson, "vnode_role", pVnodeDesc->vnode_role) != 0)
+        uError("failed to add vnode_role");
 
       if (tjsonAddItemToArray(pVnodesJson, pVnodeJson) != 0) tjsonDelete(pVnodeJson);
     }
@@ -376,8 +388,9 @@ static void monGenStbJson(SMonInfo *pMonitor) {
     }
 
     SMonStbDesc *pStbDesc = taosArrayGet(pInfo->stbs, i);
-    (void)tjsonAddStringToObject(pStbJson, "stb_name", pStbDesc->stb_name);
+    if (tjsonAddStringToObject(pStbJson, "stb_name", pStbDesc->stb_name) != 0) uError("failed to add stb_name");
-    (void)tjsonAddStringToObject(pStbJson, "database_name", pStbDesc->database_name);
+    if (tjsonAddStringToObject(pStbJson, "database_name", pStbDesc->database_name) != 0)
+      uError("failed to add database_name");
   }
 }
 
@@ -392,9 +405,11 @@ static void monGenGrantJson(SMonInfo *pMonitor) {
     return;
   }
 
-  (void)tjsonAddDoubleToObject(pJson, "expire_time", pInfo->expire_time);
+  if (tjsonAddDoubleToObject(pJson, "expire_time", pInfo->expire_time) != 0) uError("failed to add expire_time");
-  (void)tjsonAddDoubleToObject(pJson, "timeseries_used", pInfo->timeseries_used);
+  if (tjsonAddDoubleToObject(pJson, "timeseries_used", pInfo->timeseries_used) != 0)
-  (void)tjsonAddDoubleToObject(pJson, "timeseries_total", pInfo->timeseries_total);
+    uError("failed to add timeseries_used");
+  if (tjsonAddDoubleToObject(pJson, "timeseries_total", pInfo->timeseries_total) != 0)
+    uError("failed to add timeseries_total");
 }
 
 static void monGenDnodeJson(SMonInfo *pMonitor) {
@@ -451,36 +466,40 @@ static void monGenDnodeJson(SMonInfo *pMonitor) {
   double io_read_disk_rate = io_read_disk / interval;
   double io_write_disk_rate = io_write_disk / interval;
 
-  (void)tjsonAddDoubleToObject(pJson, "uptime", pInfo->uptime);
+  if (tjsonAddDoubleToObject(pJson, "uptime", pInfo->uptime) != 0) uError("failed to add uptime");
-  (void)tjsonAddDoubleToObject(pJson, "cpu_engine", cpu_engine);
+  if (tjsonAddDoubleToObject(pJson, "cpu_engine", cpu_engine) != 0) uError("failed to add cpu_engine");
-  (void)tjsonAddDoubleToObject(pJson, "cpu_system", pSys->cpu_system);
+  if (tjsonAddDoubleToObject(pJson, "cpu_system", pSys->cpu_system) != 0) uError("failed to add cpu_system");
-  (void)tjsonAddDoubleToObject(pJson, "cpu_cores", pSys->cpu_cores);
+  if (tjsonAddDoubleToObject(pJson, "cpu_cores", pSys->cpu_cores) != 0) uError("failed to add cpu_cores");
-  (void)tjsonAddDoubleToObject(pJson, "mem_engine", mem_engine);
+  if (tjsonAddDoubleToObject(pJson, "mem_engine", mem_engine) != 0) uError("failed to add mem_engine");
-  (void)tjsonAddDoubleToObject(pJson, "mem_system", pSys->mem_system);
+  if (tjsonAddDoubleToObject(pJson, "mem_system", pSys->mem_system) != 0) uError("failed to add mem_system");
-  (void)tjsonAddDoubleToObject(pJson, "mem_total", pSys->mem_total);
+  if (tjsonAddDoubleToObject(pJson, "mem_total", pSys->mem_total) != 0) uError("failed to add mem_total");
-  (void)tjsonAddDoubleToObject(pJson, "disk_engine", pSys->disk_engine);
+  if (tjsonAddDoubleToObject(pJson, "disk_engine", pSys->disk_engine) != 0) uError("failed to add disk_engine");
-  (void)tjsonAddDoubleToObject(pJson, "disk_used", pSys->disk_used);
+  if (tjsonAddDoubleToObject(pJson, "disk_used", pSys->disk_used) != 0) uError("failed to add disk_used");
-  (void)tjsonAddDoubleToObject(pJson, "disk_total", pSys->disk_total);
+  if (tjsonAddDoubleToObject(pJson, "disk_total", pSys->disk_total) != 0) uError("failed to add disk_total");
-  (void)tjsonAddDoubleToObject(pJson, "net_in", net_in_rate);
+  if (tjsonAddDoubleToObject(pJson, "net_in", net_in_rate) != 0) uError("failed to add net_in");
-  (void)tjsonAddDoubleToObject(pJson, "net_out", net_out_rate);
+  if (tjsonAddDoubleToObject(pJson, "net_out", net_out_rate) != 0) uError("failed to add net_out");
-  (void)tjsonAddDoubleToObject(pJson, "io_read", io_read_rate);
+  if (tjsonAddDoubleToObject(pJson, "io_read", io_read_rate) != 0) uError("failed to add io_read");
-  (void)tjsonAddDoubleToObject(pJson, "io_write", io_write_rate);
+  if (tjsonAddDoubleToObject(pJson, "io_write", io_write_rate) != 0) uError("failed to add io_write");
-  (void)tjsonAddDoubleToObject(pJson, "io_read_disk", io_read_disk_rate);
+  if (tjsonAddDoubleToObject(pJson, "io_read_disk", io_read_disk_rate) != 0) uError("failed to add io_read_disk");
-  (void)tjsonAddDoubleToObject(pJson, "io_write_disk", io_write_disk_rate);
+  if (tjsonAddDoubleToObject(pJson, "io_write_disk", io_write_disk_rate) != 0) uError("failed to add io_write_disk");
-  (void)tjsonAddDoubleToObject(pJson, "req_select", pStat->numOfSelectReqs);
+  if (tjsonAddDoubleToObject(pJson, "req_select", pStat->numOfSelectReqs) != 0) uError("failed to add req_select");
-  (void)tjsonAddDoubleToObject(pJson, "req_select_rate", req_select_rate);
+  if (tjsonAddDoubleToObject(pJson, "req_select_rate", req_select_rate) != 0) uError("failed to add req_select_rate");
-  (void)tjsonAddDoubleToObject(pJson, "req_insert", pStat->numOfInsertReqs);
+  if (tjsonAddDoubleToObject(pJson, "req_insert", pStat->numOfInsertReqs) != 0) uError("failed to add req_insert");
-  (void)tjsonAddDoubleToObject(pJson, "req_insert_success", pStat->numOfInsertSuccessReqs);
+  if (tjsonAddDoubleToObject(pJson, "req_insert_success", pStat->numOfInsertSuccessReqs) != 0)
-  (void)tjsonAddDoubleToObject(pJson, "req_insert_rate", req_insert_rate);
+    uError("failed to add req_insert_success");
-  (void)tjsonAddDoubleToObject(pJson, "req_insert_batch", pStat->numOfBatchInsertReqs);
+  if (tjsonAddDoubleToObject(pJson, "req_insert_rate", req_insert_rate) != 0) uError("failed to add req_insert_rate");
-  (void)tjsonAddDoubleToObject(pJson, "req_insert_batch_success", pStat->numOfBatchInsertSuccessReqs);
+  if (tjsonAddDoubleToObject(pJson, "req_insert_batch", pStat->numOfBatchInsertReqs) != 0)
-  (void)tjsonAddDoubleToObject(pJson, "req_insert_batch_rate", req_insert_batch_rate);
+    uError("failed to add req_insert_batch");
-  (void)tjsonAddDoubleToObject(pJson, "errors", pStat->errors);
+  if (tjsonAddDoubleToObject(pJson, "req_insert_batch_success", pStat->numOfBatchInsertSuccessReqs) != 0)
-  (void)tjsonAddDoubleToObject(pJson, "vnodes_num", pStat->totalVnodes);
+    uError("failed to add req_insert_batch_success");
-  (void)tjsonAddDoubleToObject(pJson, "masters", pStat->masterNum);
+  if (tjsonAddDoubleToObject(pJson, "req_insert_batch_rate", req_insert_batch_rate) != 0)
-  (void)tjsonAddDoubleToObject(pJson, "has_mnode", pInfo->has_mnode);
+    uError("failed to add req_insert_batch_rate");
-  (void)tjsonAddDoubleToObject(pJson, "has_qnode", pInfo->has_qnode);
+  if (tjsonAddDoubleToObject(pJson, "errors", pStat->errors) != 0) uError("failed to add errors");
-  (void)tjsonAddDoubleToObject(pJson, "has_snode", pInfo->has_snode);
+  if (tjsonAddDoubleToObject(pJson, "vnodes_num", pStat->totalVnodes) != 0) uError("failed to add vnodes_num");
+  if (tjsonAddDoubleToObject(pJson, "masters", pStat->masterNum) != 0) uError("failed to add masters");
+  if (tjsonAddDoubleToObject(pJson, "has_mnode", pInfo->has_mnode) != 0) uError("failed to add has_mnode");
+  if (tjsonAddDoubleToObject(pJson, "has_qnode", pInfo->has_qnode) != 0) uError("failed to add has_qnode");
+  if (tjsonAddDoubleToObject(pJson, "has_snode", pInfo->has_snode) != 0) uError("failed to add has_snode");
 }
 
 static void monGenDiskJson(SMonInfo *pMonitor) {
@@ -515,18 +534,18 @@ static void monGenDiskJson(SMonInfo *pMonitor) {
   SJson *pLogdirJson = tjsonCreateObject();
   if (pLogdirJson == NULL) return;
   if (tjsonAddItemToObject(pJson, "logdir", pLogdirJson) != 0) return;
-  (void)tjsonAddStringToObject(pLogdirJson, "name", pLogDesc->name);
+  if (tjsonAddStringToObject(pLogdirJson, "name", pLogDesc->name) != 0) uError("failed to add string to json");
-  (void)tjsonAddDoubleToObject(pLogdirJson, "avail", pLogDesc->size.avail);
+  if (tjsonAddDoubleToObject(pLogdirJson, "avail", pLogDesc->size.avail) != 0) uError("failed to add double to json");
-  (void)tjsonAddDoubleToObject(pLogdirJson, "used", pLogDesc->size.used);
+  if (tjsonAddDoubleToObject(pLogdirJson, "used", pLogDesc->size.used) != 0) uError("failed to add double to json");
-  (void)tjsonAddDoubleToObject(pLogdirJson, "total", pLogDesc->size.total);
+  if (tjsonAddDoubleToObject(pLogdirJson, "total", pLogDesc->size.total) != 0) uError("failed to add double to json");
 
   SJson *pTempdirJson = tjsonCreateObject();
   if (pTempdirJson == NULL) return;
   if (tjsonAddItemToObject(pJson, "tempdir", pTempdirJson) != 0) return;
-  (void)tjsonAddStringToObject(pTempdirJson, "name", pTempDesc->name);
+  if (tjsonAddStringToObject(pTempdirJson, "name", pTempDesc->name) != 0) uError("failed to add string to json");
-  (void)tjsonAddDoubleToObject(pTempdirJson, "avail", pTempDesc->size.avail);
+  if (tjsonAddDoubleToObject(pTempdirJson, "avail", pTempDesc->size.avail) != 0) uError("failed to add double to json");
-  (void)tjsonAddDoubleToObject(pTempdirJson, "used", pTempDesc->size.used);
+  if (tjsonAddDoubleToObject(pTempdirJson, "used", pTempDesc->size.used) != 0) uError("failed to add double to json");
-  (void)tjsonAddDoubleToObject(pTempdirJson, "total", pTempDesc->size.total);
+  if (tjsonAddDoubleToObject(pTempdirJson, "total", pTempDesc->size.total) != 0) uError("failed to add double to json");
 }
 
 static const char *monLogLevelStr(ELogLevel level) {
@@ -571,26 +590,26 @@ static void monGenLogJson(SMonInfo *pMonitor) {
 
   SJson *pLogError = tjsonCreateObject();
   if (pLogError == NULL) return;
-  (void)tjsonAddStringToObject(pLogError, "level", "error");
+  if (tjsonAddStringToObject(pLogError, "level", "error") != 0) uError("failed to add string to json");
-  (void)tjsonAddDoubleToObject(pLogError, "total", numOfErrorLogs);
+  if (tjsonAddDoubleToObject(pLogError, "total", numOfErrorLogs) != 0) uError("failed to add double to json");
   if (tjsonAddItemToArray(pSummaryJson, pLogError) != 0) tjsonDelete(pLogError);
 
   SJson *pLogInfo = tjsonCreateObject();
   if (pLogInfo == NULL) return;
-  (void)tjsonAddStringToObject(pLogInfo, "level", "info");
+  if (tjsonAddStringToObject(pLogInfo, "level", "info") != 0) uError("failed to add string to json");
-  (void)tjsonAddDoubleToObject(pLogInfo, "total", numOfInfoLogs);
+  if (tjsonAddDoubleToObject(pLogInfo, "total", numOfInfoLogs) != 0) uError("failed to add double to json");
   if (tjsonAddItemToArray(pSummaryJson, pLogInfo) != 0) tjsonDelete(pLogInfo);
 
   SJson *pLogDebug = tjsonCreateObject();
   if (pLogDebug == NULL) return;
-  (void)tjsonAddStringToObject(pLogDebug, "level", "debug");
+  if (tjsonAddStringToObject(pLogDebug, "level", "debug") != 0) uError("failed to add string to json");
-  (void)tjsonAddDoubleToObject(pLogDebug, "total", numOfDebugLogs);
+  if (tjsonAddDoubleToObject(pLogDebug, "total", numOfDebugLogs) != 0) uError("failed to add double to json");
   if (tjsonAddItemToArray(pSummaryJson, pLogDebug) != 0) tjsonDelete(pLogDebug);
 
   SJson *pLogTrace = tjsonCreateObject();
   if (pLogTrace == NULL) return;
-  (void)tjsonAddStringToObject(pLogTrace, "level", "trace");
+  if (tjsonAddStringToObject(pLogTrace, "level", "trace") != 0) uError("failed to add string to json");
-  (void)tjsonAddDoubleToObject(pLogTrace, "total", numOfTraceLogs);
+  if (tjsonAddDoubleToObject(pLogTrace, "total", numOfTraceLogs) != 0) uError("failed to add double to json");
   if (tjsonAddItemToArray(pSummaryJson, pLogTrace) != 0) tjsonDelete(pLogTrace);
 }