xxq250
/
homework-jianmu
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

fix comments

This commit is contained in:
wangjiaming0909 2024-11-18 15:22:11 +08:00
parent b589f9089c
commit cb44efd329
2 changed files with 14 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
source/libs/nodes/src/nodesUtilFuncs.c
View File

@ -2960,7 +2960,16 @@ static SNode* nodesListFindNode(SNodeList* pList, SNode* pNode) {
} }
int32_t nodesListDeduplicate(SNodeList** ppList) { int32_t nodesListDeduplicate(SNodeList** ppList) {
if (!ppList || LIST_LENGTH(*ppList) == 0) return TSDB_CODE_SUCCESS; if (!ppList || LIST_LENGTH(*ppList) <= 1) return TSDB_CODE_SUCCESS;
if (LIST_LENGTH(*ppList) == 2) {
SNode* pNode1 = nodesListGetNode(*ppList, 0);
SNode* pNode2 = nodesListGetNode(*ppList, 1);
if (nodesEqualNode(pNode1, pNode2)) {
SListCell* pCell = nodesListGetCell(*ppList, 1);
(void)nodesListErase(*ppList, pCell);
}
return TSDB_CODE_SUCCESS;
}
SNodeList* pTmp = NULL; SNodeList* pTmp = NULL;
int32_t code = nodesMakeList(&pTmp); int32_t code = nodesMakeList(&pTmp);
if (TSDB_CODE_SUCCESS == code) { if (TSDB_CODE_SUCCESS == code) {

7
source/libs/parser/src/parCalcConst.c
View File

@ -326,7 +326,6 @@ static int32_t calcConstProjections(SCalcConstContext* pCxt, SSelectStmt* pSelec
static int32_t calcConstGroupBy(SCalcConstContext* pCxt, SSelectStmt* pSelect) { static int32_t calcConstGroupBy(SCalcConstContext* pCxt, SSelectStmt* pSelect) {
int32_t code = calcConstList(pSelect->pGroupByList); int32_t code = calcConstList(pSelect->pGroupByList);
#if 0
if (TSDB_CODE_SUCCESS == code) { if (TSDB_CODE_SUCCESS == code) {
SNode* pNode = NULL; SNode* pNode = NULL;
FOREACH(pNode, pSelect->pGroupByList) { FOREACH(pNode, pSelect->pGroupByList) {
@ -337,9 +336,11 @@ static int32_t calcConstGroupBy(SCalcConstContext* pCxt, SSelectStmt* pSelect) {
} }
} }
} }
NODES_DESTORY_LIST(pSelect->pGroupByList); FOREACH(pNode, pSelect->pGroupByList) {
if (!cell->pPrev) continue;
ERASE_NODE(pSelect->pGroupByList);
}
} }
#endif
return code; return code;
} }