From c95c67e1680f2eaac68f945ed2c3eaa94e04d539 Mon Sep 17 00:00:00 2001
From: kailixu <klxu@taosdata.com>
Date: Wed, 18 Sep 2024 21:18:46 +0800
Subject: [PATCH] chore: remove assert

---
 source/client/src/clientTmq.c          | 2 --
 source/libs/executor/src/executor.c    | 2 --
 source/libs/executor/src/operator.c    | 1 -
 source/libs/parser/src/parCalcConst.c  | 1 -
 source/libs/parser/src/parInsertSql.c  | 1 -
 source/libs/parser/src/parTranslater.c | 2 --
 source/libs/parser/src/parUtil.c       | 2 --
 7 files changed, 11 deletions(-)

diff --git a/source/client/src/clientTmq.c b/source/client/src/clientTmq.c
index 10e3eb95e7..8836fce31a 100644
--- a/source/client/src/clientTmq.c
+++ b/source/client/src/clientTmq.c
@@ -3708,7 +3708,6 @@ int32_t tmq_offset_seek(tmq_t* tmq, const char* pTopicName, int32_t vgId, int64_
 
   int32_t msgSize = tSerializeSMqSeekReq(NULL, 0, &req);
   if (msgSize < 0) {
-    assert(0);
     return TSDB_CODE_PAR_INTERNAL_ERROR;
   }
 
@@ -3719,7 +3718,6 @@ int32_t tmq_offset_seek(tmq_t* tmq, const char* pTopicName, int32_t vgId, int64_
 
   if (tSerializeSMqSeekReq(msg, msgSize, &req) < 0) {
     taosMemoryFree(msg);
-    assert(0);
     return TSDB_CODE_PAR_INTERNAL_ERROR;
   }
 
diff --git a/source/libs/executor/src/executor.c b/source/libs/executor/src/executor.c
index e0099b6823..cd43c5c99e 100644
--- a/source/libs/executor/src/executor.c
+++ b/source/libs/executor/src/executor.c
@@ -1414,7 +1414,6 @@ int32_t qStreamPrepareScan(qTaskInfo_t tinfo, STqOffsetVal* pOffset, int8_t subT
       pScanBaseInfo->cond.twindows.skey = oldSkey;
     } else {
       qError("invalid pOffset->type:%d, %s", pOffset->type, id);
-      assert(0);
       return TSDB_CODE_PAR_INTERNAL_ERROR;
     }
 
@@ -1433,7 +1432,6 @@ int32_t qStreamPrepareScan(qTaskInfo_t tinfo, STqOffsetVal* pOffset, int8_t subT
 
       if (pAPI->snapshotFn.setForSnapShot(sContext, pOffset->uid) != 0) {
         qError("setDataForSnapShot error. uid:%" PRId64 " , %s", pOffset->uid, id);
-        assert(0);
         return TSDB_CODE_PAR_INTERNAL_ERROR;
       }
 
diff --git a/source/libs/executor/src/operator.c b/source/libs/executor/src/operator.c
index 3791233223..fe2f3f8dfe 100644
--- a/source/libs/executor/src/operator.c
+++ b/source/libs/executor/src/operator.c
@@ -184,7 +184,6 @@ int32_t extractOperatorInTree(SOperatorInfo* pOperator, int32_t type, const char
 
   if (pOperator == NULL) {
     qError("invalid operator, failed to find tableScanOperator %s", id);
-    assert(0);
     return TSDB_CODE_PAR_INTERNAL_ERROR;
   }
 
diff --git a/source/libs/parser/src/parCalcConst.c b/source/libs/parser/src/parCalcConst.c
index f8d6be21d5..87b434a202 100644
--- a/source/libs/parser/src/parCalcConst.c
+++ b/source/libs/parser/src/parCalcConst.c
@@ -200,7 +200,6 @@ static int32_t findAndReplaceNode(SCalcConstContext* pCxt, SNode** pRoot, SNode*
   nodesRewriteExprPostOrder(pRoot, doFindAndReplaceNode, pCxt);
   if (TSDB_CODE_SUCCESS == pCxt->code && strict && !pCxt->replaceCxt.replaced) {
     parserError("target replace node not found, %p", pTarget);
-    assert(0);
     return TSDB_CODE_PAR_INTERNAL_ERROR;
   }
   return pCxt->code;
diff --git a/source/libs/parser/src/parInsertSql.c b/source/libs/parser/src/parInsertSql.c
index ceaf686cc7..d15d305c95 100644
--- a/source/libs/parser/src/parInsertSql.c
+++ b/source/libs/parser/src/parInsertSql.c
@@ -175,7 +175,6 @@ static int32_t parseBoundColumns(SInsertParseContext* pCxt, const char** pSql, E
   } else {
     pSchema = pTableMeta->schema;
     if (pBoundInfo->numOfCols != getTbnameSchemaIndex(pTableMeta) + 1) {
-      assert(0);
       return TSDB_CODE_PAR_INTERNAL_ERROR;
     }
   }
diff --git a/source/libs/parser/src/parTranslater.c b/source/libs/parser/src/parTranslater.c
index b4e2ce4525..683e1b86e6 100755
--- a/source/libs/parser/src/parTranslater.c
+++ b/source/libs/parser/src/parTranslater.c
@@ -2868,7 +2868,6 @@ static int32_t rewriteSystemInfoFunc(STranslateContext* pCxt, SNode** pNode) {
     default:
       break;
   }
-  assert(0);
   return TSDB_CODE_PAR_INTERNAL_ERROR;
 }
 
@@ -3075,7 +3074,6 @@ static int32_t rewriteClientPseudoColumnFunc(STranslateContext* pCxt, SNode** pN
     default:
       break;
   }
-  assert(0);
   return TSDB_CODE_PAR_INTERNAL_ERROR;
 }
 
diff --git a/source/libs/parser/src/parUtil.c b/source/libs/parser/src/parUtil.c
index 1111a6b0b7..5c286e71ca 100644
--- a/source/libs/parser/src/parUtil.c
+++ b/source/libs/parser/src/parUtil.c
@@ -850,7 +850,6 @@ static int32_t putMetaDataToHash(const char* pKey, int32_t len, const SArray* pD
 int32_t getMetaDataFromHash(const char* pKey, int32_t len, SHashObj* pHash, void** pOutput) {
   SMetaRes** pRes = taosHashGet(pHash, pKey, len);
   if (NULL == pRes || NULL == *pRes) {
-    assert(0);
     return TSDB_CODE_PAR_INTERNAL_ERROR;
   }
   if (TSDB_CODE_SUCCESS == (*pRes)->code) {
@@ -1350,7 +1349,6 @@ int32_t getTsmaFromCache(SParseMetaCache* pMetaCache, const SName* pTsmaName, ST
   code = getMetaDataFromHash(tsmaFName, strlen(tsmaFName), pMetaCache->pTSMAs, (void**)&pTsmaRsp);
   if (TSDB_CODE_SUCCESS == code) {
     if (!pTsmaRsp || pTsmaRsp->pTsmas->size != 1) {
-      assert(0);
       return TSDB_CODE_PAR_INTERNAL_ERROR;
     }
     *pTsma = taosArrayGetP(pTsmaRsp->pTsmas, 0);