From c21ff8fdfeb80153e11c728473392d1c22910338 Mon Sep 17 00:00:00 2001 From: yihaoDeng Date: Thu, 28 Nov 2024 16:11:08 +0800 Subject: [PATCH] support escape and update test case --- source/libs/parser/src/parAstCreater.c | 1 + tests/script/tsim/tag/change_multi_tag.sim | 7 ++++++- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/source/libs/parser/src/parAstCreater.c b/source/libs/parser/src/parAstCreater.c index e05a399d32..1217618c0a 100644 --- a/source/libs/parser/src/parAstCreater.c +++ b/source/libs/parser/src/parAstCreater.c @@ -2547,6 +2547,7 @@ SNode* createAlterSingleTagColumnNode(SAstCreateContext* pCtx, SToken* pTagName, pCtx->errCode = nodesMakeNode(QUERY_NODE_ALTER_TABLE_STMT, (SNode**)&pStmt); CHECK_MAKE_NODE(pStmt); pStmt->alterType = TSDB_ALTER_TABLE_UPDATE_TAG_VAL; + CHECK_NAME(checkColumnName(pCtx, pTagName)); COPY_STRING_FORM_ID_TOKEN(pStmt->colName, pTagName); pStmt->pVal = (SValueNode*)pVal; pStmt->pNodeListTagValue = NULL; diff --git a/tests/script/tsim/tag/change_multi_tag.sim b/tests/script/tsim/tag/change_multi_tag.sim index 5bd8cba916..470b49d4dc 100644 --- a/tests/script/tsim/tag/change_multi_tag.sim +++ b/tests/script/tsim/tag/change_multi_tag.sim @@ -55,7 +55,11 @@ sql_error alter table $tbj set tag tagCol1 = 1, tagCol5="xxxxxxxxxxxxxxxx" # invalid tag value sql_error alter table $tbj set tag tagCol1 = 1, tagCol5="xxxxxxxxxxxxxxxx", tagCol7="yyyyyyyyyyyyyyyyyyyyyyyyy" # invalid data type -sql_error alter table $tbj set tag tagCol5="xxxx" + +# escape +sql_error alter table $tbj set tag `tagCol1`=true +sql_error alter table $tbj set tag `tagCol1`=true,`tagCol2`=1,`tagNotExist`=10 +sql_error alter table $tbj set tag `tagCol1`=true,`tagCol2`=1,tagcol1=true sql alter table $tbj set tag tagCol1 = 100, tagCol2 = 100 @@ -195,6 +199,7 @@ if $rows != 1 then endi sql alter table $tbj set tag tagCol1=true,tagCol2=-10,tagcol3=-100, tagcol4=-1000,tagcol5=NULL,tagCol6=NULL,tagCol7=NULL +sql alter table $tbj set tag `tagcol1`=true,`tagcol2`=-10,`tagcol3`=-100, `tagcol4`=-1000,`tagcol5`=NULL,`tagcol6`=NULL,`tagcol7`=NULL sql alter table $mt drop tag tagCol7 sql alter table $mt drop tag tagCol3