From b54d6e298250fb62459903ca8c741036e180986b Mon Sep 17 00:00:00 2001
From: kailixu <klxu@taosdata.com>
Date: Wed, 16 Aug 2023 09:55:30 +0800
Subject: [PATCH] chore: set default value of tsStartUdfd false on windows

---
 source/common/src/tglobal.c              | 6 +++++-
 source/dnode/mgmt/mgmt_dnode/src/dmInt.c | 2 --
 source/dnode/mgmt/mgmt_qnode/src/qmInt.c | 2 --
 source/dnode/mgmt/mgmt_snode/src/smInt.c | 2 --
 source/dnode/mgmt/mgmt_vnode/src/vmInt.c | 2 --
 source/dnode/mgmt/node_mgmt/src/dmEnv.c  | 2 --
 6 files changed, 5 insertions(+), 11 deletions(-)

diff --git a/source/common/src/tglobal.c b/source/common/src/tglobal.c
index a772efc33c..da2917f144 100644
--- a/source/common/src/tglobal.c
+++ b/source/common/src/tglobal.c
@@ -216,7 +216,11 @@ uint32_t tsCurRange = 100;                      // range
 char     tsCompressor[32] = "ZSTD_COMPRESSOR";  // ZSTD_COMPRESSOR or GZIP_COMPRESSOR
 
 // udf
-bool tsStartUdfd = true;
+#ifdef WINDOWS
+bool tsStartUdfd = false;
+#else
+bool    tsStartUdfd = true;
+#endif
 
 // wal
 int64_t tsWalFsyncDataSizeLimit = (100 * 1024 * 1024L);
diff --git a/source/dnode/mgmt/mgmt_dnode/src/dmInt.c b/source/dnode/mgmt/mgmt_dnode/src/dmInt.c
index ae62c74e03..09783a5ea9 100644
--- a/source/dnode/mgmt/mgmt_dnode/src/dmInt.c
+++ b/source/dnode/mgmt/mgmt_dnode/src/dmInt.c
@@ -59,11 +59,9 @@ static int32_t dmOpenMgmt(SMgmtInputOpt *pInput, SMgmtOutputOpt *pOutput) {
     return -1;
   }
 
-#ifndef WINDOWS
   if (udfStartUdfd(pMgmt->pData->dnodeId) != 0) {
     dError("failed to start udfd");
   }
-#endif
 
   pOutput->pMgmt = pMgmt;
   return 0;
diff --git a/source/dnode/mgmt/mgmt_qnode/src/qmInt.c b/source/dnode/mgmt/mgmt_qnode/src/qmInt.c
index 657f15920a..3b425a0b49 100644
--- a/source/dnode/mgmt/mgmt_qnode/src/qmInt.c
+++ b/source/dnode/mgmt/mgmt_qnode/src/qmInt.c
@@ -57,13 +57,11 @@ static int32_t qmOpen(SMgmtInputOpt *pInput, SMgmtOutputOpt *pOutput) {
   }
   tmsgReportStartup("qnode-impl", "initialized");
 
-#ifndef WINDOWS
   if (udfcOpen() != 0) {
     dError("qnode can not open udfc");
     qmClose(pMgmt);
     return -1;
   }
-#endif
 
   if (qmStartWorker(pMgmt) != 0) {
     dError("failed to start qnode worker since %s", terrstr());
diff --git a/source/dnode/mgmt/mgmt_snode/src/smInt.c b/source/dnode/mgmt/mgmt_snode/src/smInt.c
index 58d4b6139b..e222349767 100644
--- a/source/dnode/mgmt/mgmt_snode/src/smInt.c
+++ b/source/dnode/mgmt/mgmt_snode/src/smInt.c
@@ -65,13 +65,11 @@ int32_t smOpen(SMgmtInputOpt *pInput, SMgmtOutputOpt *pOutput) {
   }
   tmsgReportStartup("snode-worker", "initialized");
 
-#ifndef WINDOWS
   if (udfcOpen() != 0) {
     dError("failed to open udfc in snode");
     smClose(pMgmt);
     return -1;
   }
-#endif  
 
   pOutput->pMgmt = pMgmt;
   return 0;
diff --git a/source/dnode/mgmt/mgmt_vnode/src/vmInt.c b/source/dnode/mgmt/mgmt_vnode/src/vmInt.c
index 2dd0130d56..0ff2537e4c 100644
--- a/source/dnode/mgmt/mgmt_vnode/src/vmInt.c
+++ b/source/dnode/mgmt/mgmt_vnode/src/vmInt.c
@@ -571,12 +571,10 @@ static int32_t vmInit(SMgmtInputOpt *pInput, SMgmtOutputOpt *pOutput) {
   }
   tmsgReportStartup("vnode-vnodes", "initialized");
 
-#ifndef WINDOWS
   if (udfcOpen() != 0) {
     dError("failed to open udfc in vnode");
     goto _OVER;
   }
-#endif
 
   code = 0;
 
diff --git a/source/dnode/mgmt/node_mgmt/src/dmEnv.c b/source/dnode/mgmt/node_mgmt/src/dmEnv.c
index f7e429f938..65683e5061 100644
--- a/source/dnode/mgmt/node_mgmt/src/dmEnv.c
+++ b/source/dnode/mgmt/node_mgmt/src/dmEnv.c
@@ -198,10 +198,8 @@ void dmCleanup() {
   monCleanup();
   syncCleanUp();
   walCleanUp();
-#ifndef WINDOWS
   udfcClose(); 
   udfStopUdfd();
-#endif
   taosStopCacheRefreshWorker();
   dmDiskClose();
   dInfo("dnode env is cleaned up");