From b23bcee690b0b4d5f8aed86d9a6a5828b13381ae Mon Sep 17 00:00:00 2001
From: Benguang Zhao <bgzhao@taosdata.com>
Date: Mon, 11 Sep 2023 10:54:28 +0800
Subject: [PATCH] fixup: about to revert this commit

---
 source/dnode/vnode/src/tsdb/tsdbFS2.c | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/source/dnode/vnode/src/tsdb/tsdbFS2.c b/source/dnode/vnode/src/tsdb/tsdbFS2.c
index 78480988cf..b082c450f5 100644
--- a/source/dnode/vnode/src/tsdb/tsdbFS2.c
+++ b/source/dnode/vnode/src/tsdb/tsdbFS2.c
@@ -1026,10 +1026,14 @@ static int32_t tsdbTFSetInsertSnapRange(STFileSet *fset, TSnapRangeArray *snapR)
   TARRAY2_FOREACH(fset->lvlArr, lvl) {
     STFileObj *fobj;
     TARRAY2_FOREACH(lvl->fobjArr, fobj) {
+      // tsdbTFileUpdVerRange(&tf, (SVersionRange){.minVer = fobj->f->minVer, .maxVer = fobj->f->maxVer});
       code = tsdbTFileInsertSnapRange(fobj->f, snapR);
       if (code) return code;
     }
   }
+
+  //  int32_t code = tsdbTFileInsertSnapRange(&tf, snapR);
+  //  if (code) return code;
   return code;
 }
 
@@ -1272,6 +1276,10 @@ int32_t tsdbFSCreateRefRangedSnapshot(STFileSystem *fs, int64_t sver, int64_t ev
   }
 
   int32_t i = 0;
+  code = 0;
+
+  // TODO: use the same fs fSetArr as get snapDiff. The following treatment is potentially wrong
+  //  if the fSetArr are changed.
   taosThreadRwlockRdlock(&fs->tsdb->rwLock);
   TARRAY2_FOREACH(fs->fSetArr, fset) {
     while (i < TARRAY2_SIZE(snapD)) {
@@ -1279,6 +1287,7 @@ int32_t tsdbFSCreateRefRangedSnapshot(STFileSystem *fs, int64_t sver, int64_t ev
       if (fset->fid < u->fid) {
         break;
       } else if (fset->fid > u->fid) {
+        ASSERT(false);
         i++;
         continue;
       } else {
@@ -1289,6 +1298,8 @@ int32_t tsdbFSCreateRefRangedSnapshot(STFileSystem *fs, int64_t sver, int64_t ev
       if (sver1 > ever1) {
         continue;
       }
+      tsdbInfo("fsrArr:%p, fid:%d, sver:%" PRId64 ", ever:%" PRId64, fsrArr, fset->fid, sver1, ever1);
+
       code = tsdbTSnapRangeInitRef(fs->tsdb, fset, sver1, ever1, &fsr1);
       if (code) break;