From b06d16162dbbefa7cbc04493173481bdee977ef8 Mon Sep 17 00:00:00 2001
From: xsren <285808407@qq.com>
Date: Tue, 20 Aug 2024 15:10:58 +0800
Subject: [PATCH] fix: tudf crash

---
 include/util/taoserror.h        | 1 +
 source/libs/function/src/tudf.c | 5 +++++
 source/util/src/terror.c        | 1 +
 3 files changed, 7 insertions(+)

diff --git a/include/util/taoserror.h b/include/util/taoserror.h
index 32e3ba1e43..b772edbf22 100644
--- a/include/util/taoserror.h
+++ b/include/util/taoserror.h
@@ -897,6 +897,7 @@ int32_t  taosGetErrSize();
 #define TSDB_CODE_UDF_SCRIPT_NOT_SUPPORTED      TAOS_DEF_ERROR_CODE(0, 0x2909)
 #define TSDB_CODE_UDF_FUNC_EXEC_FAILURE         TAOS_DEF_ERROR_CODE(0, 0x290A)
 #define TSDB_CODE_UDF_UV_EXEC_FAILURE           TAOS_DEF_ERROR_CODE(0, 0x290B)
+#define TSDB_CODE_UDF_INTERNAL_ERROR            TAOS_DEF_ERROR_CODE(0, 0x2920)
 
 // sml
 #define TSDB_CODE_SML_INVALID_PROTOCOL_TYPE     TAOS_DEF_ERROR_CODE(0, 0x3000)
diff --git a/source/libs/function/src/tudf.c b/source/libs/function/src/tudf.c
index 9a751db801..d5ecf09cee 100644
--- a/source/libs/function/src/tudf.c
+++ b/source/libs/function/src/tudf.c
@@ -796,9 +796,14 @@ void *decodeUdfResponse(const void *buf, SUdfResponse *rsp) {
       buf = decodeUdfTeardownResponse(buf, &rsp->teardownRsp);
       break;
     default:
+      rsp->code =  TSDB_CODE_UDF_INTERNAL_ERROR;
       fnError("decode udf response, invalid udf response type %d", rsp->type);
       break;
   }
+  if(buf == NULL) {
+    rsp->code =  terrno;
+    fnError("decode udf response failed, code:0x%x", rsp->code);
+  }
   return (void *)buf;
 }
 
diff --git a/source/util/src/terror.c b/source/util/src/terror.c
index b627a2aa80..b307c4ac4b 100644
--- a/source/util/src/terror.c
+++ b/source/util/src/terror.c
@@ -742,6 +742,7 @@ TAOS_DEFINE_ERROR(TSDB_CODE_UDF_INVALID_OUTPUT_TYPE,        "udf invalid output
 TAOS_DEFINE_ERROR(TSDB_CODE_UDF_SCRIPT_NOT_SUPPORTED,       "udf program language not supported")
 TAOS_DEFINE_ERROR(TSDB_CODE_UDF_FUNC_EXEC_FAILURE,          "udf function execution failure")
 TAOS_DEFINE_ERROR(TSDB_CODE_UDF_UV_EXEC_FAILURE,            "udf uvlib function execution failure")
+TAOS_DEFINE_ERROR(TSDB_CODE_UDF_INTERNAL_ERROR,             "udf internal error")
 
 //schemaless
 TAOS_DEFINE_ERROR(TSDB_CODE_SML_INVALID_PROTOCOL_TYPE,      "Invalid line protocol type")