From ad7b2ddc1bdb5a41b479d7a59c870b7f34effec7 Mon Sep 17 00:00:00 2001
From: Jing Sima <simondominic9997@outlook.com>
Date: Tue, 24 Sep 2024 09:14:23 +0800
Subject: [PATCH] enh:[TD-32158] Free memory only when function need cleanup.

---
 include/libs/function/function.h             |  1 +
 source/libs/executor/src/aggregateoperator.c | 18 ++++++++++++++++--
 source/libs/executor/src/executil.c          |  1 +
 source/libs/function/src/builtinsimpl.c      |  2 ++
 4 files changed, 20 insertions(+), 2 deletions(-)

diff --git a/include/libs/function/function.h b/include/libs/function/function.h
index a71a2a6b7f..ec01cf1f6f 100644
--- a/include/libs/function/function.h
+++ b/include/libs/function/function.h
@@ -258,6 +258,7 @@ typedef struct SqlFunctionCtx {
   SFuncInputRowIter    rowIter;
   bool                 bInputFinished;
   bool                 hasWindowOrGroup; // denote that the function is used with time window or group
+  bool                 needCleanup; // denote that the function need to be cleaned up
 } SqlFunctionCtx;
 
 typedef struct tExprNode {
diff --git a/source/libs/executor/src/aggregateoperator.c b/source/libs/executor/src/aggregateoperator.c
index c0606a6f29..863ce01256 100644
--- a/source/libs/executor/src/aggregateoperator.c
+++ b/source/libs/executor/src/aggregateoperator.c
@@ -592,9 +592,16 @@ void cleanupResultInfoInStream(SExecTaskInfo* pTaskInfo, void* pState, SExprSupp
   int32_t         numOfExprs = pSup->numOfExprs;
   int32_t*        rowEntryOffset = pSup->rowEntryInfoOffset;
   SqlFunctionCtx* pCtx = pSup->pCtx;
+  int32_t         numOfRows = getNumOfTotalRes(pGroupResInfo);
+  bool            needCleanup = false;
 
-  int32_t numOfRows = getNumOfTotalRes(pGroupResInfo);
-
+  for (int32_t j = 0; j < numOfExprs; ++j) {
+    needCleanup |= pCtx[j].needCleanup;
+  }
+  if (!needCleanup) {
+    return;
+  }
+  
   for (int32_t i = pGroupResInfo->index; i < numOfRows; i += 1) {
     SResultWindowInfo* pWinInfo = taosArrayGet(pGroupResInfo->pRows, i);
     SRowBuffPos*       pPos = pWinInfo->pStatePos;
@@ -620,6 +627,13 @@ void cleanupResultInfo(SExecTaskInfo* pTaskInfo, SExprSupp* pSup, SDiskbasedBuf*
   int32_t         numOfExprs = pSup->numOfExprs;
   int32_t*        rowEntryOffset = pSup->rowEntryInfoOffset;
   SqlFunctionCtx* pCtx = pSup->pCtx;
+  bool            needCleanup = false;
+  for (int32_t j = 0; j < numOfExprs; ++j) {
+    needCleanup |= pCtx[j].needCleanup;
+  }
+  if (!needCleanup) {
+    return;
+  }
 
   // begin from last iter
   void*   pData = pGroupResInfo->dataPos;
diff --git a/source/libs/executor/src/executil.c b/source/libs/executor/src/executil.c
index 117a30ade2..e935b43c00 100644
--- a/source/libs/executor/src/executil.c
+++ b/source/libs/executor/src/executil.c
@@ -2111,6 +2111,7 @@ SqlFunctionCtx* createSqlFunctionCtx(SExprInfo* pExprInfo, int32_t numOfOutput,
     pCtx->saveHandle.currentPage = -1;
     pCtx->pStore = pStore;
     pCtx->hasWindowOrGroup = false;
+    pCtx->needCleanup = false;
   }
 
   for (int32_t i = 1; i < numOfOutput; ++i) {
diff --git a/source/libs/function/src/builtinsimpl.c b/source/libs/function/src/builtinsimpl.c
index 85be33aba8..194b68830b 100644
--- a/source/libs/function/src/builtinsimpl.c
+++ b/source/libs/function/src/builtinsimpl.c
@@ -2114,6 +2114,7 @@ int32_t percentileFunction(SqlFunctionCtx* pCtx) {
     SET_VAL(pResInfo, numOfElems, 1);
   }
 
+  pCtx->needCleanup = true;
   return TSDB_CODE_SUCCESS;
 }
 
@@ -6078,6 +6079,7 @@ int32_t modeFunctionSetup(SqlFunctionCtx* pCtx, SResultRowEntryInfo* pResInfo) {
     pInfo->pHash = NULL;
     return terrno;
   }
+  pCtx->needCleanup = true;
   return TSDB_CODE_SUCCESS;
 }