From acfd94c1231948eaa539ba24edd46e5fc79c07f3 Mon Sep 17 00:00:00 2001
From: Minglei Jin <mljin@taosdata.com>
Date: Wed, 11 Dec 2024 11:39:59 +0800
Subject: [PATCH] tsdb/cache: remove block cache of rocks

---
 source/dnode/vnode/src/inc/tsdb.h       | 1 -
 source/dnode/vnode/src/tsdb/tsdbCache.c | 8 +-------
 2 files changed, 1 insertion(+), 8 deletions(-)

diff --git a/source/dnode/vnode/src/inc/tsdb.h b/source/dnode/vnode/src/inc/tsdb.h
index 17f406e41f..376de64173 100644
--- a/source/dnode/vnode/src/inc/tsdb.h
+++ b/source/dnode/vnode/src/inc/tsdb.h
@@ -336,7 +336,6 @@ struct STsdbFS {
 typedef struct {
   rocksdb_t                           *db;
   rocksdb_comparator_t                *my_comparator;
-  rocksdb_cache_t                     *blockcache;
   rocksdb_block_based_table_options_t *tableoptions;
   rocksdb_options_t                   *options;
   rocksdb_flushoptions_t              *flushoptions;
diff --git a/source/dnode/vnode/src/tsdb/tsdbCache.c b/source/dnode/vnode/src/tsdb/tsdbCache.c
index 2832680e2e..dbc098ed84 100644
--- a/source/dnode/vnode/src/tsdb/tsdbCache.c
+++ b/source/dnode/vnode/src/tsdb/tsdbCache.c
@@ -171,10 +171,7 @@ static int32_t tsdbOpenRocksCache(STsdb *pTsdb) {
   if (NULL == cmp) {
     TAOS_RETURN(TSDB_CODE_OUT_OF_MEMORY);
   }
-  /*
-  rocksdb_cache_t *cache = rocksdb_cache_create_lru(5 * 1024 * 1024);
-  pTsdb->rCache.blockcache = cache;
-  */
+
   rocksdb_block_based_table_options_t *tableoptions = rocksdb_block_based_options_create();
   pTsdb->rCache.tableoptions = tableoptions;
 
@@ -185,7 +182,6 @@ static int32_t tsdbOpenRocksCache(STsdb *pTsdb) {
 
   rocksdb_options_set_create_if_missing(options, 1);
   rocksdb_options_set_comparator(options, cmp);
-  // rocksdb_block_based_options_set_block_cache(tableoptions, cache);
   rocksdb_options_set_block_based_table_factory(options, tableoptions);
   rocksdb_options_set_info_log_level(options, 2);  // WARN_LEVEL
   // rocksdb_options_set_inplace_update_support(options, 1);
@@ -254,7 +250,6 @@ _err3:
 _err2:
   rocksdb_options_destroy(options);
   rocksdb_block_based_options_destroy(tableoptions);
-  // rocksdb_cache_destroy(cache);
 _err:
   rocksdb_comparator_destroy(cmp);
 
@@ -270,7 +265,6 @@ static void tsdbCloseRocksCache(STsdb *pTsdb) {
   rocksdb_writeoptions_destroy(pTsdb->rCache.writeoptions);
   rocksdb_options_destroy(pTsdb->rCache.options);
   rocksdb_block_based_options_destroy(pTsdb->rCache.tableoptions);
-  // rocksdb_cache_destroy(pTsdb->rCache.blockcache);
   rocksdb_comparator_destroy(pTsdb->rCache.my_comparator);
   taosMemoryFree(pTsdb->rCache.pTSchema);
   taosArrayDestroy(pTsdb->rCache.ctxArray);