xxq250
/
homework-jianmu
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Merge pull request #28870 from taosdata/fix/TD-32943/groupbyvalue 

fix: group by value
This commit is contained in:
Shengliang Guan 2024-11-22 13:29:40 +08:00 committed by GitHub
parent e4fd979185 bd9b20d30f
commit a414df1d31
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 38 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
source/libs/parser/src/parCalcConst.c
View File

@ -329,16 +329,22 @@ static int32_t calcConstGroupBy(SCalcConstContext* pCxt, SSelectStmt* pSelect) {
if (TSDB_CODE_SUCCESS == code) {
SNode* pNode = NULL;
FOREACH(pNode, pSelect->pGroupByList) {
bool hasNotValue = false;
SNode* pGroupPara = NULL;
FOREACH(pGroupPara, ((SGroupingSetNode*)pNode)->pParameterList) {
if (QUERY_NODE_VALUE != nodeType(pGroupPara)) {
return code;
hasNotValue = true;
break;
}
}
if (!hasNotValue) {
if (pSelect->hasAggFuncs) {
ERASE_NODE(pSelect->pGroupByList);
} else {
if (!cell->pPrev && !cell->pNext) continue;
ERASE_NODE(pSelect->pGroupByList);
}
}
}
FOREACH(pNode, pSelect->pGroupByList) {
if (!cell->pPrev) continue;
ERASE_NODE(pSelect->pGroupByList);
}
}
return code;

27
tests/system-test/2-query/project_group.py
View File

@ -15,6 +15,30 @@ class TDTestCase:
self.batchNum = 5
self.ts = 1537146000000
def groupby_value(self):
tdSql.query('select 1 from stb group by now')
tdSql.checkRows(1)
tdSql.checkData(0, 0, 1)
tdSql.query('select 1 from stb group by "1"')
tdSql.checkRows(1)
tdSql.checkData(0, 0, 1)
tdSql.query('select count(*) from stb group by now')
tdSql.checkRows(1)
tdSql.checkData(0, 0, 12)
tdSql.query('select count(*) from stb group by now+1')
tdSql.checkRows(1)
tdSql.checkData(0, 0, 12)
tdSql.query('select 1, count(*) from stb group by now, "1"')
tdSql.checkRows(1)
tdSql.checkData(0, 0, 1)
tdSql.checkData(0, 1, 12)
tdSql.query('select count(*) as cc from sta1 as a join sta2 as b on a.ts = b.ts group by now')
tdSql.checkRows(1)
tdSql.checkData(0, 0, 3)
tdSql.query('select a.tbname, count(*) as cc from sta1 as a join sta2 as b on a.ts = b.ts group by a.tbname, "1"')
tdSql.checkRows(1)
tdSql.checkData(0, 1, 3)
def run(self):
dbname = "db"
tdSql.prepare()
@ -59,6 +83,9 @@ class TDTestCase:
tdSql.checkRows(2)
tdSql.query('select col1 > 0 and col2 > 0 from stb')
tdSql.checkRows(12)
self.groupby_value()
def stop(self):
tdSql.close()
tdLog.success("%s successfully executed" % __file__)