From a23e6c2ce9407781e40820b1b321b214dc70c9d6 Mon Sep 17 00:00:00 2001 From: Haojun Liao Date: Sun, 29 Sep 2024 18:43:26 +0800 Subject: [PATCH] fix(stream): handle return value. --- source/dnode/vnode/src/tq/tqStreamTask.c | 17 ++++++++++++----- 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/source/dnode/vnode/src/tq/tqStreamTask.c b/source/dnode/vnode/src/tq/tqStreamTask.c index 10cd53dd30..62cafbbc2e 100644 --- a/source/dnode/vnode/src/tq/tqStreamTask.c +++ b/source/dnode/vnode/src/tq/tqStreamTask.c @@ -73,6 +73,10 @@ int32_t tqScanWal(STQ* pTq) { } static void doStartScanWal(void* param, void* tmrId) { + int32_t vgId = 0; + STQ* pTq = NULL; + int32_t code = 0; + SBuildScanWalMsgParam* pParam = (SBuildScanWalMsgParam*)param; SStreamMeta* pMeta = taosAcquireRef(streamMetaId, pParam->metaId); @@ -82,19 +86,22 @@ static void doStartScanWal(void* param, void* tmrId) { return; } - int32_t vgId = pMeta->vgId; - STQ* pTq = pMeta->ahandle; + vgId = pMeta->vgId; + pTq = pMeta->ahandle; tqDebug("vgId:%d create msg to start wal scan, numOfTasks:%d, vnd restored:%d", vgId, pParam->numOfTasks, pTq->pVnode->restored); - int32_t code = streamTaskSchedTask(&pTq->pVnode->msgCb, vgId, 0, 0, STREAM_EXEC_T_EXTRACT_WAL_DATA); - + code = streamTaskSchedTask(&pTq->pVnode->msgCb, vgId, 0, 0, STREAM_EXEC_T_EXTRACT_WAL_DATA); if (code) { tqError("vgId:%d failed sched task to scan wal, code:%s", vgId, tstrerror(code)); } - taosReleaseRef(streamMetaId, pParam->metaId); + code = taosReleaseRef(streamMetaId, pParam->metaId); + if (code) { + tqError("vgId:% failed to release ref for streamMeta, rid:%" PRId64, vgId, pParam->metaId, tstrerror(code)); + } + taosMemoryFree(pParam); }