xxq250
/
homework-jianmu
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

fix(query)[TD-31955]. Fix memory leak in exceptional scenarios

This commit is contained in:
Jinqing Kuang 2024-09-10 09:00:31 +08:00
parent 99f320b7e0
commit a167815a3a
1 changed files with 8 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
source/util/src/tpagedbuf.c
View File

@ -411,7 +411,7 @@ _error:
return TSDB_CODE_OUT_OF_MEMORY; return TSDB_CODE_OUT_OF_MEMORY;
} }
static char* doExtractPage(SDiskbasedBuf* pBuf, bool* newPage) { static char* doExtractPage(SDiskbasedBuf* pBuf) {
char* availablePage = NULL; char* availablePage = NULL;
if (NO_IN_MEM_AVAILABLE_PAGES(pBuf)) { if (NO_IN_MEM_AVAILABLE_PAGES(pBuf)) {
availablePage = evictBufPage(pBuf); availablePage = evictBufPage(pBuf);
@ -425,7 +425,6 @@ static char* doExtractPage(SDiskbasedBuf* pBuf, bool* newPage) {
if (availablePage == NULL) { if (availablePage == NULL) {
terrno = TSDB_CODE_OUT_OF_MEMORY; terrno = TSDB_CODE_OUT_OF_MEMORY;
} }
*newPage = true;
} }
return availablePage; return availablePage;
@ -434,8 +433,7 @@ static char* doExtractPage(SDiskbasedBuf* pBuf, bool* newPage) {
void* getNewBufPage(SDiskbasedBuf* pBuf, int32_t* pageId) { void* getNewBufPage(SDiskbasedBuf* pBuf, int32_t* pageId) {
pBuf->statis.getPages += 1; pBuf->statis.getPages += 1;
bool newPage = false; char* availablePage = doExtractPage(pBuf);
char* availablePage = doExtractPage(pBuf, &newPage);
if (availablePage == NULL) { if (availablePage == NULL) {
return NULL; return NULL;
} }
@ -451,9 +449,7 @@ void* getNewBufPage(SDiskbasedBuf* pBuf, int32_t* pageId) {
code = lruListPushFront(pBuf->lruList, pi); code = lruListPushFront(pBuf->lruList, pi);
if (TSDB_CODE_SUCCESS != code) { if (TSDB_CODE_SUCCESS != code) {
taosMemoryFree(pi); taosMemoryFree(pi);
if (newPage) { taosMemoryFree(availablePage);
taosMemoryFree(availablePage);
}
terrno = code; terrno = code;
return NULL; return NULL;
} }
@ -464,9 +460,7 @@ void* getNewBufPage(SDiskbasedBuf* pBuf, int32_t* pageId) {
// register page id info // register page id info
pi = registerNewPageInfo(pBuf, *pageId); pi = registerNewPageInfo(pBuf, *pageId);
if (pi == NULL) { if (pi == NULL) {
if (newPage) { taosMemoryFree(availablePage);
taosMemoryFree(availablePage);
}
return NULL; return NULL;
} }
@ -480,7 +474,7 @@ void* getNewBufPage(SDiskbasedBuf* pBuf, int32_t* pageId) {
if (TSDB_CODE_SUCCESS == code) { if (TSDB_CODE_SUCCESS == code) {
pBuf->totalBufSize += pBuf->pageSize; pBuf->totalBufSize += pBuf->pageSize;
} else { } else {
if (newPage) taosMemoryFree(availablePage); taosMemoryFree(availablePage);
(void)taosArrayPop(pBuf->pIdList); (void)taosArrayPop(pBuf->pIdList);
(void)tSimpleHashRemove(pBuf->all, pageId, sizeof(int32_t)); (void)tSimpleHashRemove(pBuf->all, pageId, sizeof(int32_t));
taosMemoryFree(pi); taosMemoryFree(pi);
@ -538,8 +532,7 @@ void* getBufPage(SDiskbasedBuf* pBuf, int32_t id) {
return (void*)(GET_PAYLOAD_DATA(*pi)); return (void*)(GET_PAYLOAD_DATA(*pi));
} else { // not in memory } else { // not in memory
bool newPage = false; (*pi)->pData = doExtractPage(pBuf);
(*pi)->pData = doExtractPage(pBuf, &newPage);
// failed to evict buffer page, return with error code. // failed to evict buffer page, return with error code.
if ((*pi)->pData == NULL) { if ((*pi)->pData == NULL) {
@ -551,7 +544,7 @@ void* getBufPage(SDiskbasedBuf* pBuf, int32_t id) {
int32_t code = lruListPushFront(pBuf->lruList, *pi); int32_t code = lruListPushFront(pBuf->lruList, *pi);
if (TSDB_CODE_SUCCESS != code) { if (TSDB_CODE_SUCCESS != code) {
if (newPage) taosMemoryFree((*pi)->pData); taosMemoryFree((*pi)->pData);
terrno = code; terrno = code;
return NULL; return NULL;
} }
@ -561,9 +554,7 @@ void* getBufPage(SDiskbasedBuf* pBuf, int32_t id) {
if (HAS_DATA_IN_DISK(*pi)) { if (HAS_DATA_IN_DISK(*pi)) {
int32_t code = loadPageFromDisk(pBuf, *pi); int32_t code = loadPageFromDisk(pBuf, *pi);
if (code != 0) { if (code != 0) {
if (newPage) { taosMemoryFree((*pi)->pData);
taosMemoryFree((*pi)->pData);
}
terrno = code; terrno = code;
return NULL; return NULL;