xxq250
/
homework-jianmu
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Merge pull request #29970 from taosdata/enh/TD-33883/errorLog 

fix: error log
This commit is contained in:
Simon Guan 2025-03-03 13:31:40 +08:00 committed by GitHub
parent 851ab1087f 887444669c
commit a0e1599f08
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
5 changed files with 52 additions and 58 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
source/client/src/clientImpl.c
View File

@ -2232,6 +2232,7 @@ static int32_t doConvertJson(SReqResultInfo* pResultInfo) {
int32_t blockVersion = *(int32_t*)p; int32_t blockVersion = *(int32_t*)p;
int32_t dataLen = estimateJsonLen(pResultInfo); int32_t dataLen = estimateJsonLen(pResultInfo);
if (dataLen <= 0) { if (dataLen <= 0) {
tscError("doConvertJson error: estimateJsonLen failed");
return TSDB_CODE_TSC_INTERNAL_ERROR; return TSDB_CODE_TSC_INTERNAL_ERROR;
} }

1
source/client/src/clientMain.c
View File

@ -888,6 +888,7 @@ int taos_select_db(TAOS *taos, const char *db) {
if (db == NULL || strlen(db) == 0) { if (db == NULL || strlen(db) == 0) {
releaseTscObj(*(int64_t *)taos); releaseTscObj(*(int64_t *)taos);
tscError("invalid parameter for %s", db == NULL ? "db is NULL" : "db is empty");
terrno = TSDB_CODE_TSC_INVALID_INPUT; terrno = TSDB_CODE_TSC_INVALID_INPUT;
return terrno; return terrno;
} }

2
source/client/src/clientMsgHandler.c
View File

@ -372,11 +372,13 @@ int32_t processUseDbRsp(void* param, SDataBuf* pMsg, int32_t code) {
int32_t processCreateSTableRsp(void* param, SDataBuf* pMsg, int32_t code) { int32_t processCreateSTableRsp(void* param, SDataBuf* pMsg, int32_t code) {
if (pMsg == NULL) { if (pMsg == NULL) {
tscError("processCreateSTableRsp: invalid input param, pMsg is NULL");
return TSDB_CODE_TSC_INVALID_INPUT; return TSDB_CODE_TSC_INVALID_INPUT;
} }
if (param == NULL) { if (param == NULL) {
taosMemoryFree(pMsg->pEpSet); taosMemoryFree(pMsg->pEpSet);
taosMemoryFree(pMsg->pData); taosMemoryFree(pMsg->pData);
tscError("processCreateSTableRsp: invalid input param, param is NULL");
return TSDB_CODE_TSC_INVALID_INPUT; return TSDB_CODE_TSC_INVALID_INPUT;
} }

105
source/libs/qcom/src/querymsg.c
View File

@ -91,10 +91,8 @@ int32_t queryBuildTableMetaReqMsg(void *input, char **msg, int32_t msgSize, int3
if (NULL == pBuf) { if (NULL == pBuf) {
return terrno; return terrno;
} }
if(tSerializeSTableInfoReq(pBuf, bufLen, &infoReq) < 0) int32_t ret = tSerializeSTableInfoReq(pBuf, bufLen, &infoReq);
{ if (ret < 0) return ret;
return TSDB_CODE_TSC_INVALID_INPUT;
}
*msg = pBuf; *msg = pBuf;
*msgLen = bufLen; *msgLen = bufLen;
@ -121,10 +119,8 @@ int32_t queryBuildUseDbMsg(void *input, char **msg, int32_t msgSize, int32_t *ms
if (NULL == pBuf) { if (NULL == pBuf) {
return terrno; return terrno;
} }
if(tSerializeSUseDbReq(pBuf, bufLen, &usedbReq) < 0) int32_t ret = tSerializeSUseDbReq(pBuf, bufLen, &usedbReq);
{ if (ret < 0) return ret;
return TSDB_CODE_TSC_INVALID_INPUT;
}
*msg = pBuf; *msg = pBuf;
*msgLen = bufLen; *msgLen = bufLen;
@ -144,10 +140,9 @@ int32_t queryBuildQnodeListMsg(void *input, char **msg, int32_t msgSize, int32_t
if (NULL == pBuf) { if (NULL == pBuf) {
return terrno; return terrno;
} }
if(tSerializeSQnodeListReq(pBuf, bufLen, &qnodeListReq) < 0)
{ int32_t ret = tSerializeSQnodeListReq(pBuf, bufLen, &qnodeListReq);
return TSDB_CODE_TSC_INVALID_INPUT; if (ret < 0) return ret;
}
*msg = pBuf; *msg = pBuf;
*msgLen = bufLen; *msgLen = bufLen;
@ -167,10 +162,8 @@ int32_t queryBuildDnodeListMsg(void *input, char **msg, int32_t msgSize, int32_t
if (NULL == pBuf) { if (NULL == pBuf) {
return terrno; return terrno;
} }
if(tSerializeSDnodeListReq(pBuf, bufLen, &dnodeListReq) < 0) int32_t ret = tSerializeSDnodeListReq(pBuf, bufLen, &dnodeListReq);
{ if (ret < 0) return ret;
return TSDB_CODE_TSC_INVALID_INPUT;
}
*msg = pBuf; *msg = pBuf;
*msgLen = bufLen; *msgLen = bufLen;
@ -189,10 +182,8 @@ int32_t queryBuildGetSerVerMsg(void *input, char **msg, int32_t msgSize, int32_t
if (NULL == pBuf) { if (NULL == pBuf) {
return terrno; return terrno;
} }
if(tSerializeSServerVerReq(pBuf, bufLen, &req) < 0) int32_t ret = tSerializeSServerVerReq(pBuf, bufLen, &req);
{ if (ret < 0) return ret;
return TSDB_CODE_TSC_INVALID_INPUT;
}
*msg = pBuf; *msg = pBuf;
*msgLen = bufLen; *msgLen = bufLen;
@ -213,10 +204,8 @@ int32_t queryBuildGetDBCfgMsg(void *input, char **msg, int32_t msgSize, int32_t
if (NULL == pBuf) { if (NULL == pBuf) {
return terrno; return terrno;
} }
if(tSerializeSDbCfgReq(pBuf, bufLen, &dbCfgReq) < 0) int32_t ret = tSerializeSDbCfgReq(pBuf, bufLen, &dbCfgReq);
{ if (ret < 0) return ret;
return TSDB_CODE_TSC_INVALID_INPUT;
}
*msg = pBuf; *msg = pBuf;
*msgLen = bufLen; *msgLen = bufLen;
@ -237,10 +226,8 @@ int32_t queryBuildGetIndexMsg(void *input, char **msg, int32_t msgSize, int32_t
if (NULL == pBuf) { if (NULL == pBuf) {
return terrno; return terrno;
} }
if(tSerializeSUserIndexReq(pBuf, bufLen, &indexReq) < 0) int32_t ret = tSerializeSUserIndexReq(pBuf, bufLen, &indexReq);
{ if (ret < 0) return ret;
return TSDB_CODE_TSC_INVALID_INPUT;
}
*msg = pBuf; *msg = pBuf;
*msgLen = bufLen; *msgLen = bufLen;
@ -272,10 +259,10 @@ int32_t queryBuildRetrieveFuncMsg(void *input, char **msg, int32_t msgSize, int3
taosArrayDestroy(funcReq.pFuncNames); taosArrayDestroy(funcReq.pFuncNames);
return terrno; return terrno;
} }
if(tSerializeSRetrieveFuncReq(pBuf, bufLen, &funcReq) < 0) int32_t ret = tSerializeSRetrieveFuncReq(pBuf, bufLen, &funcReq);
{ if (ret < 0) {
taosArrayDestroy(funcReq.pFuncNames); taosArrayDestroy(funcReq.pFuncNames);
return TSDB_CODE_TSC_INVALID_INPUT; return ret;
} }
taosArrayDestroy(funcReq.pFuncNames); taosArrayDestroy(funcReq.pFuncNames);
@ -299,9 +286,8 @@ int32_t queryBuildGetUserAuthMsg(void *input, char **msg, int32_t msgSize, int32
if (NULL == pBuf) { if (NULL == pBuf) {
return terrno; return terrno;
} }
if (tSerializeSGetUserAuthReq(pBuf, bufLen, &req) < 0) { int32_t ret = tSerializeSGetUserAuthReq(pBuf, bufLen, &req);
return TSDB_CODE_TSC_INVALID_INPUT; if (ret < 0) return ret;
}
*msg = pBuf; *msg = pBuf;
*msgLen = bufLen; *msgLen = bufLen;
@ -322,10 +308,8 @@ int32_t queryBuildGetTbIndexMsg(void *input, char **msg, int32_t msgSize, int32_
if (NULL == pBuf) { if (NULL == pBuf) {
return terrno; return terrno;
} }
if(tSerializeSTableIndexReq(pBuf, bufLen, &indexReq) < 0) int32_t ret = tSerializeSTableIndexReq(pBuf, bufLen, &indexReq);
{ if (ret < 0) return ret;
return TSDB_CODE_TSC_INVALID_INPUT;
}
*msg = pBuf; *msg = pBuf;
*msgLen = bufLen; *msgLen = bufLen;
@ -349,10 +333,8 @@ int32_t queryBuildGetTbCfgMsg(void *input, char **msg, int32_t msgSize, int32_t
if (NULL == pBuf) { if (NULL == pBuf) {
return terrno; return terrno;
} }
if(tSerializeSTableCfgReq(pBuf, bufLen, &cfgReq) < 0) int32_t ret = tSerializeSTableCfgReq(pBuf, bufLen, &cfgReq);
{ if (ret < 0) return ret;
return TSDB_CODE_TSC_INVALID_INPUT;
}
*msg = pBuf; *msg = pBuf;
*msgLen = bufLen; *msgLen = bufLen;
@ -373,10 +355,8 @@ int32_t queryBuildGetViewMetaMsg(void *input, char **msg, int32_t msgSize, int32
if (NULL == pBuf) { if (NULL == pBuf) {
return terrno; return terrno;
} }
if(tSerializeSViewMetaReq(pBuf, bufLen, &req) < 0) int32_t ret = tSerializeSViewMetaReq(pBuf, bufLen, &req);
{ if (ret < 0) return ret;
return TSDB_CODE_TSC_INVALID_INPUT;
}
*msg = pBuf; *msg = pBuf;
*msgLen = bufLen; *msgLen = bufLen;
@ -398,10 +378,8 @@ int32_t queryBuildGetTableTSMAMsg(void *input, char **msg, int32_t msgSize, int3
if (NULL == pBuf) { if (NULL == pBuf) {
return terrno; return terrno;
} }
if(tSerializeTableTSMAInfoReq(pBuf, bufLen, &req) < 0) int32_t ret = tSerializeTableTSMAInfoReq(pBuf, bufLen, &req);
{ if (ret < 0) return ret;
return TSDB_CODE_TSC_INVALID_INPUT;
}
*msg = pBuf; *msg = pBuf;
*msgLen = bufLen; *msgLen = bufLen;
@ -424,10 +402,8 @@ int32_t queryBuildGetTSMAMsg(void *input, char **msg, int32_t msgSize, int32_t *
{ {
return terrno; return terrno;
} }
if(tSerializeTableTSMAInfoReq(pBuf, bufLen, &req) < 0) int32_t ret = tSerializeTableTSMAInfoReq(pBuf, bufLen, &req);
{ if(ret < 0) return ret;
return TSDB_CODE_TSC_INVALID_INPUT;
}
*msg = pBuf; *msg = pBuf;
*msgLen = bufLen; *msgLen = bufLen;
@ -445,10 +421,8 @@ int32_t queryBuildGetStreamProgressMsg(void* input, char** msg, int32_t msgSize,
return terrno; return terrno;
} }
if(tSerializeStreamProgressReq(pBuf, len, input) < 0) int32_t ret = tSerializeStreamProgressReq(pBuf, len, input);
{ if (ret < 0) return ret;
return TSDB_CODE_TSC_INVALID_INPUT;
}
*msg = pBuf; *msg = pBuf;
*msgLen = len; *msgLen = len;
@ -462,6 +436,7 @@ int32_t queryProcessUseDBRsp(void *output, char *msg, int32_t msgSize) {
if (NULL == output || NULL == msg || msgSize <= 0) { if (NULL == output || NULL == msg || msgSize <= 0) {
code = TSDB_CODE_TSC_INVALID_INPUT; code = TSDB_CODE_TSC_INVALID_INPUT;
qError("invalid input param, output:%p, msg:%p, msgSize:%d", output, msg, msgSize);
goto PROCESS_USEDB_OVER; goto PROCESS_USEDB_OVER;
} }
@ -673,6 +648,7 @@ int32_t queryProcessTableMetaRsp(void *output, char *msg, int32_t msgSize) {
STableMetaRsp metaRsp = {0}; STableMetaRsp metaRsp = {0};
if (NULL == output || NULL == msg || msgSize <= 0) { if (NULL == output || NULL == msg || msgSize <= 0) {
qError("queryProcessTableMetaRsp: invalid input param, output:%p, msg:%p, msgSize:%d", output, msg, msgSize);
code = TSDB_CODE_TSC_INVALID_INPUT; code = TSDB_CODE_TSC_INVALID_INPUT;
goto PROCESS_META_OVER; goto PROCESS_META_OVER;
} }
@ -729,6 +705,7 @@ static int32_t queryProcessTableNameRsp(void *output, char *msg, int32_t msgSize
STableMetaRsp metaRsp = {0}; STableMetaRsp metaRsp = {0};
if (NULL == output || NULL == msg || msgSize <= 0) { if (NULL == output || NULL == msg || msgSize <= 0) {
qError("queryProcessTableNameRsp: invalid input param, output:%p, msg:%p, msgSize:%d", output, msg, msgSize);
code = TSDB_CODE_TSC_INVALID_INPUT; code = TSDB_CODE_TSC_INVALID_INPUT;
goto PROCESS_NAME_OVER; goto PROCESS_NAME_OVER;
} }
@ -785,6 +762,7 @@ int32_t queryProcessQnodeListRsp(void *output, char *msg, int32_t msgSize) {
int32_t code = 0; int32_t code = 0;
if (NULL == output || NULL == msg || msgSize <= 0) { if (NULL == output || NULL == msg || msgSize <= 0) {
qError("queryProcessQnodeListRsp: invalid input param, output:%p, msg:%p, msgSize:%d", output, msg, msgSize);
code = TSDB_CODE_TSC_INVALID_INPUT; code = TSDB_CODE_TSC_INVALID_INPUT;
return code; return code;
} }
@ -804,6 +782,7 @@ int32_t queryProcessDnodeListRsp(void *output, char *msg, int32_t msgSize) {
int32_t code = 0; int32_t code = 0;
if (NULL == output || NULL == msg || msgSize <= 0) { if (NULL == output || NULL == msg || msgSize <= 0) {
qError("queryProcessDnodeListRsp: invalid input param, output:%p, msg:%p, msgSize:%d", output, msg, msgSize);
code = TSDB_CODE_TSC_INVALID_INPUT; code = TSDB_CODE_TSC_INVALID_INPUT;
return code; return code;
} }
@ -824,6 +803,7 @@ int32_t queryProcessGetSerVerRsp(void *output, char *msg, int32_t msgSize) {
int32_t code = 0; int32_t code = 0;
if (NULL == output || NULL == msg || msgSize <= 0) { if (NULL == output || NULL == msg || msgSize <= 0) {
qError("queryProcessGetSerVerRsp: invalid input param, output:%p, msg:%p, msgSize:%d", output, msg, msgSize);
code = TSDB_CODE_TSC_INVALID_INPUT; code = TSDB_CODE_TSC_INVALID_INPUT;
return code; return code;
} }
@ -846,6 +826,7 @@ int32_t queryProcessGetDbCfgRsp(void *output, char *msg, int32_t msgSize) {
SDbCfgRsp out = {0}; SDbCfgRsp out = {0};
if (NULL == output || NULL == msg || msgSize <= 0) { if (NULL == output || NULL == msg || msgSize <= 0) {
qError("queryProcessGetDbCfgRsp: invalid input param, output:%p, msg:%p, msgSize:%d", output, msg, msgSize);
return TSDB_CODE_TSC_INVALID_INPUT; return TSDB_CODE_TSC_INVALID_INPUT;
} }
@ -863,6 +844,7 @@ int32_t queryProcessGetIndexRsp(void *output, char *msg, int32_t msgSize) {
SUserIndexRsp out = {0}; SUserIndexRsp out = {0};
if (NULL == output || NULL == msg || msgSize <= 0) { if (NULL == output || NULL == msg || msgSize <= 0) {
qError("queryProcessGetIndexRsp: invalid input param, output:%p, msg:%p, msgSize:%d", output, msg, msgSize);
return TSDB_CODE_TSC_INVALID_INPUT; return TSDB_CODE_TSC_INVALID_INPUT;
} }
@ -880,6 +862,7 @@ int32_t queryProcessRetrieveFuncRsp(void *output, char *msg, int32_t msgSize) {
SRetrieveFuncRsp out = {0}; SRetrieveFuncRsp out = {0};
if (NULL == output || NULL == msg || msgSize <= 0) { if (NULL == output || NULL == msg || msgSize <= 0) {
qError("queryProcessRetrieveFuncRsp: invalid input param, output:%p, msg:%p, msgSize:%d", output, msg, msgSize);
return TSDB_CODE_TSC_INVALID_INPUT; return TSDB_CODE_TSC_INVALID_INPUT;
} }
@ -904,6 +887,7 @@ int32_t queryProcessRetrieveFuncRsp(void *output, char *msg, int32_t msgSize) {
int32_t queryProcessGetUserAuthRsp(void *output, char *msg, int32_t msgSize) { int32_t queryProcessGetUserAuthRsp(void *output, char *msg, int32_t msgSize) {
if (NULL == output || NULL == msg || msgSize <= 0) { if (NULL == output || NULL == msg || msgSize <= 0) {
qError("queryProcessGetUserAuthRsp: invalid input param, output:%p, msg:%p, msgSize:%d", output, msg, msgSize);
return TSDB_CODE_TSC_INVALID_INPUT; return TSDB_CODE_TSC_INVALID_INPUT;
} }
@ -917,6 +901,7 @@ int32_t queryProcessGetUserAuthRsp(void *output, char *msg, int32_t msgSize) {
int32_t queryProcessGetTbIndexRsp(void *output, char *msg, int32_t msgSize) { int32_t queryProcessGetTbIndexRsp(void *output, char *msg, int32_t msgSize) {
if (NULL == output || NULL == msg || msgSize <= 0) { if (NULL == output || NULL == msg || msgSize <= 0) {
qError("queryProcessGetTbIndexRsp: invalid input param, output:%p, msg:%p, msgSize:%d", output, msg, msgSize);
return TSDB_CODE_TSC_INVALID_INPUT; return TSDB_CODE_TSC_INVALID_INPUT;
} }
@ -931,6 +916,7 @@ int32_t queryProcessGetTbIndexRsp(void *output, char *msg, int32_t msgSize) {
int32_t queryProcessGetTbCfgRsp(void *output, char *msg, int32_t msgSize) { int32_t queryProcessGetTbCfgRsp(void *output, char *msg, int32_t msgSize) {
if (NULL == output || NULL == msg || msgSize <= 0) { if (NULL == output || NULL == msg || msgSize <= 0) {
qError("queryProcessGetTbCfgRsp: invalid input param, output:%p, msg:%p, msgSize:%d", output, msg, msgSize);
return TSDB_CODE_TSC_INVALID_INPUT; return TSDB_CODE_TSC_INVALID_INPUT;
} }
@ -952,6 +938,7 @@ int32_t queryProcessGetTbCfgRsp(void *output, char *msg, int32_t msgSize) {
int32_t queryProcessGetViewMetaRsp(void *output, char *msg, int32_t msgSize) { int32_t queryProcessGetViewMetaRsp(void *output, char *msg, int32_t msgSize) {
if (NULL == output || NULL == msg || msgSize <= 0) { if (NULL == output || NULL == msg || msgSize <= 0) {
qError("queryProcessGetViewMetaRsp: invalid input param, output:%p, msg:%p, msgSize:%d", output, msg, msgSize);
return TSDB_CODE_TSC_INVALID_INPUT; return TSDB_CODE_TSC_INVALID_INPUT;
} }
@ -975,6 +962,7 @@ int32_t queryProcessGetViewMetaRsp(void *output, char *msg, int32_t msgSize) {
int32_t queryProcessGetTbTSMARsp(void* output, char* msg, int32_t msgSize) { int32_t queryProcessGetTbTSMARsp(void* output, char* msg, int32_t msgSize) {
if (NULL == output || NULL == msg || msgSize <= 0) { if (NULL == output || NULL == msg || msgSize <= 0) {
qError("queryProcessGetTbTSMARsp: invalid input param, output:%p, msg:%p, msgSize:%d", output, msg, msgSize);
return TSDB_CODE_TSC_INVALID_INPUT; return TSDB_CODE_TSC_INVALID_INPUT;
} }
@ -988,6 +976,7 @@ int32_t queryProcessGetTbTSMARsp(void* output, char* msg, int32_t msgSize) {
int32_t queryProcessStreamProgressRsp(void* output, char* msg, int32_t msgSize) { int32_t queryProcessStreamProgressRsp(void* output, char* msg, int32_t msgSize) {
if (!output || !msg || msgSize <= 0) { if (!output || !msg || msgSize <= 0) {
qError("queryProcessStreamProgressRsp: invalid input param, output:%p, msg:%p, msgSize:%d", output, msg, msgSize);
return TSDB_CODE_TSC_INVALID_INPUT; return TSDB_CODE_TSC_INVALID_INPUT;
} }

1
source/libs/scheduler/src/scheduler.c
View File

@ -148,6 +148,7 @@ int32_t schedulerUpdatePolicy(int32_t policy) {
qDebug("schedule policy updated to %d", schMgmt.cfg.schPolicy); qDebug("schedule policy updated to %d", schMgmt.cfg.schPolicy);
break; break;
default: default:
qError("invalid schedule policy %d", policy);
SCH_RET(TSDB_CODE_TSC_INVALID_INPUT); SCH_RET(TSDB_CODE_TSC_INVALID_INPUT);
} }