Merge pull request #19939 from taosdata/feat/TD-22067-MAIN

fix: first run use dbname auto fill alter fixed
This commit is contained in:
Hui Li 2023-02-13 09:05:17 +08:00 committed by GitHub
commit 9d002d7aff
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 42 additions and 29 deletions

View File

@ -33,6 +33,7 @@ void shellInsertChar(SShellCmd* cmd, char* c, int size);
void shellInsertStr(SShellCmd* cmd, char* str, int size); void shellInsertStr(SShellCmd* cmd, char* str, int size);
bool appendAfterSelect(TAOS* con, SShellCmd* cmd, char* p, int32_t len); bool appendAfterSelect(TAOS* con, SShellCmd* cmd, char* p, int32_t len);
char* tireSearchWord(int type, char* pre); char* tireSearchWord(int type, char* pre);
bool updateTireValue(int type, bool autoFill) ;
typedef struct SAutoPtr { typedef struct SAutoPtr {
STire* p; STire* p;
@ -639,7 +640,7 @@ bool shellAutoInit() {
void shellSetConn(TAOS* conn) { void shellSetConn(TAOS* conn) {
varCon = conn; varCon = conn;
// init database and stable // init database and stable
tireSearchWord(WT_VAR_DBNAME, ""); updateTireValue(WT_VAR_DBNAME, false);
} }
// exit shell auto funciton, shell exit call once // exit shell auto funciton, shell exit call once
@ -816,6 +817,38 @@ void* varObtainThread(void* param) {
return NULL; return NULL;
} }
// return true is need update value by async
bool updateTireValue(int type, bool autoFill) {
// TYPE CONTEXT GET FROM DB
taosThreadMutexLock(&tiresMutex);
// check need obtain from server
if (tires[type] == NULL) {
waitAutoFill = autoFill;
// need async obtain var names from db sever
if (threads[type] != NULL) {
if (taosThreadRunning(threads[type])) {
// thread running , need not obtain again, return
taosThreadMutexUnlock(&tiresMutex);
return NULL;
}
// destroy previous thread handle for new create thread handle
taosDestroyThread(threads[type]);
threads[type] = NULL;
}
// create new
void* param = taosMemoryMalloc(sizeof(int));
*((int*)param) = type;
threads[type] = taosCreateThread(varObtainThread, param);
taosThreadMutexUnlock(&tiresMutex);
return true;
}
taosThreadMutexUnlock(&tiresMutex);
return false;
}
// only match next one word from all match words, return valuue must free by caller // only match next one word from all match words, return valuue must free by caller
char* matchNextPrefix(STire* tire, char* pre) { char* matchNextPrefix(STire* tire, char* pre) {
SMatch* match = NULL; SMatch* match = NULL;
@ -905,32 +938,9 @@ char* tireSearchWord(int type, char* pre) {
return matchNextPrefix(tire, pre); return matchNextPrefix(tire, pre);
} }
// TYPE CONTEXT GET FROM DB if(updateTireValue(type, true)) {
taosThreadMutexLock(&tiresMutex);
// check need obtain from server
if (tires[type] == NULL) {
waitAutoFill = true;
// need async obtain var names from db sever
if (threads[type] != NULL) {
if (taosThreadRunning(threads[type])) {
// thread running , need not obtain again, return
taosThreadMutexUnlock(&tiresMutex);
return NULL;
}
// destroy previous thread handle for new create thread handle
taosDestroyThread(threads[type]);
threads[type] = NULL;
}
// create new
void* param = taosMemoryMalloc(sizeof(int));
*((int*)param) = type;
threads[type] = taosCreateThread(varObtainThread, param);
taosThreadMutexUnlock(&tiresMutex);
return NULL; return NULL;
} }
taosThreadMutexUnlock(&tiresMutex);
// can obtain var names from local // can obtain var names from local
STire* tire = getAutoPtr(type); STire* tire = getAutoPtr(type);
@ -1695,9 +1705,12 @@ bool matchEnd(TAOS* con, SShellCmd* cmd) {
} }
// match database // match database
if (fillWithType(con, cmd, last, WT_VAR_DBNAME)) { if(elast == NULL) {
ret = true; // dot need not completed with dbname
goto _return; if (fillWithType(con, cmd, last, WT_VAR_DBNAME)) {
ret = true;
goto _return;
}
} }
if (fillWithType(con, cmd, last, WT_VAR_SYSTABLE)) { if (fillWithType(con, cmd, last, WT_VAR_SYSTABLE)) {
@ -1964,7 +1977,7 @@ void callbackAutoTab(char* sqlstr, TAOS* pSql, bool usedb) {
if (dealUseDB(sql)) { if (dealUseDB(sql)) {
// change to new db // change to new db
tireSearchWord(WT_VAR_STABLE, ""); updateTireValue(WT_VAR_STABLE, false);
return; return;
} }