From 2dcec8304a9f93746ed2370e724c238641a61429 Mon Sep 17 00:00:00 2001 From: chenhaoran Date: Tue, 23 Jan 2024 11:35:13 +0800 Subject: [PATCH 1/8] test:add special compatibility testcase for code coverage --- tests/pytest/util/common.py | 58 +++++++++---------- .../0-others/compatibility_coverage.py | 2 +- .../6-cluster/clusterCommonCreate.py | 3 + 3 files changed, 33 insertions(+), 30 deletions(-) diff --git a/tests/pytest/util/common.py b/tests/pytest/util/common.py index c4885747d1..cb649d966f 100644 --- a/tests/pytest/util/common.py +++ b/tests/pytest/util/common.py @@ -1862,38 +1862,38 @@ class TDCom: time.sleep(1) return tbname -def is_json(msg): - if isinstance(msg, str): - try: - json.loads(msg) - return True - except: + def is_json(msg): + if isinstance(msg, str): + try: + json.loads(msg) + return True + except: + return False + else: return False - else: - return False -def get_path(tool="taosd"): - selfPath = os.path.dirname(os.path.realpath(__file__)) - if ("community" in selfPath): - projPath = selfPath[:selfPath.find("community")] - else: - projPath = selfPath[:selfPath.find("tests")] + def get_path(tool="taosd"): + selfPath = os.path.dirname(os.path.realpath(__file__)) + if ("community" in selfPath): + projPath = selfPath[:selfPath.find("community")] + else: + projPath = selfPath[:selfPath.find("tests")] - paths = [] - for root, dirs, files in os.walk(projPath): - if ((tool) in files or ("%s.exe"%tool) in files): - rootRealPath = os.path.dirname(os.path.realpath(root)) - if ("packaging" not in rootRealPath): - paths.append(os.path.join(root, tool)) - break - if (len(paths) == 0): + paths = [] + for root, dirs, files in os.walk(projPath): + if ((tool) in files or ("%s.exe"%tool) in files): + rootRealPath = os.path.dirname(os.path.realpath(root)) + if ("packaging" not in rootRealPath): + paths.append(os.path.join(root, tool)) + break + if (len(paths) == 0): + return "" + return paths[0] + + def dict2toml(in_dict: dict, file:str): + if not isinstance(in_dict, dict): return "" - return paths[0] - -def dict2toml(in_dict: dict, file:str): - if not isinstance(in_dict, dict): - return "" - with open(file, 'w') as f: - toml.dump(in_dict, f) + with open(file, 'w') as f: + toml.dump(in_dict, f) tdCom = TDCom() diff --git a/tests/system-test/0-others/compatibility_coverage.py b/tests/system-test/0-others/compatibility_coverage.py index 7a123739f7..6eccf78c5a 100644 --- a/tests/system-test/0-others/compatibility_coverage.py +++ b/tests/system-test/0-others/compatibility_coverage.py @@ -152,7 +152,7 @@ class TDTestCase: os.system(f"rm -rf {cPath}/../data") print(self.projPath) # this data file is special for coverage test in 192.168.1.96 - os.system("cp -r f{self.projPath}/../comp_testdata/data/ {self.projPath}/sim/dnode1") + os.system(f"cp -r {self.projPath}/../comp_testdata/data/ {self.projPath}/community/sim/dnode1") tdDnodes.stop(1) tdDnodes.start(1) diff --git a/tests/system-test/6-cluster/clusterCommonCreate.py b/tests/system-test/6-cluster/clusterCommonCreate.py index a06c1233d8..cb44710b58 100644 --- a/tests/system-test/6-cluster/clusterCommonCreate.py +++ b/tests/system-test/6-cluster/clusterCommonCreate.py @@ -215,7 +215,10 @@ class ClusterComCreate: return def alterStbMetaData(self,tsql,dbName,stbName,ctbNum,rowsPerTbl,batchNum,startTs=None): + tdLog.debug("alter Stb column ............") + tdLog.debug(f"describe STABLE {dbName}.{stbName} ") + tsql.execute(f"describe STABLE {dbName}.{stbName} ;") tdLog.debug(f"ALTER STABLE {dbName}.{stbName} MODIFY COLUMN c3 binary(20);") tsql.execute(f" ALTER STABLE {dbName}.{stbName} MODIFY COLUMN c3 binary(20);") tdLog.debug(f"ALTER STABLE {dbName}.{stbName} ADD COLUMN c4 DOUBLE;") From f1b606c73002bd361051757ae02ce61339fad2da Mon Sep 17 00:00:00 2001 From: chenhaoran Date: Tue, 23 Jan 2024 16:01:31 +0800 Subject: [PATCH 2/8] test:add special compatibility testcase for code coverage --- tests/pytest/util/common.py | 58 ++++++++++++++++++------------------- 1 file changed, 29 insertions(+), 29 deletions(-) diff --git a/tests/pytest/util/common.py b/tests/pytest/util/common.py index cb649d966f..c4885747d1 100644 --- a/tests/pytest/util/common.py +++ b/tests/pytest/util/common.py @@ -1862,38 +1862,38 @@ class TDCom: time.sleep(1) return tbname - def is_json(msg): - if isinstance(msg, str): - try: - json.loads(msg) - return True - except: - return False - else: +def is_json(msg): + if isinstance(msg, str): + try: + json.loads(msg) + return True + except: return False + else: + return False - def get_path(tool="taosd"): - selfPath = os.path.dirname(os.path.realpath(__file__)) - if ("community" in selfPath): - projPath = selfPath[:selfPath.find("community")] - else: - projPath = selfPath[:selfPath.find("tests")] +def get_path(tool="taosd"): + selfPath = os.path.dirname(os.path.realpath(__file__)) + if ("community" in selfPath): + projPath = selfPath[:selfPath.find("community")] + else: + projPath = selfPath[:selfPath.find("tests")] - paths = [] - for root, dirs, files in os.walk(projPath): - if ((tool) in files or ("%s.exe"%tool) in files): - rootRealPath = os.path.dirname(os.path.realpath(root)) - if ("packaging" not in rootRealPath): - paths.append(os.path.join(root, tool)) - break - if (len(paths) == 0): - return "" - return paths[0] - - def dict2toml(in_dict: dict, file:str): - if not isinstance(in_dict, dict): + paths = [] + for root, dirs, files in os.walk(projPath): + if ((tool) in files or ("%s.exe"%tool) in files): + rootRealPath = os.path.dirname(os.path.realpath(root)) + if ("packaging" not in rootRealPath): + paths.append(os.path.join(root, tool)) + break + if (len(paths) == 0): return "" - with open(file, 'w') as f: - toml.dump(in_dict, f) + return paths[0] + +def dict2toml(in_dict: dict, file:str): + if not isinstance(in_dict, dict): + return "" + with open(file, 'w') as f: + toml.dump(in_dict, f) tdCom = TDCom() From 408212949f535cb90cf41dbafd82b8ec3c4553e0 Mon Sep 17 00:00:00 2001 From: chenhaoran Date: Tue, 23 Jan 2024 18:21:10 +0800 Subject: [PATCH 3/8] test:add special compatibility testcase for code coverage --- tests/system-test/6-cluster/clusterCommonCreate.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/system-test/6-cluster/clusterCommonCreate.py b/tests/system-test/6-cluster/clusterCommonCreate.py index cb44710b58..cb8a9bc9e2 100644 --- a/tests/system-test/6-cluster/clusterCommonCreate.py +++ b/tests/system-test/6-cluster/clusterCommonCreate.py @@ -217,8 +217,8 @@ class ClusterComCreate: def alterStbMetaData(self,tsql,dbName,stbName,ctbNum,rowsPerTbl,batchNum,startTs=None): tdLog.debug("alter Stb column ............") - tdLog.debug(f"describe STABLE {dbName}.{stbName} ") - tsql.execute(f"describe STABLE {dbName}.{stbName} ;") + tdLog.debug(f"describe {dbName}.{stbName} ") + tsql.execute(f"describe {dbName}.{stbName} ;") tdLog.debug(f"ALTER STABLE {dbName}.{stbName} MODIFY COLUMN c3 binary(20);") tsql.execute(f" ALTER STABLE {dbName}.{stbName} MODIFY COLUMN c3 binary(20);") tdLog.debug(f"ALTER STABLE {dbName}.{stbName} ADD COLUMN c4 DOUBLE;") From 262bb4cf127fb71e1bebd4502f4721f97f3efe34 Mon Sep 17 00:00:00 2001 From: dmchen Date: Wed, 24 Jan 2024 02:30:03 +0000 Subject: [PATCH 4/8] fix/TD-28437 --- source/dnode/mnode/impl/src/mndDump.c | 1 + 1 file changed, 1 insertion(+) diff --git a/source/dnode/mnode/impl/src/mndDump.c b/source/dnode/mnode/impl/src/mndDump.c index c68b11d184..00e72fb329 100644 --- a/source/dnode/mnode/impl/src/mndDump.c +++ b/source/dnode/mnode/impl/src/mndDump.c @@ -545,6 +545,7 @@ void dumpHeader(SSdb *pSdb, SJson *json) { SJson *maxIdsJson = tjsonCreateObject(); tjsonAddItemToObject(json, "maxIds", maxIdsJson); for (int32_t i = 0; i < SDB_MAX; ++i) { + if(i == 5) continue; int64_t maxId = 0; if (i < SDB_MAX) { maxId = pSdb->maxId[i]; From 22225d31c361e8a3cc43ced4502c61d4bedda98d Mon Sep 17 00:00:00 2001 From: wangmm0220 Date: Wed, 24 Jan 2024 10:39:22 +0800 Subject: [PATCH 5/8] fix:[TD-28025]return 0 if create table failed if stable not exist --- source/client/src/clientRawBlockWrite.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/source/client/src/clientRawBlockWrite.c b/source/client/src/clientRawBlockWrite.c index db8de44f1c..739224be38 100644 --- a/source/client/src/clientRawBlockWrite.c +++ b/source/client/src/clientRawBlockWrite.c @@ -966,6 +966,12 @@ static int32_t taosCreateTable(TAOS* taos, void* meta, int32_t metaLen) { // pCreateReq->ctb.suid = processSuid(pCreateReq->ctb.suid, pRequest->pDb); toName(pTscObj->acctId, pRequest->pDb, pCreateReq->ctb.stbName, &sName); code = catalogGetTableMeta(pCatalog, &conn, &sName, &pTableMeta); + if (code == TSDB_CODE_PAR_TABLE_NOT_EXIST) { + code = TSDB_CODE_SUCCESS; + taosMemoryFreeClear(pTableMeta); + continue; + } + if (code != TSDB_CODE_SUCCESS) { goto end; } From 6e09164c3ae88f2104ab16f244e3e0a0bbdd0dec Mon Sep 17 00:00:00 2001 From: wangmm0220 Date: Wed, 24 Jan 2024 11:38:17 +0800 Subject: [PATCH 6/8] fix:[TD-28025]return 0 if create table failed if stable not exist --- source/client/src/clientRawBlockWrite.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/source/client/src/clientRawBlockWrite.c b/source/client/src/clientRawBlockWrite.c index 739224be38..b0739b463f 100644 --- a/source/client/src/clientRawBlockWrite.c +++ b/source/client/src/clientRawBlockWrite.c @@ -955,7 +955,6 @@ static int32_t taosCreateTable(TAOS* taos, void* meta, int32_t metaLen) { if (code != TSDB_CODE_SUCCESS) { goto end; } - taosArrayPush(pRequest->tableList, &pName); pCreateReq->flags |= TD_CREATE_IF_NOT_EXISTS; // change tag cid to new cid @@ -989,6 +988,7 @@ static int32_t taosCreateTable(TAOS* taos, void* meta, int32_t metaLen) { } taosMemoryFreeClear(pTableMeta); } + taosArrayPush(pRequest->tableList, &pName); SVgroupCreateTableBatch* pTableBatch = taosHashGet(pVgroupHashmap, &pInfo.vgId, sizeof(pInfo.vgId)); if (pTableBatch == NULL) { From 7d3aa6974050d3fd8e1ea2aaf8e1e36c528b5946 Mon Sep 17 00:00:00 2001 From: wangmm0220 Date: Wed, 24 Jan 2024 14:02:07 +0800 Subject: [PATCH 7/8] fix:[TD-28025]return 0 if create table failed if stable not exist --- source/client/src/clientRawBlockWrite.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/source/client/src/clientRawBlockWrite.c b/source/client/src/clientRawBlockWrite.c index b0739b463f..1ea3eaf219 100644 --- a/source/client/src/clientRawBlockWrite.c +++ b/source/client/src/clientRawBlockWrite.c @@ -1005,6 +1005,9 @@ static int32_t taosCreateTable(TAOS* taos, void* meta, int32_t metaLen) { } } + if (taosHashGetSize(pVgroupHashmap) == 0) { + goto end; + } SArray* pBufArray = serializeVgroupsCreateTableBatch(pVgroupHashmap); if (NULL == pBufArray) { code = TSDB_CODE_OUT_OF_MEMORY; From dc6ee3e1a0519c3db4926d8f5ec13a8020da2bcb Mon Sep 17 00:00:00 2001 From: factosea <285808407@qq.com> Date: Wed, 24 Jan 2024 19:34:54 +0800 Subject: [PATCH 8/8] fix: daylight --- source/os/src/osTimezone.c | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/source/os/src/osTimezone.c b/source/os/src/osTimezone.c index 4280490c68..72f7dda41c 100644 --- a/source/os/src/osTimezone.c +++ b/source/os/src/osTimezone.c @@ -740,6 +740,8 @@ char *tz_win[554][2] = {{"Asia/Shanghai", "China Standard Time"}, #include #endif +static int isdst_now = 0; + void taosSetSystemTimezone(const char *inTimezoneStr, char *outTimezoneStr, int8_t *outDaylight, enum TdTimezone *tsTimezone) { if (inTimezoneStr == NULL || inTimezoneStr[0] == 0) return; @@ -805,19 +807,19 @@ void taosSetSystemTimezone(const char *inTimezoneStr, char *outTimezoneStr, int8 tzset(); int32_t tz = (int32_t)((-timezone * MILLISECOND_PER_SECOND) / MILLISECOND_PER_HOUR); *tsTimezone = tz; - tz += daylight; + tz += isdst_now; - sprintf(outTimezoneStr, "%s (%s, %s%02d00)", buf, tzname[daylight], tz >= 0 ? "+" : "-", abs(tz)); - *outDaylight = daylight; + sprintf(outTimezoneStr, "%s (%s, %s%02d00)", buf, tzname[isdst_now], tz >= 0 ? "+" : "-", abs(tz)); + *outDaylight = isdst_now; #else setenv("TZ", buf, 1); tzset(); int32_t tz = (int32_t)((-timezone * MILLISECOND_PER_SECOND) / MILLISECOND_PER_HOUR); *tsTimezone = tz; - tz += daylight; - sprintf(outTimezoneStr, "%s (%s, %s%02d00)", buf, tzname[daylight], tz >= 0 ? "+" : "-", abs(tz)); - *outDaylight = daylight; + tz += isdst_now; + sprintf(outTimezoneStr, "%s (%s, %s%02d00)", buf, tzname[isdst_now], tz >= 0 ? "+" : "-", abs(tz)); + *outDaylight = isdst_now; #endif @@ -895,6 +897,7 @@ void taosGetSystemTimezone(char *outTimezoneStr, enum TdTimezone *tsTimezone) { struct tm tm1; taosLocalTime(&tx1, &tm1, NULL); daylight = tm1.tm_isdst; + isdst_now = tm1.tm_isdst; /* * format example: @@ -1009,6 +1012,7 @@ void taosGetSystemTimezone(char *outTimezoneStr, enum TdTimezone *tsTimezone) { time_t tx1 = taosGetTimestampSec(); struct tm tm1; taosLocalTime(&tx1, &tm1, NULL); + isdst_now = tm1.tm_isdst; /* * format example: