From 8fcf57c0771c05799767112cfb46908e3b117276 Mon Sep 17 00:00:00 2001
From: xsren <285808407@qq.com>
Date: Mon, 5 Aug 2024 12:28:49 +0800
Subject: [PATCH] l2 cache

---
 include/util/tcompare.h         |  1 +
 source/util/src/tcompare.c      | 51 +++++++++++++++++++++++++++------
 source/util/src/tworker.c       |  2 ++
 source/util/test/CMakeLists.txt |  7 +++++
 4 files changed, 53 insertions(+), 8 deletions(-)

diff --git a/include/util/tcompare.h b/include/util/tcompare.h
index 80f992f646..c7a29cad57 100644
--- a/include/util/tcompare.h
+++ b/include/util/tcompare.h
@@ -49,6 +49,7 @@ int32_t InitRegexCache();
 void    DestroyRegexCache();
 int32_t patternMatch(const char *pattern, size_t psize, const char *str, size_t ssize, const SPatternCompareInfo *pInfo);
 int32_t checkRegexPattern(const char *pPattern);
+void    DestoryThreadLocalRegComp();
 
 int32_t wcsPatternMatch(const TdUcs4 *pattern, size_t psize, const TdUcs4 *str, size_t ssize, const SPatternCompareInfo *pInfo);
 
diff --git a/source/util/src/tcompare.c b/source/util/src/tcompare.c
index 4cb48bffe5..90c1441af5 100644
--- a/source/util/src/tcompare.c
+++ b/source/util/src/tcompare.c
@@ -1290,13 +1290,12 @@ int32_t checkRegexPattern(const char *pPattern) {
   return TSDB_CODE_SUCCESS;
 }
 
-static UsingRegex **getRegComp(const char *pPattern) {
+UsingRegex **getRegComp(const char *pPattern) {
   UsingRegex **ppUsingRegex = (UsingRegex **)taosHashAcquire(sRegexCache.regexHash, pPattern, strlen(pPattern));
   if (ppUsingRegex != NULL) {
     (*ppUsingRegex)->lastUsedTime = taosGetTimestampSec();
     return ppUsingRegex;
   }
-
   UsingRegex *pUsingRegex = taosMemoryMalloc(sizeof(UsingRegex));
   if (pUsingRegex == NULL) {
     terrno  = TSDB_CODE_OUT_OF_MEMORY;
@@ -1341,20 +1340,56 @@ void releaseRegComp(UsingRegex  **regex){
   taosHashRelease(sRegexCache.regexHash, regex);
 }
 
-static int32_t doExecRegexMatch(const char *pString, const char *pPattern) {
-  int32_t ret = 0;
-  char    msgbuf[256] = {0};
+static threadlocal UsingRegex ** ppRegex;
+static threadlocal char    *pOldPattern = NULL;
+void DestoryThreadLocalRegComp() {
+  if (NULL != pOldPattern) {
+    releaseRegComp(ppRegex);
+    taosMemoryFree(pOldPattern);
+    pOldPattern = NULL;
+  }
+}
+
+int32_t threadGetRegComp(regex_t **regex, const char *pPattern) {
+  if (NULL != pOldPattern) {
+    if (strcmp(pOldPattern, pPattern) == 0) {
+      *regex = &(*ppRegex)->pRegex;
+      return 0;
+    } else {
+      DestoryThreadLocalRegComp();
+    }
+  }
+
   UsingRegex **pUsingRegex = getRegComp(pPattern);
   if (pUsingRegex == NULL) {
     return 1;
   }
+  pOldPattern = (char *)taosMemoryMalloc(strlen(pPattern) + 1);
+  if (NULL == pOldPattern) {
+    uError("Failed to Malloc when compile regex pattern %s.", pPattern);
+    return TSDB_CODE_OUT_OF_MEMORY;
+  }
+  strcpy(pOldPattern, pPattern);
+  ppRegex = pUsingRegex;
+  *regex = &(*pUsingRegex)->pRegex;
+  return 0;
+}
+
+static int32_t doExecRegexMatch(const char *pString, const char *pPattern) {
+  int32_t ret = 0;
+  char    msgbuf[256] = {0};
+
+  regex_t *regex = NULL;
+  ret = threadGetRegComp(&regex, pPattern);
+  if (ret != 0) {
+    return ret;
+  }
 
   regmatch_t pmatch[1];
-  ret = regexec(&(*pUsingRegex)->pRegex, pString, 1, pmatch, 0);
-  releaseRegComp(pUsingRegex);
+  ret = regexec(regex, pString, 1, pmatch, 0);
   if (ret != 0 && ret != REG_NOMATCH) {
     terrno =  TSDB_CODE_PAR_REGULAR_EXPRESSION_ERROR; 
-    (void)regerror(ret, &(*pUsingRegex)->pRegex, msgbuf, sizeof(msgbuf));
+    (void)regerror(ret, regex, msgbuf, sizeof(msgbuf));
     uDebug("Failed to match %s with pattern %s, reason %s", pString, pPattern, msgbuf)
   }
 
diff --git a/source/util/src/tworker.c b/source/util/src/tworker.c
index d66628d46d..1eab9365f5 100644
--- a/source/util/src/tworker.c
+++ b/source/util/src/tworker.c
@@ -106,6 +106,7 @@ static void *tQWorkerThreadFp(SQueueWorker *worker) {
   }
 
   destroyThreadLocalGeosCtx();
+  DestoryThreadLocalRegComp();
 
   return NULL;
 }
@@ -237,6 +238,7 @@ static void *tAutoQWorkerThreadFp(SQueueWorker *worker) {
 
     taosUpdateItemSize(qinfo.queue, 1);
   }
+  DestoryThreadLocalRegComp();
 
   return NULL;
 }
diff --git a/source/util/test/CMakeLists.txt b/source/util/test/CMakeLists.txt
index e8aabfe338..0d8774ba41 100644
--- a/source/util/test/CMakeLists.txt
+++ b/source/util/test/CMakeLists.txt
@@ -119,6 +119,13 @@ add_test(
     COMMAND bufferTest
 )
 
+add_executable(regexTest "regexTest.cpp")
+target_link_libraries(regexTest os util gtest_main )
+add_test(
+    NAME regexTest
+    COMMAND regexTest
+)
+
 #add_executable(decompressTest "decompressTest.cpp")
 #target_link_libraries(decompressTest os util common gtest_main)
 #add_test(