From b567548b2597e64c64750fe78d62fa31feb74b3f Mon Sep 17 00:00:00 2001
From: localvar <localvar@hotmail.com>
Date: Fri, 23 Aug 2019 20:27:45 +0800
Subject: [PATCH] fix memory leak in taos_query_a

restful commands with length between 65380 and 65536 can trigger
this issue.
---
 src/client/src/tscAsync.c | 17 ++++++++++++-----
 1 file changed, 12 insertions(+), 5 deletions(-)

diff --git a/src/client/src/tscAsync.c b/src/client/src/tscAsync.c
index e897a08270..32a15aa52f 100644
--- a/src/client/src/tscAsync.c
+++ b/src/client/src/tscAsync.c
@@ -49,6 +49,13 @@ void taos_query_a(TAOS *taos, char *sqlstr, void (*fp)(void *, TAOS_RES *, int),
     return;
   }
 
+  int32_t sqlLen = strlen(sqlstr);
+  if (sqlLen > TSDB_MAX_SQL_LEN) {
+    tscError("sql string too long");
+    tscQueueAsyncError(fp, param);
+    return;
+  }
+
   SSqlObj *pSql = (SSqlObj *)malloc(sizeof(SSqlObj));
   if (pSql == NULL) {
     tscError("failed to malloc sqlObj");
@@ -65,12 +72,10 @@ void taos_query_a(TAOS *taos, char *sqlstr, void (*fp)(void *, TAOS_RES *, int),
   pSql->fp = fp;
   pSql->param = param;
 
-  tscAllocPayloadWithSize(pCmd, TSDB_DEFAULT_PAYLOAD_SIZE);
-
-  int32_t sqlLen = strlen(sqlstr);
-  if (sqlLen > TSDB_MAX_SQL_LEN) {
-    tscError("%p sql string too long", pSql);
+  if (tscAllocPayloadWithSize(pCmd, TSDB_DEFAULT_PAYLOAD_SIZE) != TSDB_CODE_SUCCESS) {
+    tscError("%p failed to alloc payload", pSql);
     tscQueueAsyncError(fp, param);
+    free(pSql);
     return;
   }
 
@@ -78,6 +83,8 @@ void taos_query_a(TAOS *taos, char *sqlstr, void (*fp)(void *, TAOS_RES *, int),
   if (pSql->sqlstr == NULL) {
     tscError("%p failed to malloc sql string buffer", pSql);
     tscQueueAsyncError(fp, param);
+    free(pCmd->payload);
+    free(pSql);
     return;
   }