xxq250
/
homework-jianmu
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

enh(query): avoiding unnecessary remove operation.

This commit is contained in:
Haojun Liao 2022-11-30 15:24:03 +08:00
parent ae81633144
commit 8dcbafb780
1 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
source/util/src/tpagedbuf.c
View File

@ -507,7 +507,9 @@ void destroyDiskbasedBuf(SDiskbasedBuf* pBuf) {
dBufPrintStatis(pBuf); dBufPrintStatis(pBuf);
bool needRemoveFile = false;
if (pBuf->pFile != NULL) { if (pBuf->pFile != NULL) {
needRemoveFile = true;
uDebug( uDebug(
"Paged buffer closed, total:%.2f Kb (%d Pages), inmem size:%.2f Kb (%d Pages), file size:%.2f Kb, page " "Paged buffer closed, total:%.2f Kb (%d Pages), inmem size:%.2f Kb (%d Pages), file size:%.2f Kb, page "
"size:%.2f Kb, %s\n", "size:%.2f Kb, %s\n",
@ -534,9 +536,14 @@ void destroyDiskbasedBuf(SDiskbasedBuf* pBuf) {
} }
} }
if (taosRemoveFile(pBuf->path) < 0) { if (needRemoveFile) {
uDebug("WARNING tPage remove file failed. path=%s", pBuf->path); int32_t ret = taosRemoveFile(pBuf->path);
if (ret != 0) { // print the error and discard this error info
int32_t code = TAOS_SYSTEM_ERROR(errno);
uDebug("WARNING tPage remove file failed. path=%s, code:%s", pBuf->path, strerror(code));
}
} }
taosMemoryFreeClear(pBuf->path); taosMemoryFreeClear(pBuf->path);
size_t n = taosArrayGetSize(pBuf->pIdList); size_t n = taosArrayGetSize(pBuf->pIdList);