From 8b88d1ad43c5ecb39f0fbdadfaa83514d38d0715 Mon Sep 17 00:00:00 2001
From: Hongze Cheng <hzcheng@taosdata.com>
Date: Tue, 30 Nov 2021 11:24:13 +0800
Subject: [PATCH] fix multiple coredump

---
 source/dnode/vnode/impl/src/vnodeWrite.c       |  6 +++---
 source/dnode/vnode/impl/test/vnodeApiTests.cpp | 17 ++++++++++-------
 2 files changed, 13 insertions(+), 10 deletions(-)

diff --git a/source/dnode/vnode/impl/src/vnodeWrite.c b/source/dnode/vnode/impl/src/vnodeWrite.c
index ee4c6e5443..acfcbb10d5 100644
--- a/source/dnode/vnode/impl/src/vnodeWrite.c
+++ b/source/dnode/vnode/impl/src/vnodeWrite.c
@@ -23,9 +23,9 @@ int vnodeProcessWMsgs(SVnode *pVnode, SArray *pMsgs) {
     pMsg = *(SRpcMsg **)taosArrayGet(pMsgs, i);
 
     // ser request version
-    void **pBuf = &(pMsg->pCont);
+    void *   pBuf = pMsg->pCont;
     uint64_t ver = pVnode->state.processed++;
-    taosEncodeFixedU64(pBuf, ver);
+    taosEncodeFixedU64(&pBuf, ver);
 
     if (walWrite(pVnode->pWal, ver, pMsg->pCont, pMsg->contLen) < 0) {
       // TODO: handle error
@@ -49,7 +49,7 @@ int vnodeProcessWMsgs(SVnode *pVnode, SArray *pMsgs) {
       // TODO: copy here need to be extended
       memcpy(ptr, pMsg->pCont, pMsg->contLen);
 
-      // // todo: change the interface here
+      // todo: change the interface here
       uint64_t ver;
       taosDecodeFixedU64(pMsg->pCont, &ver);
       if (tqPushMsg(pVnode->pTq, ptr, ver) < 0) {
diff --git a/source/dnode/vnode/impl/test/vnodeApiTests.cpp b/source/dnode/vnode/impl/test/vnodeApiTests.cpp
index 07d61cb53a..928c5c52be 100644
--- a/source/dnode/vnode/impl/test/vnodeApiTests.cpp
+++ b/source/dnode/vnode/impl/test/vnodeApiTests.cpp
@@ -79,12 +79,13 @@ TEST(vnodeApiTest, vnodeOpen_vnodeClose_test) {
 
     int      zs = vnodeBuildReq(NULL, &vCreateSTbReq, TSDB_MSG_TYPE_CREATE_TABLE);
     SRpcMsg *pMsg = (SRpcMsg *)malloc(sizeof(SRpcMsg) + zs);
+    pMsg->msgType = TSDB_MSG_TYPE_CREATE_TABLE;
     pMsg->contLen = zs;
     pMsg->pCont = POINTER_SHIFT(pMsg, sizeof(SRpcMsg));
 
-    void **pBuf = &(pMsg->pCont);
+    void *pBuf = pMsg->pCont;
 
-    vnodeBuildReq(pBuf, &vCreateSTbReq, TSDB_MSG_TYPE_CREATE_TABLE);
+    vnodeBuildReq(&pBuf, &vCreateSTbReq, TSDB_MSG_TYPE_CREATE_TABLE);
     META_CLEAR_TB_CFG(&vCreateSTbReq);
 
     taosArrayPush(pMsgs, &(pMsg));
@@ -92,7 +93,7 @@ TEST(vnodeApiTest, vnodeOpen_vnodeClose_test) {
     vnodeProcessWMsgs(pVnode, pMsgs);
 
     free(pMsg);
-    taosArrayClear(pMsgs);
+    taosArrayDestroy(pMsgs);
     tdFreeSchema(pSchema);
     tdFreeSchema(pTagSchema);
   }
@@ -111,12 +112,14 @@ TEST(vnodeApiTest, vnodeOpen_vnodeClose_test) {
 
         int      tz = vnodeBuildReq(NULL, &vCreateCTbReq, TSDB_MSG_TYPE_CREATE_TABLE);
         SRpcMsg *pMsg = (SRpcMsg *)malloc(sizeof(SRpcMsg) + tz);
+        pMsg->msgType = TSDB_MSG_TYPE_CREATE_TABLE;
         pMsg->contLen = tz;
         pMsg->pCont = POINTER_SHIFT(pMsg, sizeof(*pMsg));
-        void **pBuf = &(pMsg->pCont);
+        void *pBuf = pMsg->pCont;
 
-        vnodeBuildReq(pBuf, &vCreateCTbReq, TSDB_MSG_TYPE_CREATE_TABLE);
+        vnodeBuildReq(&pBuf, &vCreateCTbReq, TSDB_MSG_TYPE_CREATE_TABLE);
         META_CLEAR_TB_CFG(&vCreateCTbReq);
+        free(pTag);
 
         taosArrayPush(pMsgs, &(pMsg));
       }
@@ -128,7 +131,7 @@ TEST(vnodeApiTest, vnodeOpen_vnodeClose_test) {
         free(pMsg);
       }
 
-      taosArrayClear(pMsgs);
+      taosArrayDestroy(pMsgs);
     }
   }
 
@@ -138,7 +141,7 @@ TEST(vnodeApiTest, vnodeOpen_vnodeClose_test) {
   vnodeClear();
 }
 
-TEST(vnodeApiTest, vnode_process_create_table) {
+TEST(vnodeApiTest, DISABLED_vnode_process_create_table) {
   STSchema *       pSchema = NULL;
   STSchema *       pTagSchema = NULL;
   char             stname[15];