xxq250
/
homework-jianmu
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

fix(query): check return value.

This commit is contained in:
Haojun Liao 2024-07-28 15:52:30 +08:00
parent 848b4aab4f
commit 7fbb76b441
1 changed files with 30 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

44
source/dnode/mnode/impl/test/stream/stream.cpp
View File

@ -49,7 +49,9 @@ SRpcMsg buildHbReq() {
entry.stage = 4; entry.stage = 4;
} }
taosArrayPush(msg.pTaskStatus, &entry); void* px = taosArrayPush(msg.pTaskStatus, &entry);
ASSERT(px != NULL);
} }
// (p->checkpointId != 0) && p->checkpointFailed // (p->checkpointId != 0) && p->checkpointFailed
@ -65,7 +67,8 @@ SRpcMsg buildHbReq() {
entry.checkpointInfo.activeId = 1; entry.checkpointInfo.activeId = 1;
entry.checkpointInfo.failed = true; entry.checkpointInfo.failed = true;
taosArrayPush(msg.pTaskStatus, &entry); void* px = taosArrayPush(msg.pTaskStatus, &entry);
ASSERT(px != NULL);
} }
int32_t tlen = 0; int32_t tlen = 0;
@ -122,8 +125,11 @@ void setTask(SStreamTask* pTask, int32_t nodeId, int64_t streamId, int32_t taskI
entry.stage = 1; entry.stage = 1;
entry.status = TASK_STATUS__READY; entry.status = TASK_STATUS__READY;
taosHashPut(pExecNode->pTaskMap, &id, sizeof(id), &entry, sizeof(entry)); int32_t code = taosHashPut(pExecNode->pTaskMap, &id, sizeof(id), &entry, sizeof(entry));
taosArrayPush(pExecNode->pTaskList, &id); ASSERT(code == 0);
void* px = taosArrayPush(pExecNode->pTaskList, &id);
ASSERT(px != NULL);
} }
void initStreamExecInfo() { void initStreamExecInfo() {
@ -141,7 +147,8 @@ void initNodeInfo() {
SNodeEntry entry = {0}; SNodeEntry entry = {0};
entry.nodeId = 2; entry.nodeId = 2;
entry.stageUpdated = true; entry.stageUpdated = true;
taosArrayPush(execInfo.pNodeList, &entry); void* px = taosArrayPush(execInfo.pNodeList, &entry);
ASSERT(px != NULL);
} }
} // namespace } // namespace
@ -149,15 +156,17 @@ class StreamTest : public testing::Test { // 继承了 testing::Test
protected: protected:
static void SetUpTestSuite() { static void SetUpTestSuite() {
mndInitExecInfo(); int32_t code = mndInitExecInfo();
ASSERT(code == 0);
initStreamExecInfo(); initStreamExecInfo();
initNodeInfo(); initNodeInfo();
std::cout<<"setup env for streamTest suite"<<std::endl; (void) printf("setup env for streamTest suite");
} }
static void TearDownTestSuite() { static void TearDownTestSuite() {
std::cout<<"tearDown env for streamTest suite"<<std::endl; (void) printf("tearDown env for streamTest suite");
} }
virtual void SetUp() override { virtual void SetUp() override {
@ -182,7 +191,8 @@ TEST_F(StreamTest, handle_error_in_hb) {
TEST_F(StreamTest, kill_checkpoint_trans) { TEST_F(StreamTest, kill_checkpoint_trans) {
STrans trans; STrans trans;
trans.id = 100; trans.id = 100;
mndStreamRegisterTrans(&trans, MND_STREAM_CHECKPOINT_NAME, defStreamId); int32_t code = mndStreamRegisterTrans(&trans, MND_STREAM_CHECKPOINT_NAME, defStreamId);
ASSERT(code == 0);
SMnode* pMnode = static_cast<SMnode*>(taosMemoryCalloc(1, sizeof(SMnode))); SMnode* pMnode = static_cast<SMnode*>(taosMemoryCalloc(1, sizeof(SMnode)));
{// init sdb {// init sdb
@ -203,7 +213,8 @@ TEST_F(StreamTest, kill_checkpoint_trans) {
const char* pDbName = "test_db_name"; const char* pDbName = "test_db_name";
int32_t len = strlen(pDbName); int32_t len = strlen(pDbName);
taosHashPut(info.pDBMap, pDbName, len, NULL, 0); int32_t code = taosHashPut(info.pDBMap, pDbName, len, NULL, 0);
ASSERT(code == 0);
killAllCheckpointTrans(pMnode, &info); killAllCheckpointTrans(pMnode, &info);
@ -225,12 +236,17 @@ TEST_F(StreamTest, kill_checkpoint_trans) {
pTask->id.streamId = defStreamId; pTask->id.streamId = defStreamId;
pTask->id.taskId = 1; pTask->id.taskId = 1;
pTask->exec.qmsg = (char*)taosMemoryCalloc(1,1); pTask->exec.qmsg = (char*)taosMemoryCalloc(1,1);
taosThreadMutexInit(&pTask->lock, NULL); int32_t code = taosThreadMutexInit(&pTask->lock, NULL);
ASSERT(code == 0);
taosArrayPush(pLevel, &pTask); void* px = taosArrayPush(pLevel, &pTask);
ASSERT(px != NULL);
taosArrayPush(pStream->tasks, &pLevel); px = taosArrayPush(pStream->tasks, &pLevel);
mndCreateStreamResetStatusTrans(pMnode, pStream); ASSERT(px != NULL);
int32_t code = mndCreateStreamResetStatusTrans(pMnode, pStream);
ASSERT(code == 0);
tFreeStreamObj(pStream); tFreeStreamObj(pStream);
sdbCleanup(pMnode->pSdb); sdbCleanup(pMnode->pSdb);